[docker-in-docker] - toggle ip6tables settings value as option by gauravsaini04 · Pull Request #1068 · devcontainers/features

Gaurav Saini (gauravsaini04) · 2024-07-29T10:09:16Z

Feature Name

Docker - in - Docker

Changelog

Changes to install.sh and devcontainer-feature.json files for features' issue #1023

Checklist

Checked that applied changes work as expected

Co-authored-by: Samruddhi Khandale <samruddhikhandale@github.com>

Samruddhi Khandale (samruddhikhandale)

Looks wonderful ⚡

Co-authored-by: Samruddhi Khandale <samruddhikhandale@github.com>

Samruddhi Khandale (samruddhikhandale)

Looks great, thank you!

[docker-in-docker] - toggle ip6tables settings value as option

2f64c44

Gaurav Saini (gauravsaini04) requested a review from a team as a code owner July 29, 2024 10:09

Samruddhi Khandale (samruddhikhandale) requested changes Jul 29, 2024

View reviewed changes

Comment thread src/docker-in-docker/devcontainer-feature.json Outdated

Comment thread src/docker-in-docker/devcontainer-feature.json Outdated

Comment thread src/docker-in-docker/install.sh Outdated

Comment thread src/docker-in-docker/install.sh Outdated

Gaurav Saini (gauravsaini04) and others added 3 commits July 30, 2024 06:36

Merge branch 'devcontainers:main' into docker_in_docker_#_1023

322a350

Update src/docker-in-docker/devcontainer-feature.json

2fe16aa

Co-authored-by: Samruddhi Khandale <samruddhikhandale@github.com>

Update src/docker-in-docker/devcontainer-feature.json

e585c05

Co-authored-by: Samruddhi Khandale <samruddhikhandale@github.com>

Shardul Srivastava (shardulsrivastava) mentioned this pull request Aug 3, 2024

DevContainer Environment Fails to Start due to Ipv6 Breaking changes cilium/cilium#34156

Open

3 tasks

Gaurav Saini (gauravsaini04) added 9 commits August 7, 2024 04:06

Merge branch 'devcontainers:main' into docker_in_docker_#_1023

9cdc2be

Merge branch 'devcontainers:main' into docker_in_docker_#_1023

88cb142

Merge branch 'devcontainers:main' into docker_in_docker_#_1023

89ab50c

Merge branch 'devcontainers:main' into docker_in_docker_#_1023

037c05a

Merge branch 'devcontainers:main' into docker_in_docker_#_1023

cbcc284

ip6tables - can be toggled

0a42b76

changes as requested

c3915be

change to add test file..

054bdd5

Merge branch 'main' into docker_in_docker_#_1023

6d1d44f

Gaurav Saini (gauravsaini04) mentioned this pull request Aug 19, 2024

docker-in-docker feature breaks with Codespaces+Kind and docker v27+ (docker's ipv6 breaking changes) #1023

Closed

Gaurav Saini (gauravsaini04) added 2 commits August 20, 2024 03:57

Merge branch 'main' into docker_in_docker_#_1023

ca631a5

Merge branch 'devcontainers:main' into docker_in_docker_#_1023

f011055

Gaurav Saini (gauravsaini04) mentioned this pull request Aug 21, 2024

[docker-in-docker] - method 2 - daemon.json creation - #1023 #1101

Closed

Gaurav Saini (gauravsaini04) added 3 commits August 27, 2024 10:26

Merge branch 'devcontainers:main' into docker_in_docker_#_1023

c6b43f6

Merge branch 'devcontainers:main' into docker_in_docker_#_1023

dbb3aaa

changes for docker_build_older test passing

b485b58

Gaurav Saini (gauravsaini04) marked this pull request as draft August 28, 2024 05:56

Gaurav Saini (gauravsaini04) added 6 commits August 28, 2024 06:13

misc change

1ef2903

CHANGE

30bc624

chg

7d04ed7

minor change to make tests pass

8d7277e

for sh compatibility

1300bf9

change for version

9cde8c3

Gaurav Saini (gauravsaini04) added 4 commits August 28, 2024 13:40

for test passing

cced5b5

minor commit

eadcf01

version added to a test scenario

6e2914f

changes

b3fd0b5

Gaurav Saini (gauravsaini04) marked this pull request as ready for review August 28, 2024 15:00

Gaurav Saini (gauravsaini04) added 5 commits August 29, 2024 07:01

LOGIC was moved outside the init file for faster initialization times

0e180ad

changes

8aa19ee

logic updated !

6bcce46

chg

fb7c3da

default value to be null

ec74e20

Samruddhi Khandale (samruddhikhandale) requested changes Sep 3, 2024

View reviewed changes

Samruddhi Khandale (samruddhikhandale) linked an issue Sep 3, 2024 that may be closed by this pull request

docker-in-docker feature breaks with Codespaces+Kind and docker v27+ (docker's ipv6 breaking changes) #1023

Closed

Gaurav Saini (gauravsaini04) added 4 commits September 4, 2024 11:23

Merge branch 'main' into docker_in_docker_#_1023

abb1e23

changes as suggested in review comments..

c0b2c36

by mistake

c1c4eba

another small change

d15c392

Samruddhi Khandale (samruddhikhandale) requested changes Sep 5, 2024

View reviewed changes

requested changes in comments (review pr)

51fe00a

Samruddhi Khandale (samruddhikhandale) reviewed Sep 6, 2024

View reviewed changes

Comment thread src/docker-in-docker/install.sh Outdated

Comment thread src/docker-in-docker/install.sh Outdated

Samruddhi Khandale (samruddhikhandale) requested changes Sep 6, 2024

View reviewed changes

Comment thread src/docker-in-docker/install.sh Outdated

change as requested

c54789a

Samruddhi Khandale (samruddhikhandale) requested changes Sep 9, 2024

View reviewed changes

Comment thread src/docker-in-docker/install.sh Outdated

Comment thread src/docker-in-docker/install.sh Outdated

Gaurav Saini (gauravsaini04) added 2 commits September 10, 2024 09:57

Merge branch 'devcontainers:main' into docker_in_docker_#_1023

d4a2545

changes as suggested in review comments

0a5d389

Samruddhi Khandale (samruddhikhandale) previously approved these changes Sep 11, 2024

View reviewed changes

Comment thread src/docker-in-docker/install.sh Outdated

Update src/docker-in-docker/install.sh

e181e20

Co-authored-by: Samruddhi Khandale <samruddhikhandale@github.com>

Gaurav Saini (gauravsaini04) dismissed Samruddhi Khandale (samruddhikhandale)’s stale review via e181e20 September 11, 2024 05:54

Samruddhi Khandale (samruddhikhandale) approved these changes Sep 16, 2024

View reviewed changes

Samruddhi Khandale (samruddhikhandale) merged commit d926879 into devcontainers:main Sep 16, 2024

Rob Murray (robmry) mentioned this pull request Nov 29, 2024

Load module ip6_tables to make docker --ipv6 networks work #1206

Open

Uh oh!

Conversation

Gaurav Saini (gauravsaini04) commented Jul 29, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Samruddhi Khandale (samruddhikhandale) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Samruddhi Khandale (samruddhikhandale) left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants