[docker-in-docker] - method 2 - daemon.json creation - #1023 - #1101
Closed
Gaurav Saini (gauravsaini04) wants to merge 9 commits into
Closed
[docker-in-docker] - method 2 - daemon.json creation - #1023#1101Gaurav Saini (gauravsaini04) wants to merge 9 commits into
Gaurav Saini (gauravsaini04) wants to merge 9 commits into
Conversation
Samruddhi Khandale (samruddhikhandale)
requested changes
Aug 20, 2024
| MICROSOFT_GPG_KEYS_URI="https://packages.microsoft.com/keys/microsoft.asc" | ||
| DOCKER_MOBY_ARCHIVE_VERSION_CODENAMES="bookworm buster bullseye bionic focal jammy noble" | ||
| DOCKER_LICENSED_ARCHIVE_VERSION_CODENAMES="bookworm buster bullseye bionic focal hirsute impish jammy noble" | ||
| IP6_TABLES="${IP6TABLES:-""}" |
There was a problem hiding this comment.
Can we look into fixing test failures?
Contributor
Author
There was a problem hiding this comment.
when I test for ip6tables -L command inside built container, getting the following output:
root@a139636130dc:/# ip6tables -L
ip6tables v1.8.4 (legacy): can't initialize ip6tables table `filter': Table does not exist (do you need to insmod?)
Perhaps ip6tables or your kernel needs to be upgraded.
| # Create the daemon.json file with the provided value | ||
| cat <<JSON_EOF > /etc/docker/daemon.json | ||
| { | ||
| "ip6tables": $DEFAULT_IP6_TABLES |
There was a problem hiding this comment.
Instead of this, have you tried using --ip6tables=<value> same like DEFAULT_ADDRESS_POOL ?
Contributor
Author
There was a problem hiding this comment.
Pls check for the above mentioned method as a solution here
There was a problem hiding this comment.
If we have #1068 open, why do we need this PR which attempts to do the same thing?
This reverts commit db672f2.
…emon_creation_#1023' into docker-in-docker_daemon_creation_#1023
Contributor
Author
|
#1068 is an alternate method as a solution for the same issue. |
Gaurav Saini (gauravsaini04)
deleted the
docker-in-docker_daemon_creation_#1023
branch
September 10, 2024 04:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature Name
Description
/etc/docker/daemon.jsonfile before starting the docker daemonchangelog
/etc/docker/daemon.jsonfile before starting the docker daemon