Skip to content

Enhancements in CUDA Support - #699

Merged
Samruddhi Khandale (samruddhikhandale) merged 11 commits into
devcontainers:mainfrom
ar90n:add-cuda-installing-options
Sep 27, 2023
Merged

Enhancements in CUDA Support#699
Samruddhi Khandale (samruddhikhandale) merged 11 commits into
devcontainers:mainfrom
ar90n:add-cuda-installing-options

Conversation

@ar90n

Copy link
Copy Markdown
Contributor

This PR introduces several updates to improve CUDA support which is derived from #461

Added specifications for a new option to provide users with more flexibility.

  1. Incorporated support for newer CUDA and CuDNN versions.
  2. Implemented libcudnn8-dev installation support
  3. Implemented nvcc installation support
  4. Implemented CUDA toolkit installation support.

These enhancements aim to make the developer experience smoother for those working on CUDA projects.

@ar90n
Masahiro Wada (ar90n) requested a review from a team as a code owner September 24, 2023 14:46
@ar90n

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding cool new Feature options, we appreciate it.
Left some comments!

Comment thread src/nvidia-cuda/README.md Outdated
Comment thread src/nvidia-cuda/install.sh
Comment thread test/nvidia-cuda/install_all_options.sh
Comment thread src/nvidia-cuda/devcontainer-feature.json
Comment thread src/nvidia-cuda/README.md Outdated
@ar90n

Copy link
Copy Markdown
Contributor Author

Samruddhi Khandale (@samruddhikhandale)
Thanks for your thorough review and detailed comments. I fixed some issues you mentioned. Please check them.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, opened #704 for the failing test.

(This PR is not causing the failures, hence, we are good to merge this in)

Comment thread src/nvidia-cuda/devcontainer-feature.json
@samruddhikhandale
Samruddhi Khandale (samruddhikhandale) merged commit 243671e into devcontainers:main Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants