Repository navigation
id: validation — delivered Phase 11 items (claimed-done audit) #1078
Description
Validation task: delivered Phase 11 items
Drew (2026-10-26): make tasks to validate the delivered work and ensure the tests are thorough and pass.
Scope: the Phase 11 items currently claimed done — F11.1 relay kit (#249), F11.4 fast CI lane (#224), F11.5 injected clock (#808), F11.6 fuel metrics + budgets (#247), F11.10 large-module split (#808), F11.11 single client projection (#250/#256/#808), F11.13 typed error codes (#808), F11.14 cheaper Screen (#248), F11.17 view-trap resilience (#547). The Phase 11 status record (.opencode/plans/2026-10-20_phase-11-status.md) contradicts itself on several of these, and #841 tracks plan/status inconsistencies — this task establishes ground truth from the code and tests, not from the documents.
Work:
- For each item: find its exit criterion in
.opencode/plans/phase-11-foundations.md, find the test(s) that check it, run them, and record pass/fail here. - Run the fast lane and the full suite; record timings (F11.4's exit is a median PR feedback time — measure it, don't assume it).
- Add tests where a 'done' item has no test that would catch its regression.
- File a separate issue per failure/gap and link them here; note any corrections needed for docs(id): Phase 13 plan/issues cite pre-split line numbers; F11.12 status inconsistent across plans #841.
Exit: every claimed-done F11 item is either verified by a passing test or has its own tracked issue; results recorded here.
Coordination (2026-10-26 reprioritization, per Drew): every id roadmap item now has its own GitHub issue, and priority encodes the order: (1) the path to Phase 12 — now + priority/high; (2) Phase 12 itself — next; (3) Phase 13 and long-term ideas — priority/low. The dashboard mirrors this list (org Project "Developing Today" #4, Area id-train; Grist Program roadmap, Area id). If this item turns out to be blocked, wrong, or superseded, park or close it with a note rather than letting it stall the queue — dropping an issue is always allowed; silently stalling is not.
Acceptance criteria
- Every claimed-done Phase 11 item in scope (F11.1 fix(id): vendor relay kit under tests/fixtures so Nix CI can read it #249, F11.4 test(id): align bulk sync deadline with runtime #224, F11.5, F11.6 feat(id): measure per-call guest fuel and guard it with budgets #247, F11.10, F11.11 fix(id): redact install seed from join projections #250/fix(id): show world chat only to participants who may chat or read history #256, F11.13, F11.14 fix(id): make territory's view fit eight seats within the default fuel #248, F11.17 id(world): F11.17 a trapping view must not poison the world #547) is marked verified or failed against its exit criterion in
.opencode/plans/phase-11-foundations.md, with the checking test named. - The fast lane and the full suite are run and their timings recorded on this issue; F11.4's median PR feedback time is measured, not assumed.
- Any 'done' item with no regression-catching test gains one, or the gap is filed as its own issue.
- Every failure/gap found has its own filed issue linked here; corrections needed for docs(id): Phase 13 plan/issues cite pre-split line numbers; F11.12 status inconsistent across plans #841 are noted.
Activity
developing-today commentedon Oct 27, 2026
CODE-221
dezren39 commentedon Oct 27, 2026
Intake review
Related: Phase 11 items: #249, #224, #808, #247, #250, #256, #248, #547 · plan/status inconsistencies: #841
Notes: Validation/audit task, not a fix: ground truth comes from code and tests, since the Phase 11 status record contradicts itself. Nothing in the body suggests the work is already done — it was filed 2026-10-27 by Drew as part of the validation batch (#1075–#1078).
Risks: Scope is wide (nine F11 items plus two suite runs); the F11.4 timing measurement needs CI history, not a single run.
Suggested approach: Work item-by-item against the plan's exit criteria; record the per-item table on the issue as you go; file gap issues immediately rather than batching them at the end.
Labels were already normalized by the filer (kind, source/human, status/needs-triage, priority, effort, app/id all present); this pass appended the acceptance criteria above and adds
meta/enriched.🤖 Agent note · filed
dezren39 commentedon Oct 27, 2026
Sequencing (Drew's Phase 12 reprioritization, 2026-10-26): this audit is step 7 of the ordered Path-to-Phase-12 queue in #1235 — work it after #1077, before the next step. The full order, the tier rules, and the drop rule live in #1235. Reminder of this issue's contract: verify the phase against its plan, add missing tests until the suite is thorough, and file a separate issue for every gap found — the follow-ups join the tier-1 queue.
61 remaining items
dezren39 commentedon Oct 27, 2026
🤖 Agent note · handed off
queue/queued+status/needs-triage.verified— slice 5 lib test rerun, then closeout) and cannot be claimed again until an operator raises its cap. Resume point is the task's checkpoint progress.dezren39 commentedon Oct 27, 2026
🤖 Agent note · picked up
dezren39 commentedon Oct 27, 2026
🤖 Agent note · done
Slice 5 — coverage gaps + CLOSEOUT: the Phase 11 claimed-done audit is complete
Fresh verification this slice on current main
95cd41f0(GitHub API and laptoporigin/mainagree): all nine checking tests named in slices 2–3 are still present (git grepatorigin/main), the F11.5 sleep count is unchanged at 9tokio::time::sleepcalls inpkgs/id/src/world/tests.rs, and slices 2–3 executed the named tests passing (slice 2 executed-test confirmation; slice 3 ✅ marks), backed by green push-to-mainidruns (e.g. run 40492562723 on452d69e6, success).test_vendored_kit_matches_the_design_doc_copy(relay_ops.rs) — drift test, executed ✅ slice 2ManualClock, 19 passed in 0.06s (slice 2) — the <1s half verified; the literal "nosleepin world tests" half unmet: 9 polling sleeps remain (recounted this slice on fresh main)checked_in_examples_stay_within_fuel_budgetscovers every checked-in guest example;measure_reports_fuel_per_call_kind_for_a_checked_in_module✅ slice 3cli.rs2,200 prod lines, nosrc/file over 2,500 (rescan this slice). But no test, lint, flake check, or CI job enforces the limit — slices 2 and 5 were manual one-off scansthe_session_serializes_events_only_through_the_projection+the_projection_redacts_chat_and_the_install_seed✅ slice 3CapErrorstructurally mandates a code;a_refused_schedule_carries_its_reason_on_the_wireexecuted ✅ slice 2territory_view_fits_the_default_fuel_with_every_seat_taken(full-house view ~16% of the 10M limit, exit ≤40%) + the F11.6 budget row ✅ slice 3a_trapping_view_degrades_to_an_error_and_recovers_on_the_next_event+fuel_exhaustion_traps_instead_of_hanging✅ slice 3Timings (acceptance item 2): recorded in slice 4 — fast lane median 19m09s over ten PR runs (run table in comment 6440590696); full lane (
id-e2e-nightly) 1h57m / 2h44m / 2h37m on its three completed runs that day. The slice-5 lib-suite rerun planned by the previous attempt was superseded: per the CI-first rule the suite's evidence is the green CI runs above plus the slices 2–3 executed tests, not another local compile.#841 corrections (accumulated across the audit): F11.1, F11.6, F11.10, F11.11, F11.13, F11.14, F11.17 = verified-done. F11.5 = partial (#1326). F11.4 / #551's "done" no longer holds (#1401). The F11.6 headroom table's territory row (78.0%) is pre-#248 — current measured full-house baseline is ~16% (budget row 21%). The Phase 11 plan text still describes F11.6/F11.11 as "in progress" on branches that have since merged (#247, #250/#256, #543).
Exit check: every claimed-done F11 item is either verified by a passing test (7), or has its own tracked issue (F11.4 → #1401, F11.5 → #1326, F11.10's enforcement gap → #1438). This audit is complete; closing this issue — the follow-ups live in their own issues, and the Path to Phase 12 (#1235, step 7) can be checked off on this evidence.