Skip to content

Dashboard comments: add a pending/triage queue view and make comment counts kind-aware #1210

Closed

Description

@dezren39

Part of epic #1184 (PM stack coherence review, 2026-10-26).

Comment UX has no pending-queue view, counts conflate kinds, and failure copy promises a retry that does not exist. Evidence: comments.ts CommentsStore.counts() counts all kinds per object, so comment badges cannot signal 'awaiting triage'; pending counts exist only inside /api/comments.json and are rendered by no page. Failed GitHub comments read 'a fleet poster will retry', but no retry code exists, and there is no edit/delete/retract for any kind.

Acceptance:

  • Every state=new/pending/failed comment in the store is reachable in <=2 clicks from the nav via a queue view (or Needs-you section).
  • Badge counts distinguish notes from actionable comments by kind/state.
  • Failed items show age + last error, and retry copy is corrected until a retry exists.

Acceptance criteria

  • Every state=new/pending/failed comment in the store is reachable in ≤2 clicks from the nav via a queue view (or Needs-you section).
  • Badge counts distinguish notes from actionable comments by kind/state.
  • Failed items show age + last error, and retry copy is corrected until a retry exists.

Activity

  1. added
    kind/featureNew feature or capability request
    priority/normalOrdinary priority (the default)
    app/pm-stackpm-stack (Pad/Grist) in developing-today/code
    on Oct 27, 2026
  2. developing-today commented on Oct 27, 2026

    @developing-today
    Contributor
  3. added
    source/humanFiled directly by a human
    effort/mMedium: expected under 1 day of work
    meta/enrichedIntake review done: acceptance criteria, links, and normalized labels added
    on Oct 28, 2026
  4. dezren39 commented on Oct 28, 2026

    @dezren39
    MemberAuthor

    Intake review

    Fleet-monitor intake pass (protocol §5), 2026-10-28.

    Still live: verified this run — the issue is open, and a merged-PR search found no PR that explicitly resolves it (no fixes-reference; the only real merged hit in the search set, PR #1318, does not mention it). It does not merely look solved.

    Related: Related: epic #1184; the comment loop is also the subject of #1213's conditional end-to-end test.

    Notes / risks: Risk: the false 'a fleet poster will retry' copy is a live honesty bug — fix the copy even if the queue view slips.

    Suggested approach: Suggested approach: expose the existing /api/comments.json pending counts in a nav-reachable queue view; make counts kind/state-aware in CommentsStore.counts().

    Labels normalized this pass (see the issue's label set); acceptance criteria appended to the body as the standard ## Acceptance criteria section, original body preserved verbatim above it.

  5. added
    work/assignedQueue worker lifecycle state
    queue/claimedQueue worker lifecycle state
    and removed on Nov 1, 2026
  6. 17 remaining items

  7. dezren39 commented on Nov 1, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · parked — Drew-owned PR boundary

  8. added
    queue/claimedQueue worker lifecycle state
    and removed
    status/parkedDeliberately paused with a recorded resume condition
    queue/parkedQueue task is parked (waiting on CI, time, or an event)
    on Nov 1, 2026
  9. dezren39 commented on Nov 1, 2026

    @dezren39
    MemberAuthor

    Agent note (task 4922, lane B): picked up (attempt 2) and resumed the canonical PR #3987 rather than restarting — revalidated fresh: PR #3987 OPEN at cac2674, no hard-stop labels; Codex review completed on that head with no findings. Verification this shift (laptop worktree ~/git/fleet/4922): the #1210 test files pass 15/15 (comments-queue-1210 + curation-1497); full aggregator suite 923 pass / 1 fail, and the single failure (slice3.test.ts registry source assertion) fails identically on clean main — pre-existing, environment-dependent, unrelated to this PR. Merging PR #3987.

  10. added a commit that references this issue on Nov 1, 2026
  11. dezren39 commented on Nov 1, 2026

    @dezren39
    MemberAuthor

    Agent note (task 4922, lane B): done — PR #3987 merged (2f8ab78). All four acceptance items verified: queue view at /comments + /api/comments/queue.json listing new/pending/failed with kind/state-aware counts (commentKindCounts/countsDetailed), failed items show age + last error with honest retry copy, #1210 tests 15/15 pass, full aggregator suite 923/924 with the one slice3 failure proven pre-existing on clean main (environment-dependent registry assertion, unrelated). Codex review of PR #3987 completed with no findings. Closing.

  12. added
    queue/claimedQueue worker lifecycle state
    work/assignedQueue worker lifecycle state
    and removed
    queue/claimedQueue worker lifecycle state
    work/assignedQueue worker lifecycle state
    on Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

app/pm-stackpm-stack (Pad/Grist) in developing-today/codeeffort/mMedium: expected under 1 day of workkind/featureNew feature or capability requestmeta/enrichedIntake review done: acceptance criteria, links, and normalized labels addedpriority/normalOrdinary priority (the default)queue/claimedQueue worker lifecycle statesource/humanFiled directly by a humanstatus/in-progressQueue worker lifecycle statework/assignedQueue worker lifecycle state

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions