Phase 2: removal: weak is stored but not built #161

Activity

1. github-actions

   assigned

   dezren39

   on Oct 12, 2026
2. dezren39 commented on Oct 24, 2026

   

   dezren39

   on Oct 24, 2026

   MemberAuthor

   More actions

   id train triage (2026-10-24): needs-decision — project owner: weak-removal semantics (build it or defer explicitly); only the policy field is recorded today.
3. dezren39

   added

   work/assignedQueue worker lifecycle stateQueue worker lifecycle state

   queue/claimedQueue worker lifecycle stateQueue worker lifecycle state

   status/in-progressQueue worker lifecycle stateQueue worker lifecycle state

   on Oct 29, 2026
4. dezren39 commented on Oct 29, 2026

   

   dezren39

   on Oct 29, 2026

   MemberAuthor

   More actions

   🤖 Agent note · picked up

   • Agent: queue worker (repo-worker-code), Lane C shift
   • Session / ID: queue task 2011
   • Found via: queue claim
   • Task: Triage issue Phase 2: removal: weak is stored but not built #161 — verify on current main whether weak removal is stored-but-not-built, then route a scoped follow-up or close with evidence
   • Expectation: effort s; done = triage verdict posted with code citations at HEAD, follow-up packet enqueued if confirmed, labels synced
   • Links: task 2011 (repo-health-code-pilot)
5. dezren39 commented on Oct 29, 2026

   

   dezren39

   on Oct 29, 2026

   MemberAuthor

   More actions

   🤖 Agent note · done — triage verdict: CONFIRMED, routed to fix task 2941

   • Agent: queue worker (repo-worker-code), Lane C shift
   • Session / ID: queue task 2011 (triage) → follow-up task 2941 (small_fix)
   • Found via: queue claim
   • Task: Verified Phase 2: removal: weak is stored but not built #161 against current main; weak removal is stored but not built
   • Verdict / evidence (at HEAD, 2026-10-29):
     • pkgs/id/src/groups/policy.rs: Removal::{Strong (default), Weak} is defined and recorded on Policy, with the module's own note: "The rules belong to the voiding track; this module only records the setting."
     • The only read of policy.removal in the tree is display: pkgs/id/src/commands/group.rs removal_name() for the policy command output. No code in pkgs/id/src/groups/fold.rs or pkgs/id/src/groups/delegation.rs consults it.
     • The voiding paths apply STRONG semantics unconditionally: delegation.rs fn void() voids a grant when a settled removal of its grantor is concurrent with it (its comment cites design §6.2/§7.3 strong), and fold.rs fn void_device() does the same for device grants. So a group configured removal=weak silently gets strong behaviour today.
     • Semantics are NOT an open question: design §6.3 is decided — "Weak remove: only the authority check applies. Events by M in R's causal future are invalid. Concurrent events stand." The earlier needs-decision flag is answered by the design itself; what is missing is the build, not a decision.
   • Route: follow-up packet enqueued as queue task 2941 (small_fix, dedupe repo-health:v1:fix:developing-today/code:issue:161): branch the concurrent-voiding in the delegation and fold/device paths on policy.removal, keep strong byte-identical, add weak-vs-strong tests including the §6.4 week-late case adapted to weak. Issue stays open under queue/queued for that task.
   • Expectation: done for triage = this verdict + task 2941 queued + labels synced
6. dezren39

   added

   queue/queuedHas a queued task in the Supabase agent queueHas a queued task in the Supabase agent queue

   work/assignedQueue worker lifecycle stateQueue worker lifecycle state

   queue/claimedQueue worker lifecycle stateQueue worker lifecycle state

   status/in-progressQueue worker lifecycle stateQueue worker lifecycle state

   and removed

   status/in-progressQueue worker lifecycle stateQueue worker lifecycle state

   queue/claimedQueue worker lifecycle stateQueue worker lifecycle state

   work/assignedQueue worker lifecycle stateQueue worker lifecycle state

   queue/queuedHas a queued task in the Supabase agent queueHas a queued task in the Supabase agent queue

   on Oct 29, 2026
7. 98 remaining items

   Load more
8. dezren39

   removed

   queue/parkedQueue task is parked (waiting on CI, time, or an event)Queue task is parked (waiting on CI, time, or an event)

   status/parkedDeliberately paused with a recorded resume conditionDeliberately paused with a recorded resume condition

   on Oct 29, 2026
9. dezren39 commented on Oct 29, 2026

   

   dezren39

   on Oct 29, 2026

   MemberAuthor

   More actions

   Agent note — verified again this shift; parked on blocker PR #2335 + merge-queue stall #2403

   Queue task 2941 resumed by Lane B. PR #2204 at baf1f0f7: Codex summary at this head reports no findings, all 3 review threads resolved, 24 checks SUCCESS — the only failures are the fmt/clippy family. Independently re-ran the defining tests on the laptop worktree: cargo test --lib groups:: in pkgs/id — 93 passed, 0 failed. A --failed rerun of run 40942941660 was requested (attempt 2 queued).

   The fmt/clippy failures are the pre-existing on-main breakage that blocker PR #2335 fixes, plus the recurring Magic Nix Cache throttling; they are not from this PR's diff. Resume (batch with tasks 2977/PR #2219 and 3005/PR #2377): #2335 merged + rerun green + #2403 fixed → enqueue #2204, verify merged, complete task 2941.
10. dezren39

    added

    queue/parkedQueue task is parked (waiting on CI, time, or an event)Queue task is parked (waiting on CI, time, or an event)

    status/parkedDeliberately paused with a recorded resume conditionDeliberately paused with a recorded resume condition

    and removed

    queue/claimedQueue worker lifecycle stateQueue worker lifecycle state

    status/in-progressQueue worker lifecycle stateQueue worker lifecycle state

    on Oct 29, 2026
11. dezren39 commented on Oct 30, 2026

    

    dezren39

    on Oct 30, 2026

    MemberAuthor

    More actions

    🤖 Agent note · picked up → parked

    • Agent: queue worker (repo-worker-code), Lane C shift
    • Session / ID: queue task 2941 (resume, awaiting_ci), shift 2026-10-29 18:47 CDT
    • Found via: queue claim
    • Task: Revalidated PR groups: build weak removal — concurrent grants and device grants stand (#161) #2204 fresh: OPEN, MERGEABLE, head baf1f0f. All Codex P2 findings dispositioned (fixed in 2da794e and baf1f0f with thread replies; two further rounds dispositioned as not reproducing at head, with reasons). The only red checks are the fmt/clippy family (cargo-fmt, rustfmt, treefmt, clippy-lint + aggregate) — inherited main debt fixed by keystone PR id: rustfmt meta_client.rs + drop expect() in tags parser — unbreak main fmt/clippy (#2151) #2335.
    • Blocker: id: rustfmt meta_client.rs + drop expect() in tags parser — unbreak main fmt/clippy (#2151) #2335 cannot land while the merge queue is stalled (ci: merge queue ejects every PR — no merge since #2233 (10:57Z), entries dropped 2-6 min into AWAITING_CHECKS #2403; main frozen at 5a34fa7). Batch resume with tasks 2977 (PR id(encryption): surface stalled delivery — Session::stalled_delivery() (#187) #2221) and 3005 (PR fix(usage-hub): enforce disabled_providers in quota pools + regression test (#1114) #2377) per the existing batch note.
    • Expectation: resume when id: rustfmt meta_client.rs + drop expect() in tags parser — unbreak main fmt/clippy (#2151) #2335 has merged and ci: merge queue ejects every PR — no merge since #2233 (10:57Z), entries dropped 2-6 min into AWAITING_CHECKS #2403 is fixed: rerun/update-branch groups: build weak removal — concurrent grants and device grants stand (#161) #2204 to green, enqueue, verify merged, complete task 2941.
    • Links: PR groups: build weak removal — concurrent grants and device grants stand (#161) #2204 · keystone id: rustfmt meta_client.rs + drop expect() in tags parser — unbreak main fmt/clippy (#2151) #2335 · blocker ci: merge queue ejects every PR — no merge since #2233 (10:57Z), entries dropped 2-6 min into AWAITING_CHECKS #2403
12. dezren39

    closed this as completedin #2204on Oct 30, 2026
13. developing-today

    added

    status:done

    on Oct 30, 2026
14. dezren39 commented on Oct 30, 2026

    

    dezren39

    on Oct 30, 2026

    MemberAuthor

    More actions

    Lane A (queue task 2941): verified fresh — PR #2204 MERGED 2026-10-30T01:00:10Z (merge commit fb3b47b) once blocker #2403 cleared. Task 2941 completing as already_done; stale queue/status/work labels removed.
    🤖 Agent note · picked up → done (already_done)

    • Agent: queue worker (repo-worker-code), Lane A shift
    • Session / ID: queue task 2941 (resume, implementation_complete), shift 2026-10-29 21:04 CDT
    • Found via: queue claim
    • Links: PR groups: build weak removal — concurrent grants and device grants stand (#161) #2204
15. dezren39

    removed

    status:done

    status/parkedDeliberately paused with a recorded resume conditionDeliberately paused with a recorded resume condition

    queue/parkedQueue task is parked (waiting on CI, time, or an event)Queue task is parked (waiting on CI, time, or an event)

    work/assignedQueue worker lifecycle stateQueue worker lifecycle state

    on Oct 30, 2026