Repository navigation
id-core: lib tests do not compile — world_presentation tests use vt100, which is not an id-core dependency #3923
Description
Found 2026-11-01 by queue lane F while verifying task 5845 (PR #3891) on the laptop; pre-existing on main, unrelated to that PR (which touches only pkgs/id/src/abuse.rs).
Evidence
cargo test --libin pkgs/id (workspace default members) fails:
error[E0433]: cannot find module or crate vt100 in this scope×4,could not compile id-core (lib test).- First site:
crates/id-core/src/world_presentation.rs:689— test code callsvt100::Parser::new(24, 80, 0). crates/id-core/Cargo.tomldeclares novt100dependency at all.vt100 = "=0.16.2"exists only in the ROOT package manifest (pkgs/id/Cargo.tomlline ~149, dev-dependencies) — a leftover of the pkgs/id: split the monolith crate into sub-crates along module seams (prioritized by Drew 2026-11-01) #3447 crate split: world_presentation moved into id-core, its test-only dependency did not.
Impact
Any workspace-level cargo test in pkgs/id fails before running a single test, including for unrelated packages; workers have been working around it with cargo test -p id --lib, which silently skips id-core's own test suite.
Acceptance
vt100 = "=0.16.2"added tocrates/id-core[dev-dependencies] (matching the root pin), or the test moved/rewritten to not need vt100.cargo test --libin pkgs/id compiles and runs id-core tests green (or any remaining failures are pre-existing and filed separately).- CI command for pkgs/id exercises the workspace default members so this cannot silently regress again.
Acceptance criteria
-
vt100 = "=0.16.2"is added tocrates/id-core[dev-dependencies] (matching the root pin), or the world_presentation tests are moved/rewritten to not need vt100. -
cargo test --libinpkgs/idcompiles and runs, including id-core's own test suite (no longer silently skipped via-p id). - Same root-cause fix as issue build(id): id-core lib test cannot find crate vt100 — nixos-rebuild switch cannot complete (blocks code#3720 fold) #3951; the two issues cross-reference each other and only close on an explicit fixes-reference.
Metadata
Metadata
Assignees
Labels
Package/app: id (pkgs/ or apps/ in this repo)Trivial: expected under 30 minutes of workSomething isn't working (prefixed form of the classic bug label)Intake review done: acceptance criteria, links, and normalized labels addedOrdinary priority (the default)Filed or worked by the queue/worker pilotQueue packet kind: verify, reproduce, and route this item
Activity
dezren39 commentedon Nov 1, 2026
Additional evidence from queue task 5842 (lane B, 2026-11-01):
crates/id-core/src/connectivity.rs:292,296: tests useiroh::test_utilsandCaTlsConfig::insecure_skip_verify, which need iroh'stest-utilsfeature — also only in the parent crate's dev-dependencies.queue/5842-805-screenpatch-phase-1): addedvt100 = "=0.16.2"andiroh = { version = "1", features = ["test-utils"] }to id-core[dev-dependencies](same pins as the parent). Result on the laptop:cargo test -p id-core --lib— 238 passed, 0 failed.cargo test --all-features -p id --libfails to compilesrc/world_ssh.rs—render_ansi_diffispub(crate)in id-core (world_presentation.rs:457) but called from the parent crate (world_ssh.rs:921), andauth_publickeysignature mismatch against the resolved russh (VerifiedPublicKey); plussrc/web/assets.rsRustEmbed requires a builtpkgs/id/web/distin a bare worktree. The parent crate's session/shell-contract tests therefore could not be run locally for task 5842; they remain a CI/verification gap.dezren39 commentedon Nov 1, 2026
Intake review
Fleet monitor intake enrichment (protocol §5), 2026-11-01.
Still live: checked merged PRs and recent work in this area — no merged PR explicitly resolves this issue, and the filing evidence is from current main today. Not closing.
Related: Related: issue #3951 is the SAME root cause filed from the nixos-rebuild side; one fix serves both. Issue #3962 references this issue for the same world_presentation.rs neighbourhood (distinct ssh breakage).
Risks / notes: Impact is understated by the workaround culture:
cargo test -p id --libsilently skips id-core's suite, so regressions in world_presentation currently have no running tests on main.Suggested approach: Add the dev-dependency to id-core (matching the root pin =0.16.2), refresh Cargo.lock, and verify a full workspace
cargo test --libcompile in pkgs/id.Labels normalized (kind/source/status/priority/effort/app as applicable) and
meta/enrichedapplied; an## Acceptance criteriasection was appended to the issue body (original body preserved verbatim above it).dezren39 commentedon Nov 3, 2026
🤖 Agent note · triaged (compile defect fixed; CI gap remains)
1a180ae5), workerrepo-worker-codemain; the compile break is gone, one acceptance bullet is not.pkgs/idCI step to exercise the workspace default members; this issue closes with that PR.Part 1 — compile defect: FIXED (evidence).
pkgs/id/crates/id-core/Cargo.tomlnow carriesvt100 = "=0.16.2"andiroh = { version = "1", features = ["test-utils"] }under[dev-dependencies], with a comment naming the pkgs/id: split the monolith crate into sub-crates along module seams (prioritized by Drew 2026-11-01) #3447 crate-split fallout. Added by PR fix(design-code): repoint :18745 legs to antigravity-direct :18751 (#1413, unblocks opencode#1409) #4626, merged 2026-11-02 (commit2f62ce6c9).maintoday:cargo check -p id-core --testsfinishes successfully (one pre-existingmissing-docswarning atcrates/id-core/src/world_limits.rs:362, unrelated). The fourcannot find module or crate vt100errors no longer reproduce.Part 2 — CI coverage: STILL OPEN (the reason this issue stays open).
.github/workflows/id-check.yml:197still runsnix develop ./pkgs/id --command cargo test -p id— that excludesid-core's own test target, which is exactly the silent skip that let this break land unnoticed. The issue's third acceptance bullet asks for the workspace default members; that change has not been made.Ordering: no blockers. The follow-up is a one-step CI edit; it does not touch Rust sources. No branch or competing PR opened from this triage.
Labels synced: claim labels cleared; the queue task is complete and task 8493 carries the remaining work.
10 remaining items
dezren39 commentedon Nov 4, 2026
🤖 Agent note · handed off
dezren39 commentedon Nov 4, 2026
Picked up by lane code-k as task 9195 (triage). Verifying issue #3923 against current main on the laptop clone.
dezren39 commentedon Nov 4, 2026
🤖 Agent note · done (triage verdict: ALREADY FIXED at current main — closing)
pkgs/id/crates/id-core/Cargo.tomlnow carriesvt100 = "=0.16.2"under[dev-dependencies], with an in-file comment naming this exact failure: "Crate-split fallout (pkgs/id: split the monolith crate into sub-crates along module seams (prioritized by Drew 2026-11-01) #3447): the presentation ANSI-diff tests and the connectivity startup-wait tests moved into this crate with the modules, but their test-only dependencies stayed behind in the parent crate's dev-dependencies, so this crate's test targets did not compile on their own. Same pins as the parent crate. Dev only; no runtime effect." Thevt100::Parseruses inpkgs/id/crates/id-core/src/world_presentation.rs(lines 995-1027) are all inside#[test]functions, so the dev-dependency is the correct and complete fix.