Repository navigation
id(world_ssh): crate does not compile with the ssh feature — render_ansi_diff visibility + russh auth_publickey signature #3962
Description
Found 2026-11-01 by queue worker lane F (task 5847) while verifying PR #3960: the id crate does not compile with the ssh feature enabled, on clean main (verified by stashing all local changes and re-running the check — identical errors, so this is pre-existing and unrelated to PR #3960).
Repro (on the laptop, pkgs/id):
cargo check --features ssh
Errors:
src/world_ssh.rs:921— E0624: methodrender_ansi_diffis private. It ispub(crate)incrates/id-core/src/world_presentation.rs:462, but theidcrate calls it across the crate boundary created by the pkgs/id: split the monolith crate into sub-crates along module seams (prioritized by Drew 2026-11-01) #3447 split.src/world_ssh.rs:308— E0053:auth_publickeyhas an incompatible type for the russh server trait: expectedVerifiedPublicKey<'_>, found&russh::keys::PublicKey.
Acceptance:
-
cargo check --features ssh(and--features web,ssh) passes inpkgs/id. - CI exercises the
sshfeature for theidcrate, or the gap is explicitly documented — this breakage survived because the checked feature set apparently excludesssh.
Related but distinct: issue #3923 / issue #3951 (id-core lib tests vs the vt100 crate, same world_presentation.rs neighbourhood).
Acceptance criteria
-
cargo check --features sshandcargo check --features web,sshpass inpkgs/idon current main. - The
render_ansi_diffvisibility error (world_ssh.rs:921) and the russhauth_publickeysignature error (world_ssh.rs:308) are both fixed, not just one. - CI exercises the
sshfeature for theidcrate, or the exclusion is explicitly documented so this breakage class cannot survive silently again.
Metadata
Metadata
Assignees
Labels
Package/app: id (pkgs/ or apps/ in this repo)Small: expected under 2 hours of workSomething isn't working (prefixed form of the classic bug label)Intake review done: acceptance criteria, links, and normalized labels addedOrdinary priority (the default)Filed or worked by the queue/worker pilotQueue packet kind: verify, reproduce, and route this item
Activity
dezren39 commentedon Nov 1, 2026
Intake review
Fleet monitor intake enrichment (protocol §5), 2026-11-01.
Still live: checked merged PRs and recent work in this area — no merged PR explicitly resolves this issue, and the filing evidence is from current main today. Not closing.
Related: Related: issue #3923 and issue #3951 (id-core vt100 dev-dependency, same world_presentation.rs neighbourhood — a different breakage, do not conflate). No merged PR fixes the ssh feature build; verified live on current main by the filing lane (task 5847, PR #3960 verification).
Risks / notes: Two independent errors (visibility across the #3447 crate split, and a russh trait signature change) — a fix for one will surface the other. The CI feature-coverage gap is the systemic half of this issue.
Suggested approach: Fix render_ansi_diff visibility at the id-core boundary (pub use or a public wrapper, not pub(crate) widening by default), update auth_publickey to the current russh VerifiedPublicKey signature, then add the ssh feature to a CI check matrix for pkgs/id.
Labels normalized (kind/source/status/priority/effort/app as applicable) and
meta/enrichedapplied; an## Acceptance criteriasection was appended to the issue body (original body preserved verbatim above it).test(id): prove #796 item 9-6 — SSH window_change refits shell view (#…
dezren39 commentedon Nov 3, 2026
🤖 Agent note · evidence (task 6684, verifying the 9-6 gate)
999440c07).cargo check --features sshpasses inpkgs/id;render_ansi_diffis nowpub(fixed by test(id): prove #796 items 9-3 and 9-5-remainder bounds #4681, commit 92f68b3) and the russh 0.65auth_publickey(user: &str, public_key: &PublicKey)signature type-checks. All 33world_sshtests pass with the ssh feature. The item-9-6 proving test has now landed as PR test(id): prove #796 item 9-6 — SSH window_change refits shell view #4762 (merged).developing-today commentedon Nov 3, 2026
agent-note:v1
state: triaged (coverage pass)
Coverage pass 2026-11-03: reviewed in the fleet-wide per-issue pass (drift / overlap / already-handled / stale / blockers / ordering). Verdict: still live; queued in repo-health-code-pilot as triage at priority 40 (priority/normal). If this is already handled at current main, the triage closes it with evidence; if it needs splitting, the triage files the split.
Found via: coverage pass 2026-11-03
dezren39 commentedon Nov 3, 2026
🤖 Agent note · picked up
dezren39 commentedon Nov 3, 2026
🤖 Agent note · done
render_ansi_diffispub(pkgs/id/crates/id-core/src/world_presentation.rs:658, called from pkgs/id/src/world_ssh.rs:923), andauth_publickeytakesVerifiedPublicKey<'_>(pkgs/id/src/world_ssh.rs:307-311) — exactly the two signatures issue id(world_ssh): crate does not compile with the ssh feature — render_ansi_diff visibility + russh auth_publickey signature #3962 required.cargo check --features sshin pkgs/id — pass (warnings only);cargo check --features web,ssh— pass.cargo-checkandclippy-lintjust recipes run with--all-features(which includesssh), andcargo-checkis in the PR gate list (.github/scripts/id-pr-checks.txt, run by id-check.yml) — the ssh feature is exercised in CI now.