Skip to content

id phase-9/10: verification debt — delivered faster than verified, no dedicated issues carry it #796

Open

Description

@dezren39

Finding

Phases 9 and 10 added many capabilities quickly and their own follow-up record says they "were delivered faster than they were verified." There are no dedicated Phase 9/10 issues carrying that verification debt, so the acceptance criteria for individual P9/P10 slices have no issue to close against.

Evidence

Why it matters

The Phase 11 issues will make the platform measurable, but they do not individually verify each P9/P10 acceptance criterion (screen DTO bounds/parity, keyboard/viewport/paste parity, execution profile ceilings, RocJson/RocGrid/RocCap/RocText correctness, roles/directory, fixtures, scheduled events). Without a tracking issue, that debt is carried only in prose and can silently drop out of view.

Suggested scope (for the implementer to plan)

Enumerate the P9/P10 acceptance criteria that lack a test or an issue, and either file a per-item issue or add the missing verification. Defer to Phase 11/12 issues where they already cover the criterion (reference, don't duplicate).

Acceptance criteria

Activity

  1. dezren39 commented on Oct 24, 2026

    @dezren39
    MemberAuthor

    Child inventory (from the phase 9/10 review; per-item acceptance criteria with no proving test). Real gaps were split into their own issues: #811 (joiner resize poisons world) and #812 (directory feed not built). #813 covers the Roc expect() tests never running.

    Remaining verification-debt items (add a test to prove each; no code change unless the test reveals a bug):

    Each is a small, targeted test addition; the proving tests and commands are in the review's report.

  2. added
    kind/testTest coverage, test infrastructure, or test-only fixes
    priority/lowNice to have; do when convenient
    effort/lLarge: multi-day or open-ended; expect staged check-ins
    app/idPackage/app: id (pkgs/ or apps/ in this repo)
    meta/enrichedIntake review done: acceptance criteria, links, and normalized labels added
    on Oct 26, 2026
  3. dezren39 commented on Oct 26, 2026

    @dezren39
    MemberAuthor

    Intake review

    Related: The child inventory comment on this issue (2026-10-24) is the working list — real gaps already split into #811 (joiner resize), #812 (directory feed), and #813 (Roc expect() tests); Phase 11 issues #539–#555 cover a measurable subset (fuel budgets, benchmarks, bytes-per-frame, replay self-check, module size, compiler pin) and must be referenced, not duplicated. Items 9-2 relates to #724/#761 (presenter-validator divergence).

    Still live (verified 2026-10-26): no merged PR references or resolves this tracker, and the inventory items (9-2, 9-3, 9-5, 9-6, 9-7, 9-8, 10-2) remain without proving tests or dedicated issues. Not solved; do not close.

    Notes / risks: This is a tracker, not a single fix — its failure mode is becoming a permanent umbrella. The appended acceptance criteria make closure mechanical: every inventory item test-covered or spun out. Each item is individually small (a targeted test addition), so this should shrink item by item rather than land as one large PR.

    Suggested approach: Work the inventory top-down; for each item either add the proving test (link the PR here) or file its own issue and link it. Re-check the Phase 11 set before filing anything new.

    🤖 Agent note · intake enrichment

    • Agent: fleet monitor (repo-fleet-monitor)
    • Session / ID: repo-fleet-monitor run, 2026-10-26 00:19 CDT (05:19 UTC)
    • Found via: monitor reconciliation
    • Task: Intake enrichment (§5 pass): acceptance criteria appended, labels normalized, still-live verified.
    • Expectation: effort/l as a tracker — each inventory item is a small test addition in its own right.
  4. added
    priority/highImportant and time-sensitive
    nowOrg Project gate: active priority — orchestrator adds to the board
    mode/onlineFully doable remotely: design, config, code, cloud
    work/assignedQueue worker lifecycle state
    and removed
    priority/lowNice to have; do when convenient
    on Oct 27, 2026
  5. 63 remaining items

  6. developing-today commented on Nov 3, 2026

    @developing-today
    Contributor

    agent-note:v1
    state: reviewed (coverage loop-back)
    Coverage pass 2026-11-03, loop-back review: this issue was re-reviewed (drift / overlap / already-handled / stale / blockers / ordering) so every open issue in the four repos is reviewed and in the system. Verdict: still live; in the system as task 8090 (triage, queued, priority 50) in repo-health-code-pilot. Labels audited and synced. If it is already handled at current main, its triage closes it with evidence; if oversized, the triage files the split; blockers belong on this issue.
    Found via: coverage loop-back 2026-11-03

  7. added
    queue/claimedQueue worker lifecycle state
    work/assignedQueue worker lifecycle state
    and removed
    queue/queuedHas a queued task in the Supabase agent queue
    on Nov 4, 2026
  8. dezren39 commented on Nov 4, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · picked up

  9. dezren39 commented on Nov 4, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · triaged (tracker still live; last 3 items now split + routed)

    • Agent: queue worker (repo-worker-code), lane code-b
    • Session / ID: task 8090 (triage)
    • Found via: queue claim (fleet-monitor safety net — this issue carried queue/queued with no live task)

    Fresh verification (2026-11-04): issue #796 OPEN, no hard-stop labels. PR #4681 MERGED (2026-11-03T01:34Z — items 9-3 DTO determinism/caps and 9-5 chat.history/records.read bounds proven) and PR #4762 MERGED (2026-11-03T05:02Z — item 9-6 SSH window-change test on main), both re-checked fresh this shift. Item 9-7 remains covered by world_session service-level tests (per task 7481 triage, 2026-11-03 at main 1e3763faf). Earlier splits #811 (closed) and #813 (closed) stand; #812 (directory feed) remains open as its own issue. The Phase 9/10 validation audits #1076/#1077 (closed 2026-10-27) already ran the broad per-slice walk — they do not cover these three per-item proving tests, which is exactly the residue this tracker carries.

    Remaining items — now split into dedicated issues + queue packets (the queue's dedupe design allows only one live fix packet per issue, so per-item routing goes through per-item issues, an option this issue's acceptance criteria explicitly name):

    Item Split issue Queue task
    9-2 web/terminal parity harness #5237 task 8989
    9-8 CLI verb coverage #5238 task 8990
    10-2 schedule fire visibility/ceiling (verify partial coverage first) #5239 task 8991

    Disposition: task 8090 completes as triaged. Issue #796 stays OPEN as the tracker — it closes only when #5237, #5238, and #5239 close with evidence, per its own acceptance criteria. Labels reset so nothing reads in-flight for this triage.

  10. dezren39 commented on Nov 4, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · item 10-2 gap analysis (task 8991, lane code-s; split issue #5239, PR #5298)

    Per #796 item 10-2 acceptance ("gap analysis recorded on issue #796 naming which assertions were already covered and which were added"), verified at origin/main 707689e32:

  11. added a commit that references this issue on Nov 4, 2026
  12. dezren39 commented on Nov 4, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · item 10-2 PROVEN (task 8991, lane code-m): PR #5298 merged (8bb1e43), split issue #5239 closed. Both assertions from the gap analysis now have passing proving tests (schedule_tests 21/21): a schedule fire never reaches joiners via events_after (System events filtered by project_event_for), and schedule.at outside a set ceiling is refused (outside_ceiling), counted, and pends nothing. Two initially-failing assertions were test bugs (a substring false positive on needs_snapshot; is_granted/error-code mixups) — production behavior was correct in both cases; details on PR #5298 / issue #5239.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

app/idPackage/app: id (pkgs/ or apps/ in this repo)effort/lLarge: multi-day or open-ended; expect staged check-inskind/testTest coverage, test infrastructure, or test-only fixesmeta/enrichedIntake review done: acceptance criteria, links, and normalized labels addedmode/onlineFully doable remotely: design, config, code, cloudnowOrg Project gate: active priority — orchestrator adds to the boardpriority/highImportant and time-sensitivesource/creatorFiled by the new-issue-creator jobtask/triageQueue packet kind: verify, reproduce, and route this item

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions