Repository navigation
build(id): id-core doc tests E0433 — examples still use id:: paths after the #3447 crate split (blocks #3720 fold) #4073
Description
Fifth distinct id breakage today, found by the #4015 nix-build verification (2026-11-01): with the lib suite finally green, nix build .#id-web (pkgs/id) reached the doc tests and failed:
Doc-tests id_core: 0 passed; 5 failed
error[E0433]: cannot find module or crate `id` in this scope
crates/id-core/src/tuple.rs:32 use id::tuple::{TupleEncoder, decode};
crates/id-core/src/tuple.rs:172 use id::tuple::TupleEncoder;
crates/id-core/src/discovery.rs:118 use id::discovery::parse_defaults;
crates/id-core/src/discovery.rs:339 use id::discovery::PeerAnnouncement;
crates/id-core/src/discovery.rs:392 use id::discovery::{PeerDiscovery, PeerAnnouncement};
The #3447 crate split (5969721) moved tuple and discovery from the id crate into id-core, but their doc examples kept the old id:: import paths. They were never reached since the split because every build died earlier in the suite (#3787 → #3951 → #4015 → #4047). In the same nix run the full test suite proper passed: 1987 passed, 0 failed — only these 5 doc tests fail.
Fix: use id_core::… at the five sites (the modules are pub in id-core; example bodies are unchanged). Rides PR #4027 with the #4015/#4047 fixes; this is the last known gate for the #3720 fold switch.
Acceptance criteria
- The five doc examples in
crates/id-core(tuple.rs,discovery.rs) compile againstid_core::paths; nouse id::doc paths remain in id-core. - Doc tests for id-core pass (e.g.
cargo test -p id-core --doc, or thenix build .#id-webdoc-test stage that surfaced this) with 0 failures. - No production code changes — doc examples only.
Activity
fix(id): id-core doc examples use id_core:: paths after the crate spl…
dezren39 commentedon Nov 1, 2026
Fixed in PR #4027 (five
use id_core::import paths). Verified on host:cargo test -p id-core --doc— 5 passed, 0 failed.dezren39 commentedon Nov 2, 2026
Intake review
idbreakage found in one day, each revealed only after the previous gate cleared. Evidence is complete (exact files/lines + error text in the body).pubin id-core.use id::doc paths toid_core::, then run the id-core doc tests / thenix build .#id-webstage that surfaced it.dezren39 commentedon Nov 2, 2026
Fixed in PR #4027, merge commit ee75087 — verified as a git object, ancestor of origin/main, with
use id_core::grepped at both tuple.rs sites in origin/main's tree. Doc tests pass on host (5/5) and in the greennix build .#id-webcheckPhase.