main CI failure: pm-aggregator tests (run 41616879803)

main CI failure — pm-aggregator tests

Run: https://github.com/developing-today/code/actions/runs/41616879803
Workflow: pm-aggregator tests (.github/workflows/pm-aggregator-tests.yml)
Branch: main
Head SHA: a5d536f
Event: push
Failed jobs: test

Failed log excerpt (`gh run view 41616879803 --repo developing-today/code --log-failed`, first ~60 lines)

test	Typecheck	2026-11-03T10:09:48.5200139Z ##[group]Run bunx tsc --noEmit
test	Typecheck	2026-11-03T10:09:48.5200628Z ^[[36;1mbunx tsc --noEmit^[[0m
test	Typecheck	2026-11-03T10:09:48.5240095Z shell: /usr/bin/bash -e {0}
test	Typecheck	2026-11-03T10:09:48.5240507Z ##[endgroup]
test	Typecheck	2026-11-03T10:09:53.5183852Z src/dns.ts(191,13): error TS2531: Object is possibly 'null'.
test	Typecheck	2026-11-03T10:09:53.5186709Z src/projects.ts(151,27): error TS2345: Argument of type 'number | null | undefined' is not assignable to parameter of type 'number | undefined'.
test	Typecheck	2026-11-03T10:09:53.5188252Z   Type 'null' is not assignable to type 'number | undefined'.
test	Typecheck	2026-11-03T10:09:53.5190168Z src/push.ts(9,21): error TS7016: Could not find a declaration file for module 'web-push'. '/home/runner/work/code/code/pm-stack/aggregator/node_modules/web-push/src/index.js' implicitly has an 'any' type.
test	Typecheck	2026-11-03T10:09:53.5192719Z   Try `npm i --save-dev @types/web-push` if it exists or add a new declaration (.d.ts) file containing `declare module 'web-push';`
test	Typecheck	2026-11-03T10:09:53.5194752Z test/charges-collect.test.ts(72,28): error TS2345: Argument of type '{ at: string; label: string; amountUsd: number; }[]' is not assignable to parameter of type 'ChargeRow[]'.
test	Typecheck	2026-11-03T10:09:53.5196839Z   Type '{ at: string; label: string; amountUsd: number; }' is missing the following properties from type 'ChargeRow': method, source
test	Typecheck	2026-11-03T10:09:53.5198308Z test/charges-collect.test.ts(72,52): error TS2769: No overload matches this call.
test	Typecheck	2026-11-03T10:09:53.5200616Z   Overload 1 of 2, '(expected: ChargeRow[]): void', gave the following error.
test	Typecheck	2026-11-03T10:09:53.5201889Z     Argument of type '{ at: string; label: string; amountUsd: number; }[]' is not assignable to parameter of type 'ChargeRow[]'.
test	Typecheck	2026-11-03T10:09:53.5203456Z       Type '{ at: string; label: string; amountUsd: number; }' is missing the following properties from type 'ChargeRow': method, source
test	Typecheck	2026-11-03T10:09:53.5204703Z   Overload 2 of 2, '(expected: NoInfer<ChargeRow[]>): void', gave the following error.
test	Typecheck	2026-11-03T10:09:53.5205798Z     Argument of type '{ at: string; label: string; amountUsd: number; }[]' is not assignable to parameter of type 'ChargeRow[]'.
test	Typecheck	2026-11-03T10:09:53.5207145Z       Type '{ at: string; label: string; amountUsd: number; }' is missing the following properties from type 'ChargeRow': method, source
test	Typecheck	2026-11-03T10:09:53.5208145Z test/charges-collect.test.ts(83,25): error TS2345: Argument of type '{ at: string; label: string; amountUsd: number; }[]' is not assignable to parameter of type 'ChargeRow[]'.
test	Typecheck	2026-11-03T10:09:53.5209100Z   Type '{ at: string; label: string; amountUsd: number; }' is missing the following properties from type 'ChargeRow': method, source
test	Typecheck	2026-11-03T10:09:53.5210050Z test/charges-collect.test.ts(93,28): error TS2345: Argument of type '{ at: string; label: string; amountUsd: number; }[]' is not assignable to parameter of type 'ChargeRow[]'.
test	Typecheck	2026-11-03T10:09:53.5210979Z   Type '{ at: string; label: string; amountUsd: number; }' is missing the following properties from type 'ChargeRow': method, source
test	Typecheck	2026-11-03T10:09:53.5211985Z test/charges-collect.test.ts(93,52): error TS2769: No overload matches this call.
test	Typecheck	2026-11-03T10:09:53.5212721Z   Overload 1 of 2, '(expected: ChargeRow[]): void', gave the following error.
test	Typecheck	2026-11-03T10:09:53.5213337Z     Argument of type '{ at: string; label: string; amountUsd: number; }[]' is not assignable to parameter of type 'ChargeRow[]'.
test	Typecheck	2026-11-03T10:09:53.5214119Z       Type '{ at: string; label: string; amountUsd: number; }' is missing the following properties from type 'ChargeRow': method, source
test	Typecheck	2026-11-03T10:09:53.5214785Z   Overload 2 of 2, '(expected: NoInfer<ChargeRow[]>): void', gave the following error.
test	Typecheck	2026-11-03T10:09:53.5215767Z     Argument of type '{ at: string; label: string; amountUsd: number; }[]' is not assignable to parameter of type 'ChargeRow[]'.
test	Typecheck	2026-11-03T10:09:53.5216542Z       Type '{ at: string; label: string; amountUsd: number; }' is missing the following properties from type 'ChargeRow': method, source
test	Typecheck	2026-11-03T10:09:53.5217479Z test/charges-collect.test.ts(99,28): error TS2345: Argument of type '{ at: string; label: string; amountUsd: number; }[]' is not assignable to parameter of type 'ChargeRow[]'.
test	Typecheck	2026-11-03T10:09:53.5218718Z   Type '{ at: string; label: string; amountUsd: number; }' is missing the following properties from type 'ChargeRow': method, source
test	Typecheck	2026-11-03T10:09:53.5219400Z test/clinepass-adapter.test.ts(207,27): error TS2769: No overload matches this call.
test	Typecheck	2026-11-03T10:09:53.5219894Z   Overload 1 of 2, '(expected: null): void', gave the following error.
test	Typecheck	2026-11-03T10:09:53.5220719Z     Argument of type '"***"' is not assignable to parameter of type 'null'.
test	Typecheck	2026-11-03T10:09:53.5221178Z   Overload 2 of 2, '(expected: null): void', gave the following error.
test	Typecheck	2026-11-03T10:09:53.5221919Z     Argument of type '"***"' is not assignable to parameter of type 'null'.
test	Typecheck	2026-11-03T10:09:53.5222396Z test/feed.test.ts(701,57): error TS2769: No overload matches this call.
test	Typecheck	2026-11-03T10:09:53.5222879Z   Overload 1 of 2, '(expected: RegistrySanitization): void', gave the following error.
test	Typecheck	2026-11-03T10:09:53.5223706Z     Type '{ id: string; source: string; label: string; taskRefs: never[]; }' is missing the following properties from type 'SessionRecord': agentId, agentLabel, parentId, status
test	Typecheck	2026-11-03T10:09:53.5224561Z   Overload 2 of 2, '(expected: NoInfer<RegistrySanitization>): void', gave the following error.
test	Typecheck	2026-11-03T10:09:53.5225404Z     Type '{ id: string; source: string; label: string; taskRefs: never[]; }' is missing the following properties from type 'SessionRecord': agentId, agentLabel, parentId, status
test	Typecheck	2026-11-03T10:09:53.5226162Z test/feed.test.ts(703,29): error TS2769: No overload matches this call.
test	Typecheck	2026-11-03T10:09:53.5226660Z   Overload 1 of 2, '(expected: SessionRecord[] | undefined): void', gave the following error.
test	Typecheck	2026-11-03T10:09:53.5227480Z     Type '{ id: string; source: string; label: string; taskRefs: never[]; }' is missing the following properties from type 'SessionRecord': agentId, agentLabel, parentId, status
test	Typecheck	2026-11-03T10:09:53.5228334Z   Overload 2 of 2, '(expected: NoInfer<SessionRecord[] | undefined>): void', gave the following error.
test	Typecheck	2026-11-03T10:09:53.5229089Z     Argument of type '{ id: string; source: string; label: string; taskRefs: never[]; }[]' is not assignable to parameter of type 'SessionRecord[]'.
test	Typecheck	2026-11-03T10:09:53.5230060Z       Type '{ id: string; source: string; label: string; taskRefs: never[]; }' is missing the following properties from type 'SessionRecord': agentId, agentLabel, parentId, status
test	Typecheck	2026-11-03T10:09:53.5230924Z test/feed.test.ts(712,40): error TS2769: No overload matches this call.
test	Typecheck	2026-11-03T10:09:53.5231928Z   Overload 1 of 2, '(expected: SessionRecord[] | undefined): void', gave the following error.
test	Typecheck	2026-11-03T10:09:53.5232679Z     Argument of type '{ id: string; source: string; label: string; taskRefs: never[]; }[]' is not assignable to parameter of type 'SessionRecord[]'.
test	Typecheck	2026-11-03T10:09:53.5233664Z       Type '{ id: string; source: string; label: string; taskRefs: never[]; }' is missing the following properties from type 'SessionRecord': agentId, agentLabel, parentId, status
test	Typecheck	2026-11-03T10:09:53.5234635Z   Overload 2 of 2, '(expected: NoInfer<SessionRecord[] | undefined>): void', gave the following error.
test	Typecheck	2026-11-03T10:09:53.5235918Z     Argument of type '{ id: string; source: string; label: string; taskRefs: never[]; }[]' is not assignable to parameter of type 'SessionRecord[]'.
test	Typecheck	2026-11-03T10:09:53.5237419Z       Type '{ id: string; source: string; label: string; taskRefs: never[]; }' is missing the following properties from type 'SessionRecord': agentId, agentLabel, parentId, status
test	Typecheck	2026-11-03T10:09:53.5238715Z test/feed.test.ts(989,38): error TS2769: No overload matches this call.
test	Typecheck	2026-11-03T10:09:53.5254848Z   Overload 1 of 2, '(expected: UnmatchedCharge[] | undefined): void', gave the following error.
test	Typecheck	2026-11-03T10:09:53.5256108Z     Type '{ merchant: string; normalized: string; amountUsd: number; at: string; source: string; }' is not assignable to type 'UnmatchedCharge'.
test	Typecheck	2026-11-03T10:09:53.5257091Z       Types of property 'source' are incompatible.
test	Typecheck	2026-11-03T10:09:53.5257928Z         Type 'string' is not assignable to type 'ChargeSourceKind'.
test	Typecheck	2026-11-03T10:09:53.5258757Z   Overload 2 of 2, '(expected: NoInfer<UnmatchedCharge[] | undefined>): void', gave the following error.

Key errors: the job's Run aggregator tests step passed; the Typecheck step (bunx tsc --noEmit) failed with exit code 2. Errors include src/dns.ts(191,13) TS2531 (Object is possibly 'null'), src/projects.ts(151,27) TS2345 (number | null not assignable), src/push.ts(9,21) TS7016 (no declaration file for module 'web-push'), test/charges-collect.test.ts (ChargeRow literals missing method/source), test/feed.test.ts (SessionRecord / UnmatchedCharge shape mismatches), and further errors in test/clinepass-adapter.test.ts, test/github-billing.test.ts, test/overview.test.ts, test/projects.test.ts, test/quota-current.test.ts, test/registry-view.test.ts, test/token-adapter.test.ts — see the excerpt and the full run log. Fresh round: prior track #4827 closed 2026-11-03T10:09:22Z and this run was created 2026-11-03T10:09:23Z on the new head, with a different failure mode (typecheck, not the #4827 aggregator test failures). The failed job(s) above are the fix target; verify against this log, not only a local reproduction.

Filed by main-ci-failure-fix-trigger (fleet). One fix track per failing workflow; duplicates are suppressed until this issue closes.

🤖 Agent note · filed

Agent: main-ci-failure-fix-trigger (fleet)
Session / ID: main-ci watch cron run 2026-11-03 04:09 CST (2026-11-03T10:14:14Z)
Found via: main-ci watch
Task: Fix the failed job(s): test — run https://github.com/developing-today/code/actions/runs/41616879803
Expectation: done when a main-branch run of pm-aggregator tests completes with conclusion success after the fix merges, verified against the run log.
Links: run https://github.com/developing-today/code/actions/runs/41616879803 · prior (closed) track main CI failure: pm-aggregator tests (run 41610811089) #4827

Agent note — picked up (queue task 7173, openchamber-scheduled-lane, 2026-11-03)

Revalidated: #4852 OPEN; CI run 41616879803 failed on current target bunx tsc --noEmit. Reproduced on clean current main 08c6e3bb4 in worktree ~/git/fleet/7173-4852-aggregator-typecheck (branch queue/7173-4852-aggregator-typecheck): 27 TypeScript diagnostics across 12 files. The test step itself passes; only Typecheck fails. Root areas include 3 source diagnostics (dns.ts, projects.ts, missing web-push declaration) and stale test fixtures/type signatures in 9 test files. This is materially broader than a small localized fix; preserving the reproduction/worktree for the next launch rather than patching a dozen unrelated fixtures under the launch cutoff.

agent-note:v1
event: picked_up (resume)
task: 7173 (repo-health-code-pilot; worker repo-worker-code; lane 262eb403-3347-4a7c-ba6b-e7bc263ca853 / openchamber-scheduled-lane)
state: resumed from parked at 2026-11-03T14:40Z; lease 2700s, run budget ~30 min.
verified: Fresh checks 2026-11-03T14:41Z — #4852 OPEN, no hard-stop labels; branch queue/7173-4852-aggregator-typecheck exists at 38c5e04 (matches recorded progress); worktree ~/git/fleet/7173-4852-aggregator-typecheck present; no PR open for the branch.
next: merge main into the branch, fix the remaining 24 test-fixture tsc errors, re-run tsc + targeted bun tests, open the PR.
labels: queue/queued + queue/parked + status/parked -> queue/claimed + status/in-progress; work/assigned retained.

fix(aggregator): clear the remaining typecheck and nav-test failures (#…

Merge pull request #4971 from developing-today/queue/7173-4852-aggreg…

agent-note:v1
event: parked (fix merged, awaiting main-run verification)
task: 7173 (repo-health-code-pilot; worker repo-worker-code; lane 262eb403-3347-4a7c-ba6b-e7bc263ca853 / openchamber-scheduled-lane)
state: resumed 14:40Z, merged 14:48:32Z, parked 14:56Z for 20 min — CI queue backlog, not a failure.
work: merged origin/main into queue/7173-4852-aggregator-typecheck (d3ef3b4), fixed the last src error (duplicate esc import in src/server.ts), and cleared all 24 test-fixture TS errors across 12 test files (ChargeRow method+source, SessionRecord/UNMATCHED fixture types, fetch mocks with preconnect, SnapshotRecord/QuotaWindow/CredentialRef narrowing). Assertions unchanged.
also fixed: main was independently red on bun test — nav.test.ts #1135 rejected ANY overflow-x in the 720px block, which the deliberate 390px audit fix (97e0624) added as body { overflow-x: clip }; assertion now scoped to nav selectors. No open PR/issue owned that regression.
verified: bunx tsc --noEmit clean; bun test 1328 pass / 0 fail / 6060 expect / 96 files on pushed SHA bc50211.
artifact: PR #4971 #4971 — MERGED, merge commit 91c3b19.
remaining: only the acceptance run — pm-aggregator tests run 41657353717 on 91c3b19 was still queued after ~6 min (runner backlog).
resume: read run 41657353717 fresh; success -> complete as fixed_merged (ci pass, merge_sha 91c3b19); failure -> read --log-failed and fix on a new branch.
labels: queue/claimed + status/in-progress -> queue/parked + status/parked; work/assigned retained.

🤖 Agent note · done

Agent: queue worker (repo-worker-code), lane code-h
Session / ID: task 7173 (resume claim)
Found via: queue claim
Task: Close out task 7173: PR fix(aggregator): clear the remaining typecheck and nav-test failures (#4852) #4971 merged and post-merge main verification — complete.
Evidence: PR fix(aggregator): clear the remaining typecheck and nav-test failures (#4852) #4971 MERGED at 2026-11-03T14:48:32Z, merge commit 91c3b1938d8cba92051558b6e4b89dd6184efbd6. Post-merge main pm-aggregator run on the merge commit (run 41657353717) and the latest main run (run 41660620933, head b9e2eaf27) no longer show any of this task's typecheck/test failures — the failure set is down to exactly one test, buildHealth checkout surfacing > in-sync drift does not degrade on its own, which fails identically on the pre-merge run 41657180444 (head adfa050a8): pre-existing and unrelated to PR fix(aggregator): clear the remaining typecheck and nav-test failures (#4852) #4971. That remaining main red is tracked separately as issue main CI failure: pm-aggregator tests (run 41660620933) #4995.
Expectation: done — task 7173 completes as fixed_merged; in-flight labels removed from this issue.
Links: PR fix(aggregator): clear the remaining typecheck and nav-test failures (#4852) #4971 · issue main CI failure: pm-aggregator tests (run 41660620933) #4995 (remaining main failure)

Navigation Menu

Repository navigation

main CI failure: pm-aggregator tests (run 41616879803) #4852