Repository navigation
ci(scripts): test_program_tending.py is run by no workflow — the #1352 scaffold contracts are verified nowhere #5935
Description
Finding
scripts/tests/test_program_tending.py — the 8 contract tests for the program-tending scaffold (#1352, slice 1/3) — is run by no workflow in the repo, so the contracts it pins are verified nowhere:
.github/workflows/scripts-test.ymlenumerates exactly two files:test_update_nixpkgs_inputs.pyandtest_worker_preflight.py(lines 31–33)..github/workflows/research-workflow.ymlrunstest_*workflow*.pyandtest_plan_check.py(lines 35–37) — neither pattern matchestest_program_tending.py..github/workflows/program-tending.yml(the daily schedule for the script itself) runspython3 -I scripts/program_tending.py --run(line 47) and never its tests.- A repo-wide search for
test_program_tending/program_tendingacross.github/workflows/,flake.nix, and the justfile finds only the workflow's own run of the script — no test step anywhere (verified on laptop primary @9ddf6a8216, 2026-11-05).
This is the same gap shape as #5582 (id-native-shell in no check), in a different area: even a manual dispatch of every workflow (the house pattern since push/PR triggers were removed in 5a94833ea3) never executes these tests.
What the tests pin (and would silently lose)
Verified by running the suite on the laptop @ 9ddf6a8216: 8 tests, all pass, ~55 s.
- the run log always covers all five sections in order (
epics,roadmaps,projects,stalled-prs,loose-ends); - the scaffold is read-only:
actions_taken == 0, every sectionno-action; - the hard-stop labels (
held,user/owned,do-not-merge,do-not-auto-edit) are named in every log; - a per-repo fetch failure is reported in-section and never fails the run;
- CLI contract:
--runprints a valid log and exits 0; no--runexits 2; - the isolated-subprocess run (
python3 -I) works from a clean interpreter.
The daily workflow would still succeed if most of these regressed — it only checks that one --run invocation exits 0 — so a rename of a section, a dropped hard-stop name, or a read-only violation would ship unnoticed until a human read a run log.
Secondary observation (same fix pass)
Four of the eight tests call pt.run(...) / the CLI without mocking _gh_api, so stub_stalled_prs makes a live unauthenticated api.github.com request per invocation (plus one more in the isolated subprocess). That is why the suite takes ~55 s locally and why wiring it into CI as-is imports a network dependency (unauthenticated rate limits, 30 s urlopen timeout) into the test run. The assertions do not depend on the fetch succeeding — the stub's error path returns the same section shape — so mocking _gh_api in those four tests (the pattern test_scaffold_is_read_only and test_fetch_failure_reports_never_fails already use) makes the suite hermetic and fast.
Acceptance criteria
- Some workflow step runs
python3 -m unittest discover -s scripts/tests -p 'test_program_tending.py'(e.g. a step inscripts-test.yml, matching its existing enumeration pattern), on the Python versions that workflow already matrices. - The four unmocked tests mock
_gh_api(or an equivalent seam) so the suite passes with networking disabled and completes in seconds, not ~55 s. - The full suite still passes locally after the change: 8 tests OK.
- No change to
scripts/program_tending.pybehavior or to theprogram-tending.ymlschedule.
Evidence
- File/line evidence above, read on laptop primary
~/git/code@9ddf6a821658c8700fb78c06b024e2a1b024f754(HEAD == origin/main, clean tree). - Suite run on laptop:
python3 -m unittest discover -s scripts/tests -p 'test_program_tending.py' -v→Ran 8 tests in 54.951s — OK. - Related: Program tending: scheduled care for roadmaps, epics, projects, and stalled PRs #1352 (parent scaffold issue, open), id(ci): id-native-shell is in no check — its contract transcript tests never run in CI, check-all, or the just recipes #5582 (same gap shape for id-native-shell).
Activity
developing-today commentedon Nov 5, 2026
CODE-1609
dezren39 commentedon Nov 5, 2026
🤖 Agent note · filed
new-issue-creator-code-b)new-issue-creator-code-b, run 2026-11-04 21:20 CSTscripts/tests/test_program_tending.py(8 contract tests for the Program tending: scheduled care for roadmaps, epics, projects, and stalled PRs #1352 program-tending scaffold) is run by no workflow; verified by repo-wide workflow/nix/justfile search and a clean local suite run (8 tests OK, ~55 s) on laptop primary @ 9ddf6a8.packet-5935-triage.jsonenqueued to repo-health-code-pilot this run.dezren39 commentedon Nov 5, 2026
🤖 Agent note · filed (enqueue duplicate flag)
new-issue-creator-code-b)packet-5935-triage.json(same dedupe_keyrepo-health:v1:triage:developing-today/code:issue:5935). The second call confirmed task 9833 (queued). The first call's output tail also showed a created task, so a duplicate task with the same dedupe_key may exist — the second claimant / fleet monitor should supersede or cancel it, per the precedent on issue fleet-config: HOME unset/empty falls back to "." — config, state dir, and broker socket resolve CWD-relative, and a planted ./fleet.toml loads #5737 and issue fleet(secrets-broker): SECRETS_BROKER_TTL_S=0 makes the vault-refresh loop spin — ~110 full bws refreshes/sec, no startup validation #5860.54 remaining items
developing-today commentedon Nov 8, 2026
🤖 Agent note · handed off
developing-today commentedon Nov 8, 2026
🤖 Agent note · done
queue/9833-5935-program-tending-tests(head be95d8a), diff = exactly the two intended files (.github/workflows/program-tending.ymltest step + hermetic mocks inscripts/tests/test_program_tending.py), no Codex/review findings at all, merge-tree clean against current origin/main. Ran the suite on the laptop:python3 -m unittest discover -s scripts/tests -p 'test_program_tending.py'— 8/8 pass. Merged PR test: run program-tending contract suite #6252 (merge commit 62e722d); issue ci(scripts): test_program_tending.py is run by no workflow — the #1352 scaffold contracts are verified nowhere #5935 closed via its Fixes keyword; fresh read of origin/main confirmsprogram-tending.ymllines 46–47 now run the contract suite. Task 12857 completed as fixed_merged.developing-today commentedon Nov 8, 2026
🤖 Agent note · correction
git log origin/main). Everything else in the done note (merge, issue closure, tests, workflow lines) stands as recorded.developing-today commentedon Nov 8, 2026
Addendum to the correction note above (agent repo-worker-code-y, task 12857): the done note it corrects is comment 6719623286 on this issue — the comment ID cited in the correction (6719593192) itself came from the same mixed exec stream. The merge-commit correction stands: 62e722d.
dezren39 commentedon Nov 8, 2026
🤖 Agent note · done