Skip to content

aggregator: 7 tests fail on clean main (board-in-flight, program #1126, source-gate #1195) — fixture drift or regression verdicts owed #6245

Closed

Description

@developing-today

Summary

Seven aggregator tests fail identically on clean main and on an unrelated feature branch — pre-existing failures, verified this run (queue task 10561, 2026-11-05) by running the same files on the primary checkout at ffdd4f5d4f and on a branch worktree at the same base: the failing sets are byte-identical.

Failing tests (at main ffdd4f5d4f)

  • pm-stack/aggregator/test/board-in-flight.test.ts
    • inFlightBoardItems > builds the lane from the real 2026-10-26 section shape
    • inFlightBoardItems > removes only refs already represented on Kaneo cards
    • renderBoard in-flight lane > partially matched tasks render only their remaining GitHub links
    • titleRefs > keeps mixed shorthand and explicit refs, including GitHub URL refs
  • pm-stack/aggregator/test/program.test.ts
    • project registry > repo-fleet carries four per-repo cards and a sweep-health section (#1126)
    • renderProgramProject > detail builder splits pool and roadmap by repo for the fleet cards (#1126)
  • pm-stack/aggregator/test/source-gate-1195.test.ts
    • source gate boot behavior (#1195) > unset PM_AGG_SOURCE with PM_AGG_DEV=1 boots from fixtures (slow, ~12s, timing-shaped)

Full aggregator suite at the same commit: 1495 pass / 19 fail (the 19 includes duplicate and unnamed summary entries for the 7 above).

Why it matters

A red-on-main suite hides regressions: the #6211 fix run had to spend a verification cycle proving its own change added no failures. The board-in-flight and #1126 registry failures look like fixture/shape drift (the 2026-10-26 section shape, the repo-fleet card set); the source-gate boot failure looks timing/environment-shaped. Each needs a verdict: fix the code, fix the fixture, or retire the test with a reason.

Acceptance criteria

  • Each of the 7 named tests either passes on main or is removed/quarantined with a recorded reason.
  • Full bun test in pm-stack/aggregator is green on main, or the remaining failures are tracked by their own issues.

Found during: PR #6244 verification for #6211. Related: #2580 (different aggregator breakage, PageDef.group).

Activity

  1. added
    kind/bugSomething isn't working (prefixed form of the classic bug label)
    app/aggregatorPackage/app: aggregator (pm-stack in this repo)
    on Nov 5, 2026
  2. added
    priority/highImportant and time-sensitive
    effort/sSmall: expected under 2 hours of work
    meta/enrichedIntake review done: acceptance criteria, links, and normalized labels added
    on Nov 5, 2026
  3. dezren39 commented on Nov 5, 2026

    @dezren39
    Member

    Intake review

    • Related PRs (number search, this run): PR fix(id): state the actual surface fault in note_link refusals (#4372) #4500 (MERGED) fix(id): state the actual surface fault in note_link refusals (#4372) #4500
    • Still live: verified open this run; no merged PR found that explicitly resolves this issue, so it stays open.
    • Labels: normalized this pass (priority/high, effort/s, status/needs-triage; meta/enriched added).
    • Notes: priority/high: tests failing on clean main block every aggregator change.
    • Risks: Risk: failures may share one root cause in the board-in-flight / source-gate work; fixing tests without finding it would paper over a real regression.
    • Suggested approach: Approach: reproduce on clean main, bisect to the introducing change, fix the root cause in the aggregator, not the assertions.

    🤖 Agent note · filed

    • Agent: fleet monitor
    • Session / ID: repo-fleet-monitor run 2026-11-05T15:33:58Z
    • Found via: monitor reconciliation (Duty 2 intake enrichment)
    • Task: Intake pass per protocol §5: verified live, acceptance criteria already present, labels normalized, related PRs linked above.
  4. added
    queue/queuedHas a queued task in the Supabase agent queue
    task/triageQueue packet kind: verify, reproduce, and route this item
    queue/claimedQueue worker lifecycle state
    work/assignedQueue worker lifecycle state
    and removed
    queue/queuedHas a queued task in the Supabase agent queue
    on Nov 6, 2026
  5. dezren39 commented on Nov 6, 2026

    @dezren39
    Member

    🤖 Agent note · handed off

  6. 17 remaining items

  7. dezren39 commented on Nov 6, 2026

    @dezren39
    Member

    🤖 Agent note · handed off

  8. dezren39 commented on Nov 6, 2026

    @dezren39
    Member

    🤖 Agent note · handed off

  9. added
    queue/queuedHas a queued task in the Supabase agent queue
    queue/claimedQueue worker lifecycle state
    and removed
    queue/parkedQueue task is parked (waiting on CI, time, or an event)
    status/parkedDeliberately paused with a recorded resume condition
    queue/queuedHas a queued task in the Supabase agent queue
    on Nov 7, 2026
  10. dezren39 commented on Nov 8, 2026

    @dezren39
    Member

    🤖 Agent note · picked up

  11. dezren39 commented on Nov 8, 2026

    @dezren39
    Member

    🤖 Agent note · done

    • Agent: queue worker (repo-worker-code), OpenChamber scheduled lane
    • Session / ID: task 11124; lane 8ac61616-3815-4e7b-b33d-840a3829154a
    • Found via: queue claim
    • Task: Re-triage the seven reported aggregator failures against current main.
    • Result: no longer reproducible. At current main ab35bef, the three named test files pass (36 tests, 339 assertions) with PM_AGG_FRESHNESS_PORT=24871; all six board-in-flight/program tests pass, and the source-gate test passes when isolated from the pre-existing local listener on port 4871. The full suite passes after installing the declared locked dependencies with bun install v1.4.4 (38afee6c8): 1810 pass, 0 fail across 137 files. No source changes were made. The initial full-suite run before dependency installation was not a valid code verdict (web-push was absent from the isolated worktree).
    • Links: issue aggregator: 7 tests fail on clean main (board-in-flight, program #1126, source-gate #1195) — fixture drift or regression verdicts owed #6245; current main ab35bef; worktree /home/user/git/fleet/11124
  12. dezren39 commented on Nov 8, 2026

    @dezren39
    Member

    Update (2026-11-08T01:16:28Z): origin/main advanced to 08dd577 during this run; I fast-forwarded the task worktree and reran the named test files there. All 36 targeted tests / 339 assertions still pass with PM_AGG_FRESHNESS_PORT=24871. A subsequent full-suite run at 08dd577 reported 1809 pass and one unrelated failure in test/events.test.ts (#1739), the cursor snapshot-ordering test; issue #1739 is CLOSED. This does not change the #6245 finding: none of its seven named failures reproduce on current main. The earlier full-suite pass (1810/1810) was at ab35bef. No changes to the #6245 test/code paths were made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    app/aggregatorPackage/app: aggregator (pm-stack in this repo)effort/sSmall: expected under 2 hours of workkind/bugSomething isn't working (prefixed form of the classic bug label)meta/enrichedIntake review done: acceptance criteria, links, and normalized labels addedpriority/highImportant and time-sensitivetask/triageQueue packet kind: verify, reproduce, and route this item

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions