UI refresh: a modern light and dark theme #2114
Description
Known issues
First version has been submitted. Here the list of already known issues we will work on.
- Headers do not react to hovering events anymore. Add hover indicator. ( Dark, Light -> Win, Mac)
--> Adding hover indicator for unselected tabs #2130 - “Git Staging” view does not have a grey background. This makes the grey buttons standout. Background should be grey. (Light -> Win, Mac)
--> Fix for 'Git Staging' view background #2168 - "Types" view does not have a grey background
--> Fix for background color of some views like Types, Console etc #2153.
--> Revert in Reverting the bg color for StyledText, Button, Table controls #2181 - Editor line number strip should have the same color as the editor background. (Dark -> Win, Mac)
--> [Dark Theme]Fix for background color of gutter line in editor #2744 - Editor line number strip should have the same color as the editor background. (Light -> Win, Mac)
--> Light (Preview) theme: Change to bg color of vertical bar in editor #2314 - Provide same themes for Linux (Dark, Light)
--> Improvement to Light and Dark theme for Linux #2137 - Issue in breadcrumb
--> Removing unnecessary themeing extension for breadcrumb (light theme) eclipse-jdt/eclipse.jdt.ui#1577 - Missing alternate row colors in tables on macOS Recent changes to UI Themes have broken Table rendering on Mac #2171)
- Missing alternate row colors in trees on macOS [MAC] - Light(Preview) theme - Fix for missing alternate row colors for Tree #2404
- Editor Tabs looks greyed out --> Light (Preview) Font color change for text in tabs #2294
- Multiple Tabs have blue highlight --> Light (Preview) theme - change in the behavior of highlights for selected tabs #2286
- [Labels in Progress View have wrong background](https://github.com/eclipse- noplatform/eclipse.platform.ui/issues/2313) Not reproducible any more.
- Move changes to "Light (Preview)" to "Light" theme and delete "Light (Preview)" theme. --> Move "Light (Preview)" Theme to the "Light" Theme #2549
- Fix bread crumb for light theme --> [Light Theme]Fix for background color of bread-crumb in debug view eclipse.platform#1704
- Fix bread crumb for dark theme --> [Dark Theme]Fix for background color of bread crumbs in Debug view eclipse.platform#1706
Status quo
A lot of Eclipse users are asking for a more modern look&feel. If you search the internet you will find a lot of such posts.
https://www.reddit.com/r/eclipse/comments/i4hlpw/make_eclipse_look_modern/
https://www.reddit.com/r/eclipse/comments/jvfyv8/will_eclipse_get_amajor_ui_upgrade_to_look_modern/
...
There is quite some progress in this area with simplified tab view options (available), sticky scrolling (in progress), modernized find integration (in progress) and many other small and bigger fixes which are currently being worked on in the Eclipse community.
This issue focuses on the default themes. The default light theme has not been updated in years. It is not state of the art anymore. All major IDEs have shifted to a different light theme style. Here is an overview how the other most commonly used IDEs look like out of the box.
VS Code
IntelliJ
Visual Studio
XCode
What design styles follows a theme in 2024?
When comparing the different IDEs it is easy to pick out the design decisions they all share. These are:
- Lightweight view tab design.
- Flat look. No use of 3D gradiants.
- Views use a darker background color. This naturally focuses the eye on the editor area which is where most of the work happens. We like to call editors the main actors and views the supporting actors.
Especially, point 3) is important. When looking at other UIs outside the IDE space it becomes clear that this is the standard. The navigation sidebar is usually using a darker background color than the main content area (e.g. MacOS finder, Apple Music, Powerpoint, OneNote, MacOS notes, MS teams, ...). That's probably the biggest reason why Eclipse feels so outdated.
Proposal for the updated default light theme
The updated theme addresses all three points mentioned above. Here are some before/after screenshots.
Current theme:
Modernized theme:
Details
Views tabs. Same minimalist design you can find in the other IDEs.
Editor tabs. Same design as in the other IDEs. The active tab has a white background which blends in nicely with the white background of the editor area.
Proposal for the updated dark theme
The updated theme follows in the footsteps of the light theme. From a design perspective it simply inverts the colors. This means the most important part is the darkest and the less important parts are brighter. When working on the dark theme we noticed that it was already in a much better shape. Our proposal simply cleans up same aspects of the current design.
Here is a screenshot of the IntelliJ dark theme as a reference.
Current theme:
Modernized theme:
Summary
We have been working hard on these proposals and were pleasantly surprised how good Eclipse can look like with the updated themes. Our in house developers have been using them already for months and do not want to go back to the old ones. While we tested them extensively there is still a chance that we missed some small details. Please report any issues you find and we will look into them. We decided to split the changes into three changes for easier review:
- One for the light theme: Improvement to the existing Light Theme #2103
- One for the dark theme: Improvement to the existing dark theme #2112
- One to adjust the thickness of the highlight underline of active tabs. We propose to reduce it by one pixel: Height reduction of highlight #2111
At the Eclipse Community Day we asked whether to immediately replace the existing themes or add them as new ones. All committers (@merks , @HeikoKlare , @marcushoepfner , @BeckerWdf , @HannesWell , @sratz , @fedejeanne ) we talked to asked us to replace the existing themes. We can always rollback the changes if there are issues.
As a final note, we focused on Windows and Mac first. This is already a lot of work. If these changes get accepted we will also look into applying the visual refresh to the Linux themes.
Activity
Wittmaxi commentedon Jul 19, 2024
I love this change! Having see the difference it can make, I can not wait for this to be in my IDE. Thank you!!!
I might be alone with this opinion, but to me the new theme looks almost unchanged and I feel like a bigger contrast might look even better. From your presentation I know that you copied the values of VScode but to me, the light theme looks nearly unchanged. Have you experimented with "greater contrasts" already?
laeubi commentedon Jul 19, 2024
It might be my glasses but with the "modern" style I can hardly read Main class + method names ... and even if it says "Please ignore the incorrect syntax highlighting. It does not occur with the change." I wonder, why not make a screenshot with correct syntax highlight?
HeikoKlare commentedon Jul 19, 2024
I really like and appreciate these changes and consider them a great improvement in terms of look&feel 👍 I hope that we can find an agreement soon and have them available as soon as possible.
I have two concerns so far:
thomasritter commentedon Jul 19, 2024
@laeubi Your comment applies to #2112, correct? Sorry, for that one. Matthias Becker told us that the syntax highlighting colors are linked to a theme ID and if you change the ID they break. This is what you can see in the screenshot because we duplicated the theme while working on it. Now, with #2112 we thought it would not be a problem because we change the existing theme and no ID breakage should happen. But it turns out that we were wrong and somehow the editor is picking the light theme syntax colors and not the one for the dark theme. We are investigating this, right now. Of course, in this state the change for the dark theme cannot be submitted.
thomasritter commentedon Jul 19, 2024
I updated the screenshot of the new dark theme. It features the correct syntax highlighting, now.
HeikoKlare commentedon Jul 19, 2024
Thank you! The screenshot shows the new dark theme also with a changed font color theme. I don't see that as part of the current dark theme improvement PR. Will you provide it later on? When I test the PR, I still have the existing "christmas tree" font colors in dark theme, so I would really appreciate an update of them as well 🙂
vogella commentedon Jul 20, 2024
I also like the changes, tested under Windows. They are not ground-breaking but do the little twists to make the theme look more professional.
In my opinion our styling also suffers from:
None of the above is related to this change but I wanted to mention it, now that more people work on the theming.
I merge the changes so that we can polish these changes with the help of more eyes (and also to get the promised Linux change cc @thomasritter)
For reference on my styling background I introduced the dark theme in Eclipse and updated the Windows theme to be less Win95 (removed the gradients) among other changes in the CSS. I also introduced the pseudo-class support for preference styling to help @BeckerWdf with his initial dark theme of the ABAP tooling.
humphreygao commentedon Jul 20, 2024
make sash width = 0? see https://bugs.eclipse.org/bugs/show_bug.cgi?id=562536
vogella commentedon Jul 20, 2024
#2112 and #2103 merged
vogella commentedon Jul 20, 2024
Can you test and create before and after screenshot with new Eclipse? Your closing X for the view proves that you are using a super old version. IIRC the sash zero did not make a difference in past.
vogella commentedon Jul 20, 2024
cc @PyvesB
PyvesB commentedon Jul 20, 2024
You'll need to pull and rebase my proposed change to do so: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/170913
HannesWell commentedon Jul 21, 2024
Thank you @thomasritter for this enhancements, in general I like it. I tried tonight's I-build on my Windows computer and found the following cases that don't look nice after the update:
In both cases it looks like the background of 'flat' buttons (haven't checked what they are exactly) don't fits to the overall background color anymore. Maybe this is because some assumptions about the background were made that are not true anymore or maybe something is missing in the updated theming. I also noticed that the Commit-Header in the History view (green box) is now in a light gray, while before it was the same white as the git-diff shown below (in my screenshot that part is empty since no file is selected for a better contrast). But with files being selected and after one gets used to it, that looks actually fine.
Wittmaxi commentedon Jul 22, 2024
As a small nitpick: the gutter line should be completely dark and not have this lighter border to the left of the numbers (or at least, there should be more padding to the left of the numbers, which is probably a bigger change)
Great job guys, I really enjoy this new dark mode!!! :)
58 remaining items
danthe1st commentedon Oct 4, 2024
It seems like these changes have been reverted in #2206 and according to the commit message, it seems like they might come back in 2024-12.
PyvesB commentedon Oct 4, 2024
I wouldn't say "failed", there is a functional patch with no known defects available, and the performance concern was never validated in practice. If someone was up for it, they could rebase it and tie the revised code only to the new preview theme. This would allow to gather more evidence on any hypothetical performance issues or defects, without imposing risks on all users.
HannesWell commentedon Oct 4, 2024
Yes that's fixed now.
On first sight I just wondered if the breadcrumb should have a different background color than the editor, but actually it's clear that it's not part of the text to edit, so it also fine. Thank you for fixing that
Exactly. We had the impression it was not yet fully ready for prime-time for the September release. But the plan is to have it ready for the December release. See also #2114 (comment).
rico-ding commentedon Nov 13, 2024
Let's hope, that flat design is not outdated soon. The current flat design "period" somehow started 2012 with Windows 8 and Android 4 and now it looks like Microsoft is planning to introduce something called "fluent design": https://microsoft.design/articles/embracing-vibrant-universality-in-fluent-illustrations/
HannesWell commentedon Nov 14, 2024
Thanks for the heads-up, that's interesting. But I have the impression that this looks somehow similar to the 3D icons from 20years ago, just in higher resolution and with more details. Probably fashion just repeats itself even in IT.
Move "Light (Preview)" Theme to the "Light" Theme
Move "Light (Preview)" Theme to the "Light" Theme
Move "Light (Preview)" Theme to the "Light" Theme
Move "Light (Preview)" Theme to the "Light" Theme
vogella commentedon Dec 10, 2024
@mvm-sap @thomasritter @BeckerWdf can you add the final merge of the dark theme and light theme to the N&N 4.35? https://github.com/eclipse-platform/www.eclipse.org-eclipse
lathapatil commentedon Apr 10, 2025
I see VS Code have 0 sash width
and highlights on hover
nlisker commentedon Apr 18, 2025
See the comment above: #2114 (comment), and the extracted issue #2590.
BeckerWdf commentedon Jun 18, 2025
I consider this as fixed. So closing this umbrella issue.