Skip to content

Editor Tabs looks greyed out #2182

Closed
Closed

Description

@jukzi

in the past month the File names in the editor changed from black to grey or the used font got thinner then a pixel. Was that intentional? looks less readable
now (I20240811-1800):
image
before (I20240710-1800):
image

Sadly the screenshots are not so good to see the difference due to subpixel rendering. But it was basically the first thing that fleshed my eyes after having not used eclipse for a month.

Activity

  1. jukzi commented on Aug 12, 2024

    @jukzi
    ContributorAuthor

    image

  2. jukzi commented on Aug 12, 2024

    @jukzi
    ContributorAuthor

    old black was 0,0,0. new color is 59,59,59
    image

  3. iloveeclipse commented on Aug 12, 2024

    @iloveeclipse
    Member

    See #2114

  4. Phillipus commented on Aug 12, 2024

    @Phillipus
    Contributor

    Agreed, the text color looks a bit pale now.

  5. BeckerWdf commented on Aug 13, 2024

    @BeckerWdf
    Member

    @mvm-sap: Was this change by intention? If yes: Why. If not: Can we get the old color with the better contrast back?

  6. mvm-sap commented on Aug 13, 2024

    @mvm-sap
    Contributor

    @mvm-sap: Was this change by intention? If yes: Why. If not: Can we get the old color with the better contrast back?

    Yes, we followed VS Code tab font color codes.
    In editor
    selected tab : #3b3b3b
    unselected tab : #6a6a6a
    In Views
    Both Selected and Unselected tabs : #3b3b3b

    If this does not look good, may be I can try to change

  7. BeckerWdf commented on Aug 13, 2024

    @BeckerWdf
    Member

    @mvm-sap: Was this change by intention? If yes: Why. If not: Can we get the old color with the better contrast back?

    Yes, we followed VS Code tab font color codes. In editor selected tab : #3b3b3b unselected tab : #6a6a6a In Views Both Selected and Unselected tabs : #3b3b3b

    If this does not look good, may be I can try to change

    I really can agree that the contrast of text and background was better in the past. And good contrast is a good think.
    Was the color different for selected and unselect tabs before your change?

  8. mvm-sap commented on Aug 13, 2024

    @mvm-sap
    Contributor

    @mvm-sap: Was this change by intention? If yes: Why. If not: Can we get the old color with the better contrast back?

    Yes, we followed VS Code tab font color codes. In editor selected tab : #3b3b3b unselected tab : #6a6a6a In Views Both Selected and Unselected tabs : #3b3b3b
    If this does not look good, may be I can try to change

    I really can agree that the contrast of text and background was better in the past. And good contrast is a good think. Was the color different for selected and unselect tabs before your change?

    yes, it was #000000 for both selected and unselected tab

  9. BeckerWdf commented on Aug 13, 2024

    @BeckerWdf
    Member

    What about bringing #000000 back for the selected tabs and maybe have #3b3b3b for the unselected tabs?
    What do you think?

  10. mvm-sap commented on Aug 13, 2024

    @mvm-sap
    Contributor

    What about bringing #000000 back for the selected tabs and maybe have #3b3b3b for the unselected tabs? What do you think?

    Both in view and editor ?

  11. BeckerWdf commented on Aug 13, 2024

    @BeckerWdf
    Member

    What about bringing #000000 back for the selected tabs and maybe have #3b3b3b for the unselected tabs? What do you think?

    Both in view and editor ?

    I would say yes.

  12. jukzi commented on Aug 13, 2024

    @jukzi
    ContributorAuthor

    What about bringing #000000 back for the selected tabs and maybe have #3b3b3b for the unselected tabs?

    Worth a try. But my guess that full contrast is still best for both. The active tab is already emphasized with that blue bar.
    image

    In general an UI should have high contrast on the active part and lower contrast on the dysfunctional surrounding to focus the reader on the important things. However the eclipse IDE does not follow that design principle. As long as the surrounding views still have high contrast lowering the contrast of the tabs only makes them harder to read without making the user focus on the editor content.
    Reducing contrast does only make sense if it is done consistently to serve the purpose of focus.

  13. BeckerWdf commented on Sep 18, 2024

    @BeckerWdf
    Member

    This is addressed it in: #2294

  14. BeckerWdf commented on Sep 23, 2024

    @BeckerWdf
    Member

    I think this is fixed (see above). Pls. reopen if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    WindowsHappens on Windows OSbugSomething isn't workingregression

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions