You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 18, 2021. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 18, 2021. It is now read-only.
Auto-magically & retroactively have posts that are only ±1, &c, converted to reactions & hidden/deleted #640
To fix issues like #18 recently not loading because of death by 1300 (❕:bangbang:❗) 👍s (& then having to be refiled in #604 to work-around), GitHub should now automatically & retroactively find all posts everywhere that consist solely of +1 (👍, +100, 💯, +∞, {?}, multi-/mega-👍s, & related should count, too — bonus points for "me, too" & equivalents), -1 (& related), &/or all other supplied reactions, convert them to reactions on the top/previous non-reaction-only post (repo owner's choice), & then hide/delete from view or thread outright. (Also, if any, reactions on said extraneous posts should be outright ignored!) It'd instantly solve such subscription-spamming (does anyone sane need e-mail notification on these posts?!), as well.
Reacted by Adam Spiers, Даниил Пронин, Ernest Gu, Kirk Beard, Asteria Hoffmeyer, Stéphane Lavergne, Henry Bley-Vroman, Edric Chan, Sybille, Azar and 1 more
Reacted by Даниил Пронин, Ernest Gu, Asteria Hoffmeyer, Tom Kenny, Boboss74, Tom Scholz, Edric Chan and Eddie Carswell
Reacted by TPS, Kubis Fowler, Adam Spiers and Sybille
converting existing +1 into reactions (what this issue is about)
preventing new +1 - either by introducing some UI change to nudge users to use reactions instead, or by not permitting posts containing exactly +1 at all.
Reacted by Stéphane Lavergne, Sheece Gardezi, Patrick Galbraith and Sybille
@The-Compiler I suppose 1 could split this into 2 (i.e., pt.1="retroactively" & pt.2="auto-magically"), but neither part is particularly satisfactory on its own, & I think the same backend implementation could handle both more easily than just 1-or-the-other.
@TPS, as you can see, there are people who intentionally use comments instead of reactions. They have their reasons. So I believe that if GitHub starts to convert these comments into reactions, they will start write such comments that would not fit the GitHub's regexp since their goal is to post a comment (and to express support), not just to express support. So, my question was more about those emails that are intended to work around this issue regardless of their content…
I'll reply here as not to spam #283: Practically, such non-content support 👍s are spam on the channel for everyone else who's subscribed (so is inherently selfish), & causes other problems as detailed above. I'd rather have those folks put the effort into a useful response/comment, xor just minimally react, not the degenerate-hybrid spam. Besides, all this conversion is to be @ the repo admins' discretion, as mentioned above.
Reacted by TPS, Kirk Beard, Frizi, Tom Kenny, Maaartinus, Eddie Carswell and Sybille
Thanks for getting in touch! It isn't possible to convert emoji comments to reactions at this time. We've added your idea and rationale to our internal Feature Request List so the team can see it. It might be something we support in the future, but we can't promise when it will happen.
From looking at the reactions API, you can create a reaction, but it will only be your reaction; there is no way that I can see to add more than one thumbs up to the top issue. Also, you would need to have authorization to edit or delete "+1" comments from the thread.
I really wish there was some way to add a webhook or service integration where when someone only posts a "+1" or equivalent, it automatically adds it as a reaction to the OP in their name and deletes the comment. It wouldn't solve this issue of converting retroactive "+1s", but it may stop people from their current bad habits.
I didn't mean as an actual implementation of the whole functionality, but merely what 1 sees: Something like (on top post) "862 👍s removed & should be added here" or some such, but less tacky wording. 😜
The GitHub issue comments userscript will hide "+1" comments - it also hides stuff like "+1!!!", "++1", "+9999", "+1 please", ":+1:" (including a wall of +1's), ":100:", etc. It won't hide the comment if there is more text than that.
I just updated the userscript to include a count of how many comments were hidden. So, it won't count comments that have a "+1" with an explanation...
In #215, the userscript initially hides 112 comments, but after you click "view more" - and check & uncheck the "Hide +1s" option (I still need to fix this) - it shows that a total of 197 comments are hidden.
This is probably the best I can offer at this time .
Reacted by TPS, Stéphane Lavergne, Adam Spiers and Christopher Gadd
@TPS, the permission is used to edit/delete comments. GitHub Apps cannot submit reactions, that is reserved to OAuth Apps, though those need to be installed individually by the user.
There is no clear way to solve this ourselves at the org level, short of creating a fake reaction bar at the bottom of the issue body that imitates the real one and increments reaction counts there. That would still be a muddy solution, because you cannot guess the intentions of the user, did they react to a recent comment with a +1, or are they agreeing with the goals of the entire issue? You would see otherwise misguided issues that received a reasonable comment along the way appear to have the support of the community.
A sensible approach would be to educate users, show a warning about the consequences of a +1 comment when they are about to submit the post, and suggest the use of reactions instead. I agree this could be implemented globally by GitHub.
I know that this solution doesn't absolutely address the title above – so I don't expect it to close this issue out – but I hope that it goes some way to help 🧡.
I'd love to know your feedback. How can we iterate to make this better? For the slightly different problem of stopping people from posting "just +1" posts in the first place – we're currently investigating what we can do there too!
Reacted by Andrey Nering, Stéphane Lavergne, TPS, Marcel MFS and Sybille
Reacted by Adam Spiers, Stéphane Lavergne, Marcel MFS and Eddie Carswell
@lukehefson Thanks very much for your attention! 🙇 This is indeed a very welcome stopgap toward implementing my (😜) issue, & it works beautifully. A couple RFC/Es:
Could it work across duplicates that aren't consecutive?
Could / does it work to suppress the e-mail/notifications of such comments?
To provide another perspective, in other cases it is a good thing that email notification is always sent. For example, if you have a GitHub
integration that sends some kind of automated message by posting a comment
on the pull request, then it's good that the emails are sent on each message.
Of course, this doesn't reduce the email spam for the +1s.
changed the title [-]Auto-magically & retroactively have posts that are only ±1, &c, converted to reactions & deleted[/-][+]Auto-magically & retroactively have posts that are only ±1, &c, converted to reactions & hidden/deleted[/+]on Mar 2, 2019
Activity
TPS commentedon Apr 8, 2016
👍❤️
TPS commentedon Apr 8, 2016
If this is ever implemented, the intermediate post should evaporate & convert to reactions on original post. 😜
TPS commentedon Apr 8, 2016
Response from GitHub:
TPS commentedon Apr 9, 2016
@sergei-ivanov I'm honored by your support! 🙇
TPS commentedon Apr 20, 2016
Another issue that would benefit enormously from this is #215! 😵
The-Compiler commentedon Apr 22, 2016
I think there are two different issues:
+1at all.TPS commentedon Apr 22, 2016
@The-Compiler I suppose 1 could split this into 2 (i.e., pt.1="retroactively" & pt.2="auto-magically"), but neither part is particularly satisfactory on its own, & I think the same backend implementation could handle both more easily than just 1-or-the-other.
TPS commentedon Apr 22, 2016
From @radek-holy:
I'll reply here as not to spam #283: Practically, such non-content support 👍s are spam on the channel for everyone else who's subscribed (so is inherently selfish), & causes other problems as detailed above. I'd rather have those folks put the effort into a useful response/comment,
xorjust minimally react, not the degenerate-hybrid spam. Besides, all this conversion is to be @ the repo admins' discretion, as mentioned above.Kubo2 commentedon Apr 26, 2016
Response from GitHub:
TPS commentedon May 22, 2016
Hey, @Mottie, if you want a really good challenge, userscript this! 🙇
Mottie commentedon May 22, 2016
From looking at the reactions API, you can create a reaction, but it will only be your reaction; there is no way that I can see to add more than one thumbs up to the top issue. Also, you would need to have authorization to edit or delete "+1" comments from the thread.
I really wish there was some way to add a webhook or service integration where when someone only posts a "+1" or equivalent, it automatically adds it as a reaction to the OP in their name and deletes the comment. It wouldn't solve this issue of converting retroactive "+1s", but it may stop people from their current bad habits.
TPS commentedon May 22, 2016
I didn't mean as an actual implementation of the whole functionality, but merely what 1 sees: Something like (on top post) "862 👍s removed & should be added here" or some such, but less tacky wording. 😜
Mottie commentedon May 22, 2016
The GitHub issue comments userscript will hide "+1" comments - it also hides stuff like "+1!!!", "++1", "+9999", "+1 please", ":+1:" (including a wall of +1's), ":100:", etc. It won't hide the comment if there is more text than that.
I just updated the userscript to include a count of how many comments were hidden. So, it won't count comments that have a "+1" with an explanation...
In #215, the userscript initially hides 112 comments, but after you click "view more" - and check & uncheck the "Hide +1s" option (I still need to fix this) - it shows that a total of 197 comments are hidden.
This is probably the best I can offer at this time
.
27 remaining items
dessant commentedon Jun 30, 2018
@TPS, the permission is used to edit/delete comments. GitHub Apps cannot submit reactions, that is reserved to OAuth Apps, though those need to be installed individually by the user.
There is no clear way to solve this ourselves at the org level, short of creating a fake reaction bar at the bottom of the issue body that imitates the real one and increments reaction counts there. That would still be a muddy solution, because you cannot guess the intentions of the user, did they react to a recent comment with a +1, or are they agreeing with the goals of the entire issue? You would see otherwise misguided issues that received a reasonable comment along the way appear to have the support of the community.
A sensible approach would be to educate users, show a warning about the consequences of a +1 comment when they are about to submit the post, and suggest the use of reactions instead. I agree this could be implemented globally by GitHub.
yakov116 commentedon Sep 17, 2018
refined-github/refined-github#1526 was somewhat implemented here
lukehefson commentedon Sep 26, 2018
Hello all! I'm a PM at GitHub and I just wanted to leave a note here to say that we shipped something that should hopefully help with this: https://blog.github.com/changelog/2018-09-24-hiding-repeat-comments/
I know that this solution doesn't absolutely address the title above – so I don't expect it to close this issue out – but I hope that it goes some way to help 🧡.
I'd love to know your feedback. How can we iterate to make this better? For the slightly different problem of stopping people from posting "just +1" posts in the first place – we're currently investigating what we can do there too!
TPS commentedon Sep 26, 2018
@lukehefson Thanks very much for your attention! 🙇 This is indeed a very welcome stopgap toward implementing my (😜) issue, & it works beautifully. A couple RFC/Es:
/ doesit work to suppress the e-mail/notifications of such comments?OT: I created a PushBullet channel @ https://www.pushbullet.com/channel?tag=githubchangelog to (try to) keep track of all the great work y'all're doing. ☺
marcelmfs commentedon Sep 26, 2018
TPS commentedon Sep 26, 2018
@JayFoxRox, @kenorb, @Arzte: I noticed that y'all expressed some concerns (via reactions on OP, above), but haven't otherwise detailed via comments. I'd like to explicitly invite y'all to do so, especially since we've @github's 👀 via @lukehefson!
@marcelmfs C'mon, again? Haven't we been through this already⁉️ 😝
kenorb commentedon Sep 26, 2018
Some new feature has been implemented, by grouping multiple "+1" posts, but I can't find the article about it.
kenorb commentedon Sep 26, 2018
kenorb commentedon Sep 26, 2018
agos commentedon Sep 26, 2018
@TPS thanks to this thread I can confirm that it does not suppress email notifications 😞
mspiegel commentedon Sep 26, 2018
[-]Auto-magically & retroactively have posts that are only ±1, &c, converted to reactions & deleted[/-][+]Auto-magically & retroactively have posts that are only ±1, &c, converted to reactions & hidden/deleted[/+]