Skip to content

feat: make encode/decode support store-based session - #100

Closed
Runrioter wants to merge 3 commits into
koajs:masterfrom
Runrioter:master
Closed

feat: make encode/decode support store-based session#100
Runrioter wants to merge 3 commits into
koajs:masterfrom
Runrioter:master

Conversation

@Runrioter

Copy link
Copy Markdown
Contributor

@coveralls

coveralls commented Sep 19, 2017

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling d248017 on Runrioter:master into c040b59 on koajs:master.

@Runrioter

Copy link
Copy Markdown
Contributor Author

@dead-horse hi, do you have any time to review this PR. This feature is necessary for me. 😃

@Runrioter Runrioter mentioned this pull request Sep 20, 2017
@popomore

Copy link
Copy Markdown
Member

@Runrioter

Runrioter commented Sep 20, 2017

Copy link
Copy Markdown
Contributor Author

@popomore Yay I did. But sometimes the externalKey from cookie is not a key for a session, and we should encode(encrypt)/decode(decrypt) it.

Did you mean that I can wrap the encode/decode in external store get and set?
If I do that:

  • I have to make a new repository like koajs/koa-redis instead of reusing it.
  • The created external store just is used for session fetching and I have to wrap another layer for other user cases.
  • It would not be the same as cookie-based session that has encode/decode func in this repo

Your opinion?

@Runrioter Runrioter closed this Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants