feat: support options.externalKey - #88
Closed
vicanso wants to merge 2 commits into
Closed
Conversation
1 similar comment
1 similar comment
|
Is there any reason this feature hasn't landed? It's the main thing preventing me from switching from |
Member
|
sorry for the delay, I'd like to have the signature of opts.externalKey = {
get(ctx) { return externalKey; },
set(ctx, value) { },
}@vicanso do you have time to modify this PR? |
vicanso
added a commit
to vicanso/session-1
that referenced
this pull request
Oct 28, 2018
Contributor
Author
|
@dead-horse I have deleted the repo, and pulled a new request #149 . Please review it, thanks. |
dead-horse
pushed a commit
that referenced
this pull request
Oct 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to get the external key by another way, such as http header, query string etc.