Skip to content

feat: support options.externalKey - #88

Closed
vicanso wants to merge 2 commits into
koajs:masterfrom
vicanso:master
Closed

feat: support options.externalKey#88
vicanso wants to merge 2 commits into
koajs:masterfrom
vicanso:master

Conversation

@vicanso

@vicanso vicanso commented Jul 8, 2017

Copy link
Copy Markdown
Contributor

I want to get the external key by another way, such as http header, query string etc.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 0c2c594 on vicanso:master into fd8acf2 on koajs:master.

1 similar comment
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 0c2c594 on vicanso:master into fd8acf2 on koajs:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 16c1217 on vicanso:master into fd8acf2 on koajs:master.

1 similar comment
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 16c1217 on vicanso:master into fd8acf2 on koajs:master.

@kherock

kherock commented Oct 17, 2018

Copy link
Copy Markdown

Is there any reason this feature hasn't landed? It's the main thing preventing me from switching from koa-generic-session. I need a bit more control over exactly what info is stored in the session cookie.

@dead-horse

Copy link
Copy Markdown
Member

sorry for the delay, I'd like to have the signature of opt.externalKey like:

opts.externalKey = {
  get(ctx) { return externalKey; },
  set(ctx, value) { },
}

@vicanso do you have time to modify this PR?

vicanso added a commit to vicanso/session-1 that referenced this pull request Oct 28, 2018
@vicanso

vicanso commented Oct 28, 2018

Copy link
Copy Markdown
Contributor Author

@dead-horse I have deleted the repo, and pulled a new request #149 . Please review it, thanks.

@vicanso vicanso closed this Oct 28, 2018
dead-horse pushed a commit that referenced this pull request Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants