Support ctx.respond = false - #95
Closed
nordsimon wants to merge 1 commit into
Closed
Conversation
Author
|
Closing this in favor of supporting it more widely in koa |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. First of all, thanks for koa. We did a very successful refactor from express to koa and our codebase is much slimmer, faster and easier to read.
Anyway, we have a very specific cache solution where we actually need to use the ctx.respond = false. I know it's unsupported and I understand why but we still want to use it in a very specific situation. I've managed to call the commit() command by getting the symbol from context but it tries another commit later in the codebase and there it emits an "Can't set headers after they are sent"
My solution to this would be to check for headerSent in commit to avoid this.
I know i'm in deep blue with features that are unsupported but this is the best way i could think of