Skip to content

Support ctx.respond = false #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nordsimon wants to merge 1 commit into from
Closed

Support ctx.respond = false #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/context.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,11 @@ class ContextSession {
const opts = this.opts;
const ctx = this.ctx;

if (ctx.headerSent) {
debug('skipping commit due to ctx.headersSent');
return;
}

// not accessed
if (undefined === session) return;

Expand Down
26 changes: 26 additions & 0 deletions test/contextstore.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,6 +606,32 @@ describe('Koa Session External Context Store', () => {
});
});

describe('when headers are sent', () => {
it('should not commit', done => {
const app = App();
let appError;
app.on('error', err => {
appError = err;
});

app.use(async function(ctx) {
ctx.respond = false;
ctx.response.status = 200;
ctx.session.makeChange = true;

ctx.response.flushHeaders();
ctx.res.end();
});

request(app.listen())
.get('/')
.expect(200, err => {
done(err || appError);
});
});
});


describe('ctx.session', () => {
after(mm.restore);

Expand Down