feat: (azure-cost) add storage optimization guide and fix token limit - #2554
Merged
Jon Gallant (jongio) merged 5 commits intoJun 3, 2026
Merged
Conversation
- Add services/storage/azure-storage.md with optimization rules, lifecycle policy templates, Resource Graph queries, and pricing reference - Add references/tools-and-best-practices.md (extracted from SKILL.md) - Slim SKILL.md from ~2100 to ~490 tokens (fixes microsoft#2157) - Add Step 1.7 Storage routing in optimization workflow - Add 4 vally eval stimuli (3 routing + 1 response quality) Closes microsoft#2524 (partial: storage service guide)
Jon Gallant (jongio)
requested review from
Rick Winter (RickWinter) and
Sai Koumudi Kaluvakolanu (saikoumudi)
as code owners
June 3, 2026 17:39
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Azure Storage cost-optimization coverage to the azure-cost skill while reducing the skill’s frontmatter/markdown token footprint by moving supporting guidance into reference docs. It also expands the azure-cost Vally suite with new storage-focused routing and response-quality stimuli.
Changes:
- Added a new Storage cost optimization reference guide (tiering, lifecycle policies, ARG queries, pricing notes).
- Slimmed
azure-costSKILL.md and extracted tooling/best-practices content into a dedicated reference file. - Added new storage routing + response-quality stimuli to
evals/azure-cost/eval.yaml, plus lockfile updates.
Show a summary per file
| File | Description |
|---|---|
plugin/skills/azure-cost/SKILL.md |
Shortened description and condensed the top-level skill content; added links to storage optimization and extracted references. |
plugin/skills/azure-cost/references/tools-and-best-practices.md |
New extracted reference for MCP tools, best practices, pitfalls, and safety requirements. |
plugin/skills/azure-cost/cost-optimization/workflow.md |
Added Storage-specific conditional step before AKS analysis and renumbered subsequent steps. |
plugin/skills/azure-cost/cost-optimization/services/storage/azure-storage.md |
New storage optimization guide (rules, lifecycle templates, ARG queries, commands, pricing notes). |
evals/azure-cost/eval.yaml |
Added storage-focused routing and response-quality integration stimuli. |
package-lock.json |
Lockfile update (peer markers added). |
scripts/package-lock.json |
Lockfile update (dependency graph adjustments + peer markers). |
tests/package-lock.json |
Lockfile update (peer markers added). |
Copilot's findings
Files not reviewed (2)
- scripts/package-lock.json: Language not supported
- tests/package-lock.json: Language not supported
- Files reviewed: 5/8 changed files
- Comments generated: 5
JasonYeMSFT (JasonYeMSFT)
changed the title
Address Copilot review feedback: - Replace 'storage tiering' with 'reduce storage costs' in description - Tighten workflow triggers to storage-cost-specific terms (LRS/GRS, savings) - Clarify orphaned disks rule is compute-adjacent (billed as storage) - Add explicit cost/savings language to eval prompts for stable routing
JasonYeMSFT (JasonYeMSFT)
previously approved these changes
Jun 3, 2026
Member
|
Sai Koumudi Kaluvakolanu (@saikoumudi) Could you please help review? |
- Clarify Reader role is scoped (not global) in Quick Reference - Add --resource-group to inline verification command - Add explicit routing note for storage-only vs general optimization
Sai Koumudi Kaluvakolanu (saikoumudi)
approved these changes
Jun 3, 2026
This was referenced Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Storage cost optimization reference guide and fixes the SKILL.md token budget issue (#2157).
Changes
services/storage/azure-storage.mdwith prioritized optimization rules, lifecycle policy templates, Resource Graph queries, tier decision matrix, and pricingreferences/tools-and-best-practices.md(content extracted from SKILL.md to fix token limit)Checklist
cd tests && npm test): vally lint 3/3, build passesUSE FOR/DO NOT USE FOR/PREFER OVERclauses: confirmed no routing regressions. The azure-storage skill handles educational tier questions; azure-cost handles cost optimization actionsRelated Issues
Fixes #2157
Partial progress on #2524