Repository navigation
Support for generic GCC toolchains #6798
Description
Type: LanguageService
Describe the bug
- OS and Version: Windows 10 20H2
- VS Code Version: 1.52.1
- C/C++ Extension Version: 1.2.0-insiders
- Does this issue involve using SSH remote to run the extension on a remote machine?: No
- A clear and concise description of what the bug is, including information about the workspace (i.e. is the workspace a single project or multiple projects, size of the project, etc).
Many different embedded platforms use GCC as their compiler. This presents a problem for the extension, since it only supports x86, x64, arm and arm64, while there are many embedded platforms (just to name a few: AVR and ESP32). It's impossible to keep track of them all, so we should create a generic GCC target, which will only do the minimal things to get IntelliSense working (get C and C++ standards, get include folders, get predefined macros, etc.)
Steps to reproduce
Create a C++ configuration with a compiler that targets an embedded platform.
Expected behavior
Proper IntelliSense for embedded toolchains.
Logs
cpptools/didChangeCppProperties
Attempting to get defaults from C++ compiler in "compilerPath" property: 'C:/Users/nghuu/.platformio/packages/toolchain-atmelavr/bin/avr-gcc.exe'
Querying compiler for default C++ language standard using command line: "C:/Users/nghuu/.platformio/packages/toolchain-atmelavr/bin/avr-gcc.exe" -x c++ -E -dM nul
Querying compiler for default C language standard using command line: "C:/Users/nghuu/.platformio/packages/toolchain-atmelavr/bin/avr-gcc.exe" -x c -E -dM nul
Querying compiler's default target using command line: "C:/Users/nghuu/.platformio/packages/toolchain-atmelavr/bin/avr-gcc.exe" -dumpmachine
Compiler returned default target value: avr
Unhandled default compiler target value detected: avr
Attempting to get defaults from compiler found on the machine: 'C:\llvm-mingw\bin\gcc.exe'
Querying compiler for default C++ language standard using command line: "C:\llvm-mingw\bin\gcc.exe" -x c++ -E -dM nul
Querying compiler for default C language standard using command line: "C:\llvm-mingw\bin\gcc.exe" -x c -E -dM nul
Querying compiler's default target using command line: "C:\llvm-mingw\bin\gcc.exe" -dumpmachine
Unhandled default compiler target value detected:
No suitable compiler found. Please set the "compilerPath" in c_cpp_properties.json.
Attempting to get defaults from C compiler in "compilerPath" property: 'C:/Users/nghuu/.platformio/packages/toolchain-atmelavr/bin/avr-gcc.exe'
Attempting to get defaults from compiler found on the machine: 'C:\llvm-mingw\bin\gcc.exe'
No suitable compiler found. Please set the "compilerPath" in c_cpp_properties.json.
Screenshots
Unable to locate avr include files because the default include paths aren't set up properly:
Additional context
Default search paths for avr-gcc:
install: c:\users\nghuu\.platformio\packages\toolchain-atmelavr\bin\../lib/gcc/avr/5.4.0/
programs: =c:/users/nghuu/.platformio/packages/toolchain-atmelavr/bin/../libexec/gcc/avr/5.4.0/;c:/users/nghuu/.platformio/packages/toolchain-atmelavr/bin/../libexec/gcc/;c:/users/nghuu/.platformio/packages/toolchain-atmelavr/bin/../lib/gcc/avr/5.4.0/../../../../avr/bin/avr/5.4.0/;c:/users/nghuu/.platformio/packages/toolchain-atmelavr/bin/../lib/gcc/avr/5.4.0/../../../../avr/bin/
libraries: =c:/users/nghuu/.platformio/packages/toolchain-atmelavr/bin/../lib/gcc/avr/5.4.0/;c:/users/nghuu/.platformio/packages/toolchain-atmelavr/bin/../lib/gcc/;c:/users/nghuu/.platformio/packages/toolchain-atmelavr/bin/../lib/gcc/avr/5.4.0/../../../../avr/lib/avr/5.4.0/;c:/users/nghuu/.platformio/packages/toolchain-atmelavr/bin/../lib/gcc/avr/5.4.0/../../../../avr/lib/
The include paths are there, but the extension isn't grabbing it.
Activity
sean-mcmanus commentedon Jan 16, 2021
Similar to #3222 .
longnguyen2004 commentedon Jan 16, 2021
Also related to #4653
heartacker commentedon Jan 26, 2021
yes we need it
longnguyen2004 commentedon Jan 26, 2021
heartacker Please upvote this issue so it can be considered.
github-actions commentedon Jan 27, 2021
This feature request has received enough votes to be added to our backlog.
Colengms commentedon Apr 16, 2021
Long Nguyen (@longnguyen2004) Are you still seeing this issue with a recent version of the extension? I believe 1.2.0-insiders included a change which caused us to give up on compilers that did not successfully return defaults from a simple query without any additional config args. We had to revert that change, as some compilers are unable to provide defaults without additional args.
Based on the log output, I see that we were failing to query avr-gcc as well as llvm-mingw gcc. If that is still an issue in a recent version, it would seem to be due to those compilers diverging from the output format we usually see when querying gcc compilers. We would need to investigate and add support for compilers with unique output, on a per-compiler basis. Since support for an agnostic IntelliSense mode is tracked by #4653 , we could repurpose this issue to track adding support for avr-gcc, specifically.
longnguyen2004 commentedon Apr 16, 2021
Although IntelliSense still doesn't recognize the
avrtarget, at least the include paths are indexed correctly now, which is what I needI think all we need is a generic gcc/clang mode that disables the target and bitness detection, and it's good to go.
Although not related, llvm-mingw is working great as well
4wrxb commentedon Nov 16, 2021
I'm not sure if this is related, but we use clang's --gcc-toolchain option to specify a replacement for sysroot includes (which are very old in our env). compile_commands.json reflects this option (and I see it printed in log-diagnostics under the command entry), but the includes listed still include the default system includes instead.
I tried adding the --gcc-toolchain option to the configuration as a compiler argument as well, but it has no effect either.