Skip to content

JS/TS protocol buffer hangs onto a lot of memory if on big request or response is used.  #85565

Closed
Closed
JS/TS protocol buffer hangs onto a lot of memory if on big request or response is used. #85565
Assignees
mjbvz
Labels
debtCode quality issueshelp wantedIssues identified as good community contribution opportunitiesjavascriptJavaScript support issuestypescriptTypescript support issuesupstreamIssue identified as 'upstream' component related (exists outside of VS Code)
Milestone
January 2022

Description

@mjbvz
Matt Bierner (mjbvz)
opened on Nov 25, 2019

Extracted from #84940

The ProtocolBuffer has a leak where its internal buffer always grows, so if a response has the size 15MB, the internal buffer will always remain at 15MB and never shrink to something reasonable again.

microsoft/vscode-languageserver-node#544

Activity

  1. Matt Bierner (mjbvz)
    added
    debtCode quality issues
    on Nov 25, 2019
  2. Matt Bierner (mjbvz)
    self-assigned this
    on Nov 25, 2019
  3. Matt Bierner (mjbvz)
    added this to the Backlog milestone on Jan 23, 2020
  4. Matt Bierner (mjbvz)
    added
    help wantedIssues identified as good community contribution opportunities
    on Nov 20, 2020
  5. Matt Bierner (mjbvz)
    added
    javascriptJavaScript support issues
    typescriptTypescript support issues
    on Oct 11, 2021

  6. mjbvz commented on Oct 19, 2021

    @mjbvz
    Matt Bierner (mjbvz)
    on Oct 19, 2021
    ContributorAuthor

    Closing in favor of microsoft/TypeScript#46417 which would let us remove ProtocolBuffer entirely

  7. Matt Bierner (mjbvz)
    closed this as completedon Oct 19, 2021
  8. Matt Bierner (mjbvz)
    added
    upstreamIssue identified as 'upstream' component related (exists outside of VS Code)
    on Oct 19, 2021
  9. github-actions
    locked and limited conversation to collaborators on Dec 4, 2021
  10. Matt Bierner (mjbvz)
    modified the milestones: Backlog, January 2022 on Jan 10, 2022
  11. Matt Bierner (mjbvz)
    added 2 commits that reference this issue on Jan 10, 2022

    Use node ipc for communicating with TS Server

    45c9b6f

    Use node ipc for communication with TS Server (#135341)

    deb9abe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

debtCode quality issueshelp wantedIssues identified as good community contribution opportunitiesjavascriptJavaScript support issuestypescriptTypescript support issuesupstreamIssue identified as 'upstream' component related (exists outside of VS Code)

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions