Activity

1. aurelhann commented on Aug 24, 2021

   

   aurelhann

   on Aug 24, 2021

   More actions

   Any news or working workaround ?

   👍React with 👍1Reacted by Saran Tanpituckpong ✔️
2. ljharb commented on Aug 24, 2021

   

   ljharb

   on Aug 24, 2021

   Contributor

   More actions

   Sounds like you need to file a bug on rollup then?

   👎React with 👎6Reacted by Ian K Smith, Mike Orozco, Saran Tanpituckpong ✔️, Shehar Yar Khan, Blake Regalia and Eyal
3. Idered commented on Sep 25, 2021

   

   Idered

   on Sep 25, 2021

   More actions

   Importing one by one fixed this for me:

   import maxSatisfying from "semver/ranges/max-satisfying";
   import minSatisfying from "semver/ranges/min-satisfying";
   import coerce from "semver/functions/coerce";
4. himanshusinghs commented on Jan 24, 2022

   

   himanshusinghs

   on Jan 24, 2022

   More actions

   Facing the issue when trying to rollup a fastify server which depends on this package. If what @Idered mentioned is correct then I suppose the fix has to go to the packages that depends on semver, fastify in my case? Does anyone have more insight on what is going wrong?
5. lukekarrys

   changed the title [-][BUG] the package isn't compatible with Rollup[/-] [+][BUG] the package isn't compatible with Rollup due to require cycle[/+] on Feb 26, 2022
6. hadfieldn commented on May 3, 2022

   

   hadfieldn

   on May 3, 2022

   More actions

   Ran into this issue today. Not a blocker for us but it would be nice to eliminate the cycle warning. Wondering if the solution proposed by @lukastaegert has been considered/attempted? (It doesn't appear that it has.)

   I suppose the main issue is creating a breaking change for third-party code that imports Range and Comparator. Unfortunately I'm not familiar enough with this library yet to know what that impact would likely be, and what the workarounds might be.
7. dbaeumer

   added a commit that references this issue on Jun 22, 2022

   Avoid circular dependencies in SemVer (#957)

   ...

   2e2658c
8. bkleiner

   added a commit that references this issue on Jun 25, 2022

   workaround dependency cycle in node-semver

   ...

   50a86f5
9. rosefang commented on Jun 28, 2022

   

   rosefang

   on Jun 28, 2022

   Last edited by rosefang

   More actions

   Importing one by one fixed this for me:

   import maxSatisfying from "semver/ranges/max-satisfying";
   import minSatisfying from "semver/ranges/min-satisfying";
   import coerce from "semver/functions/coerce";

   thanks.
   I fixed the problem use this solution. But, I don't understand why. Can you explain it?
   @Idered Idered

   👍React with 👍1Reacted by James Holcomb
10. darcyclarke

    added

    Bugthing that needs fixingthing that needs fixing

    on Jul 28, 2022
11. lukekarrys

    added

    semver:majorbackwards-incompatible breaking changesbackwards-incompatible breaking changes

    on Oct 27, 2022
12. darcyclarke

    added this to the v8 milestone on Oct 31, 2022
13. mbtools commented on May 21, 2026

    

    mbtools

    on May 21, 2026

    Contributor

    More actions

    This was 5y ago.

    I tested this with latest version of rollup (4.60.4), the plugins, and semver. It now works correctly.

    I suggest closing this issue.

    Before

    https://github.com/thorn0/rollup-commonjs-semver-issue

    > node .\input.js
    true
    > node .\output.mjs
    false

    After

    https://github.com/mbtools/rollup-commonjs-semver-issue

    You do get a message about the circular dependency but the bundled code works fine:

    > node .\input.js
    true
    > node .\index.mjs
    Circular dependency: node_modules/semver/classes/comparator.js -> node_modules/semver/classes/range.js -> node_modules/semver/classes/comparator.js
    > node .\output.mjs
    true