Skip to content

Platform skill and nearby code still misstate the minimal preset, the seed mode default and two capability comments #31299

Closed

Description

@objectstack-fleet

domain:skills#3 · huangyiirene · session_01J8VVAj7CvjkGXvgXzd6RZ7

Filing gate: other sites from the contract review of PR #31297 (comment 6714732815, card #31184), outside that card's claim. ⛔ Not a claim. Triage sets the grade and the lane.

What is wrong (read on main 7c523aa1)

  1. Skill, platform § Seed Data: names upsert as the seed mode default. SeedMode defaults to ignore (packages/spec/src/data/seed.zod.ts ≈L207). The fix should be byte-neutral. The section is pinned as exhaustive over SeedMode by check-skill-identifier-liveness, so keep every mode named.
  2. Skill, platform § requires:: "--preset minimal drops exactly those" is not exact for job and queue. NEEDS_JOB_AND_QUEUE (packages/core/src/capability-composition.ts) puts them back under minimal when email, approvals or auth is present.
  3. Skill eval, skills/objectstack-automation/evals/integrations-declared.json case 1: its must_not_contain connector-esign appears in its own expected_output, and its must_contain type: 'api' does not (the skills evals: 15 cases forbid (must_not_contain) a string their own expected_output uses, so a careful answer that names the trap fails #31278 pattern).
  4. Spec comment (card skills: objectstack-automation still teaches job / queue / messaging as services you must list in requires:, but all three are always-on; mcp and pinyin-search host defaults are untaught #31184 item 5): the 'package-registry' jsdoc in packages/spec/src/kernel/platform-capabilities.ts (≈L385-L392) says the registry "keys marketplace, not this token". packages/core/src/capability-providers.ts (≈L174) keys 'package-registry'.
  5. CLI comment: packages/cli/src/commands/serve.ts ≈L2994-L2995 says an explicit requires: ['mcp'] "works regardless of the env var". The MCP route (runtime/domains/mcp.ts ≈L112-L114) answers 404 whenever isMcpServerEnabled() is false, listed or not. Either the comment or the behaviour is wrong. PR docs(skills): list job, queue and messaging only under --preset minimal; name the mcp and pinyin-search host defaults #31297 teaches neither.
  6. Example app: examples/app-showcase config and flow comments still list job / messaging in requires as needed. That is harmless at runtime, but it teaches the old opt-in reading that skills: objectstack-automation still teaches job / queue / messaging as services you must list in requires:, but all three are always-on; mcp and pinyin-search host defaults are untaught #31184 removed from the skills.

Suggested shape

Items 1-3 are one domain:skills card ('@objectstack/skills': patch; the platform SKILL.md row is priced by the token ratchet). Item 4 is the spec lane, item 5 the CLI lane (or a behaviour ruling first), and item 6 the examples owner. Triage may split them.

Related: #31184, PR #31297, PR #31181, #31278.

Activity

  1. added
    findingRecorded observation — held, not dispatchable until the findings triage round grades it
    documentationImprovements or additions to documentation
    domain:skillsDomain lane — seat card indexed by label:pm:seat
    pm:queueReady for the PM dispatch loop
    and removed
    findingRecorded observation — held, not dispatchable until the findings triage round grades it
    on Nov 8, 2026
  2. objectstack-fleet commented on Nov 8, 2026

    @objectstack-fleet
    ContributorAuthor

    triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U

    Path: none

    Triage: audit · p2 · domain:skills · 2026-11-08T01:07Z

    ⛔ Not a claim.


    Generated by Claude Code

  3. objectstack-fleet commented on Nov 8, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:skills#3 · huangyiirene · session_01J8VVAj7CvjkGXvgXzd6RZ7

    Claim: PM loop round 31 · 2026-11-08T04:25Z
    Session: session_01J8VVAj7CvjkGXvgXzd6RZ7
    Account: huangyiirene
    Branch: claude/project-thread-uuwdip (the card thread's designated branch; dev session session_01J8VVAmBZAddKTWUJs6Xnq2)
    Worktree: objectstack-issue-31299
    Domain: domain:skills
    Seat: domain:skills#3
    File surface: skills/objectstack-platform/SKILL.md (the § Seed Data mode default and the § requires: minimal-preset sentence, and same-file deletions that pay its budget); skills/objectstack-automation/evals/integrations-declared.json (case 1 only); packages/spec/src/kernel/platform-capabilities.ts (the 'package-registry' jsdoc only); packages/cli/src/commands/serve.ts (the one requires: ['mcp'] comment sentence, no behaviour change); examples/app-showcase/** (comments and the requires list only); generated reference docs only if a generator emits the spec jsdoc; .changeset/*.md; scripts/check-skills-token-ratchet.mjs only by standing ruling 6513306068 for a measured remainder, and only after the seat rules on the cuts (stop on breach)
    Container & model: M, mode:thread, project-default model, effort: high. dispatch-gates --tier is run by the thread and reported; any mandate above this thread's is waived by the maintainer's standing order in this project (2026-11-03) and said so in the PR body; this seat runs the contract review.
    Clause-②: no
    Metadata-protocol: none
    Responsibility: n/a — not a defect card (teaching text and comments lag the code; no behaviour changes)
    Thread-read: 6715435570
    Premise: holds on main e2e6ec7dc: platform SKILL.md L366 names upsert as the mode default (SeedMode defaults to ignore), and L296 says --preset minimal "drops exactly those"; the eval case, the spec jsdoc (≈L385-L392), the serve.ts L3002 comment and app-showcase objectstack.config.ts L109 read as the card says.
    Rulings: item 5 is the comment's wrong half: isMcpServerEnabled() is the single decision point and the route answers 404 when it is false, so the sentence is corrected and no behaviour changes; a test, ADR or doc asserting the opposite stops the thread and makes it a domain:server card.
    Serial constraints: none open. The seat runs serially (one card) by the maintainer's word of 2026-11-08; #31253 handed off (PR #31357 in the merge queue).

    Changeset '@objectstack/skills': patch (plus patch entries for spec or CLI only if the changeset rules require them for comment-only edits). Fixes #31299. Tier read by check-governed-merges at the PR.

  4. added
    pm:dispatchedDispatched to a dev agent by /pm-dispatch
    and removed
    pm:queueReady for the PM dispatch loop
    on Nov 8, 2026
  5. objectstack-fleet commented on Nov 8, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:skills#3 · huangyiirene · session_01J8VVAj7CvjkGXvgXzd6RZ7

    ACCEPT → PR #31377: full review 6717563682 and delta review 6717774623 (both PASS), comment 6718025495 ACCEPT, head 1ff1c115. GOVERNED Tier H (skills/**): the PR stays draft with pm:awaiting-merge, and os-zhuang and hotlong are requested. The should-fix item was applied in 1ff1c115. The out-of-surface sites are filed as #31379.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

documentationImprovements or additions to documentationdomain:skillsDomain lane — seat card indexed by label:pm:seatpriority:p2Medium: important, M3

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions