Repository navigation
Closed
Labels
documentationImprovements or additions to documentationImprovements or additions to documentationdomain:skillsDomain lane — seat card indexed by label:pm:seatDomain lane — seat card indexed by label:pm:seatpriority:p2Medium: important, M3Medium: important, M3
Description
domain:skills#3 · huangyiirene · session_01J8VVAj7CvjkGXvgXzd6RZ7
Filing gate: other sites from the contract review of PR #31297 (comment 6714732815, card #31184), outside that card's claim. ⛔ Not a claim. Triage sets the grade and the lane.
What is wrong (read on main 7c523aa1)
- Skill, platform § Seed Data: names
upsertas the seedmodedefault.SeedModedefaults toignore(packages/spec/src/data/seed.zod.ts≈L207). The fix should be byte-neutral. The section is pinned as exhaustive overSeedModebycheck-skill-identifier-liveness, so keep every mode named. - Skill, platform §
requires:: "--preset minimaldrops exactly those" is not exact forjobandqueue.NEEDS_JOB_AND_QUEUE(packages/core/src/capability-composition.ts) puts them back under minimal whenemail,approvalsorauthis present. - Skill eval,
skills/objectstack-automation/evals/integrations-declared.jsoncase 1: itsmust_not_containconnector-esignappears in its ownexpected_output, and itsmust_containtype: 'api'does not (the skills evals: 15 cases forbid (must_not_contain) a string their own expected_output uses, so a careful answer that names the trap fails #31278 pattern). - Spec comment (card skills: objectstack-automation still teaches job / queue / messaging as services you must list in requires:, but all three are always-on; mcp and pinyin-search host defaults are untaught #31184 item 5): the
'package-registry'jsdoc inpackages/spec/src/kernel/platform-capabilities.ts(≈L385-L392) says the registry "keysmarketplace, not this token".packages/core/src/capability-providers.ts(≈L174) keys'package-registry'. - CLI comment:
packages/cli/src/commands/serve.ts≈L2994-L2995 says an explicitrequires: ['mcp']"works regardless of the env var". The MCP route (runtime/domains/mcp.ts≈L112-L114) answers 404 wheneverisMcpServerEnabled()is false, listed or not. Either the comment or the behaviour is wrong. PR docs(skills): list job, queue and messaging only under --preset minimal; name the mcp and pinyin-search host defaults #31297 teaches neither. - Example app:
examples/app-showcaseconfig and flow comments still listjob/messaginginrequiresas needed. That is harmless at runtime, but it teaches the old opt-in reading that skills: objectstack-automation still teaches job / queue / messaging as services you must list in requires:, but all three are always-on; mcp and pinyin-search host defaults are untaught #31184 removed from the skills.
Suggested shape
Items 1-3 are one domain:skills card ('@objectstack/skills': patch; the platform SKILL.md row is priced by the token ratchet). Item 4 is the spec lane, item 5 the CLI lane (or a behaviour ruling first), and item 6 the examples owner. Triage may split them.
Metadata
Metadata
Assignees
Labels
documentationImprovements or additions to documentationImprovements or additions to documentationdomain:skillsDomain lane — seat card indexed by label:pm:seatDomain lane — seat card indexed by label:pm:seatpriority:p2Medium: important, M3Medium: important, M3
Activity
objectstack-fleet commentedon Nov 8, 2026
triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U
Path: none
Triage: audit · p2 ·
domain:skills· 2026-11-08T01:07Z⛔ Not a claim.
main7c523aa1:modedefault (the code defaults toignore, notupsert);--preset minimalvsjob/queue;'package-registry'jsdoc inpackages/spec;serve.tscomment aboutrequires: ['mcp'];app-showcasecomments.domain:skills, one card. Items 4 and 6 are comment-only and ride the same PR. Item 5 rides as a comment fix only if the comment is the wrong half. If the seat reads the behaviour as wrong (an explicitrequires: ['mcp']still 404s while the env flag is off), that goes to adomain:servercard instead, not into this PR.findingremoved,pm:queue.Generated by Claude Code
objectstack-fleet commentedon Nov 8, 2026
domain:skills#3 · huangyiirene · session_01J8VVAj7CvjkGXvgXzd6RZ7
Claim: PM loop round 31 · 2026-11-08T04:25Z
Session:
session_01J8VVAj7CvjkGXvgXzd6RZ7Account:
huangyiireneBranch:
claude/project-thread-uuwdip(the card thread's designated branch; dev sessionsession_01J8VVAmBZAddKTWUJs6Xnq2)Worktree:
objectstack-issue-31299Domain:
domain:skillsSeat:
domain:skills#3File surface:
skills/objectstack-platform/SKILL.md(the § Seed Datamodedefault and the §requires:minimal-preset sentence, and same-file deletions that pay its budget);skills/objectstack-automation/evals/integrations-declared.json(case 1 only);packages/spec/src/kernel/platform-capabilities.ts(the'package-registry'jsdoc only);packages/cli/src/commands/serve.ts(the onerequires: ['mcp']comment sentence, no behaviour change);examples/app-showcase/**(comments and therequireslist only); generated reference docs only if a generator emits the spec jsdoc;.changeset/*.md;scripts/check-skills-token-ratchet.mjsonly by standing ruling 6513306068 for a measured remainder, and only after the seat rules on the cuts (stop on breach)Container & model:
M,mode:thread, project-default model,effort: high.dispatch-gates --tieris run by the thread and reported; any mandate above this thread's is waived by the maintainer's standing order in this project (2026-11-03) and said so in the PR body; this seat runs the contract review.Clause-②: no
Metadata-protocol: none
Responsibility:
n/a — not a defect card(teaching text and comments lag the code; no behaviour changes)Thread-read: 6715435570
Premise: holds on
maine2e6ec7dc: platform SKILL.md L366 namesupsertas themodedefault (SeedModedefaults toignore), and L296 says--preset minimal"drops exactly those"; the eval case, the spec jsdoc (≈L385-L392), theserve.tsL3002 comment andapp-showcaseobjectstack.config.tsL109 read as the card says.Rulings: item 5 is the comment's wrong half:
isMcpServerEnabled()is the single decision point and the route answers 404 when it is false, so the sentence is corrected and no behaviour changes; a test, ADR or doc asserting the opposite stops the thread and makes it adomain:servercard.Serial constraints: none open. The seat runs serially (one card) by the maintainer's word of 2026-11-08; #31253 handed off (PR #31357 in the merge queue).
Changeset
'@objectstack/skills': patch(pluspatchentries for spec or CLI only if the changeset rules require them for comment-only edits).Fixes #31299. Tier read bycheck-governed-mergesat the PR.objectstack-fleet commentedon Nov 8, 2026
domain:skills#3 · huangyiirene · session_01J8VVAj7CvjkGXvgXzd6RZ7
ACCEPT → PR #31377: full review 6717563682 and delta review 6717774623 (both PASS), comment 6718025495 ACCEPT, head
1ff1c115. GOVERNED Tier H (skills/**): the PR stays draft withpm:awaiting-merge, andos-zhuangandhotlongare requested. The should-fix item was applied in1ff1c115. The out-of-surface sites are filed as #31379.