Repository navigation
[finding] objectui: QuickFilterBar JSDoc comments carry Chinese copy — Commandment #-1 applies to comments too #5446
Description
发现于实现 objectstack#5427(objectui PR #3386)时,与该 issue 的缺陷相邻但不同,故单独记录、未在该 PR 顺手改(scope = issue)。
现象
packages/plugin-gantt/src/QuickFilterBar.tsx 第 41 / 43 行的 JSDoc 注释里写着中文文案:
/** "全部" / "All" — the select-all toggle and empty-selection trigger text. */
all?: string;
/** "清除筛选" / "Clear" — clears every dimension. */
clear?: string;
AGENTS.md 诫条 #-1 的措辞覆盖注释,不止用户可见文案:"All user-facing text (component labels, buttons, titles, errors), code comments, docs …, and console/log messages MUST be English."
为什么是 observation-class 而不是缺陷
- 纯注释,不进产物、用户永远看不到,今天没有任何人会撞上;
- 先于 objectstack#5427 存在,且不是它的成因 —— 那个 issue 的成因是宿主
ObjectGantt把 label 写死了,QuickFilterBar本身行为正确(纯展示 + 回退英文),这一点在 objectui:ObjectGantthardcodes Chinese quick-filter labels — English-only-codebase violation, and the gantt toolbar is Chinese in every locale #5427 正文里已有明确结论; - 注释内容本身在描述"这个 label 长什么样",随着 objectui:
ObjectGantthardcodes Chinese quick-filter labels — English-only-codebase violation, and the gantt toolbar is Chinese in every locale #5427 把四条文案挪进gantt.quickFilter词条,注释里的中文示例已经不再对应任何调用点的字面量,更像是历史残留。
建议
改成纯英文,并顺带指向新的词条键,例如:
/** Select-all toggle and empty-selection trigger text. Host: `gantt.quickFilter.all`. */
同文件第 40-49 行的 QuickFilterLabels 其余成员注释一并扫一遍即可。packages/plugin-gantt/src/QuickFilterBar.test.tsx:40 也用中文字面量做 label 夹具 —— 那是测试数据(正在验证 label 透传),不属于本条,是否统一按英文夹具改写由维护者定。
严重度交 PM triage,不自行判定。
Generated by Claude Code
Activity
os-zhuang commentedon Aug 5, 2026
发现分诊轮:晋级
pm:queue(摘 finding,保留repo:objectui)。理由:AGENTS.md 诫条 #-1 的明确违例(注释也在其覆盖面内),单文件一次性修正、落点与建议措辞齐全、零行为风险 —— 持有零收益,五分钟单直接入队。范围提醒:测试夹具的中文字面量(QuickFilterBar.test.tsx:40)是被验证的数据,issue 已裁明不属本单,dev 勿顺手扩;QuickFilterLabels其余成员注释一并扫。本评论来自分诊座位 Routine(#5474 试点),不构成认领。Generated by Claude Code
os-zhuang commentedon Aug 10, 2026
Migrated to objectstack-ai/objectui#4021 under #7167 (file-at-destination ruling, maintainer 2026-08-10). Native GitHub issue transfer is not available to this session's credential, so the card was recreated at the destination; this thread stays as the authoritative history and is linked from the new card. Closing as not planned here — moved, not rejected.
Generated by Claude Code