[finding] objectui: QuickFilterBar JSDoc comments carry Chinese copy — Commandment #-1 applies to comments too #4021

Migrated from objectstack-ai/objectstack#5446 under the file-at-destination ruling (objectstack-ai/objectstack#7167, maintainer 2026-08-10). Originally filed 2026-08-05T12:09:38Z. The full prior thread — including triage rulings and hold/restart conditions — remains on the source issue and MUST be read before acting on this card.

发现于实现 objectstack#5427(objectui PR objectstack-ai/objectstack#3386)时,与该 issue 的缺陷相邻但不同,故单独记录、未在该 PR 顺手改(scope = issue)。

现象

packages/plugin-gantt/src/QuickFilterBar.tsx 第 41 / 43 行的 JSDoc 注释里写着中文文案:

/** "全部" / "All" — the select-all toggle and empty-selection trigger text. */
all?: string;
/** "清除筛选" / "Clear" — clears every dimension. */
clear?: string;

AGENTS.md 诫条 #-1 的措辞覆盖注释,不止用户可见文案:"All user-facing text (component labels, buttons, titles, errors), code comments, docs …, and console/log messages MUST be English."

为什么是 observation-class 而不是缺陷

• 纯注释,不进产物、用户永远看不到,今天没有任何人会撞上;
• 先于 objectstack#5427 存在,且不是它的成因 —— 那个 issue 的成因是宿主 ObjectGantt 把 label 写死了,QuickFilterBar 本身行为正确(纯展示 + 回退英文),这一点在 objectui: ObjectGantt hardcodes Chinese quick-filter labels — English-only-codebase violation, and the gantt toolbar is Chinese in every locale objectstack#5427 正文里已有明确结论;
• 注释内容本身在描述"这个 label 长什么样",随着 objectui: ObjectGantt hardcodes Chinese quick-filter labels — English-only-codebase violation, and the gantt toolbar is Chinese in every locale objectstack#5427 把四条文案挪进 gantt.quickFilter 词条,注释里的中文示例已经不再对应任何调用点的字面量,更像是历史残留。

建议

改成纯英文,并顺带指向新的词条键,例如:

/** Select-all toggle and empty-selection trigger text. Host: `gantt.quickFilter.all`. */

同文件第 40-49 行的 QuickFilterLabels 其余成员注释一并扫一遍即可。packages/plugin-gantt/src/QuickFilterBar.test.tsx:40 也用中文字面量做 label 夹具 —— 那是测试数据(正在验证 label 透传),不属于本条,是否统一按英文夹具改写由维护者定。

严重度交 PM triage,不自行判定。

Generated by Claude Code