Skip to content

Added DEVELOPER_GUIDE.md and html jacoco output - #35

Merged
msfroh merged 14 commits into
opensearch-project:mainfrom
macohen:main
Nov 29, 2022
Merged

Added DEVELOPER_GUIDE.md and html jacoco output#35
msfroh merged 14 commits into
opensearch-project:mainfrom
macohen:main

Conversation

@macohen

@macohen macohen commented Nov 23, 2022

Copy link
Copy Markdown
Collaborator

Description

  • Developer guide is now here to help external contributors get started.
  • build now exports html jacoco coverage reports as well

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

macohen and others added 14 commits November 17, 2022 10:33
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
added test that adds 1 more line of coverage. :|

Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
…removed release_notes file

Signed-off-by: Mark Cohen <markcoh@amazon.com>
@macohen
macohen requested a review from a team November 23, 2022 21:28
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #35 (d134182) into main (89ca332) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main      #35   +/-   ##
=========================================
  Coverage     60.43%   60.43%           
  Complexity      155      155           
=========================================
  Files            29       29           
  Lines           867      867           
  Branches        119      119           
=========================================
  Hits            524      524           
  Misses          304      304           
  Partials         39       39           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@msfroh
msfroh merged commit d9964b5 into opensearch-project:main Nov 29, 2022
@noCharger noCharger added the backport 2.x Backport to 2.x branch label Dec 23, 2022
opensearch-trigger-bot Bot pushed a commit that referenced this pull request Dec 23, 2022
* Developer guide is now here to help external contributors get started.
* build now exports html jacoco coverage reports as well

Signed-off-by: Mark Cohen <markcoh@amazon.com>
Co-authored-by: Mark Cohen <macohen@users.noreply.github.com>
(cherry picked from commit d9964b5)
noCharger pushed a commit that referenced this pull request Dec 23, 2022
* Developer guide is now here to help external contributors get started.
* build now exports html jacoco coverage reports as well

Signed-off-by: Mark Cohen <markcoh@amazon.com>
Co-authored-by: Mark Cohen <macohen@users.noreply.github.com>
(cherry picked from commit d9964b5)

Co-authored-by: Mark Cohen <markcoh@amazon.com>
@mingshl mingshl added the documentation Improvements or additions to documentation label Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x Backport to 2.x branch documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants