Repository navigation
Regression with parallel tests on 2.7.3 and 2.8 #1083
Description
Hello,
Some tests in pip test suite started failing with latest pytest releases:
- https://travis-ci.org/pypa/pip/builds/82695909 is develop with parallel testing and pytest==2.8 (2 tests failing)
- https://travis-ci.org/pypa/pip/builds/82716794 is develop but no parallel testing and pytest==2.8 (all green)
- https://travis-ci.org/pypa/pip/builds/82720894 is develop, parallel testing and pytest==2.7.3 (only test_install_from_local_directory_with_symlinks_to_directories failing, test_install_user_in_global_virtualenv_with_conflict_fails ok)
- https://travis-ci.org/pypa/pip/builds/82721613 is develop parallel testing and pytest==2.7.2 (all green)
Activity
Merge pull request #3150 from xavfernandez/pin_pytest_272
19 remaining items
nicoddemus commentedon Jun 1, 2016
@RonnyPfannschmidt any further thoughts?
Either way, we really should tackle and solve this once and for all in the upcoming pytest sprint, in a couple of weeks.
RonnyPfannschmidt commentedon Jul 19, 2016
after some more investigation it seems like the tmpdir initialization/re-initialization at slave startup happens multiple times, once with the xdist configuration, once without
RonnyPfannschmidt commentedon Jul 19, 2016
this is related to #1618
nicoddemus commentedon Jul 22, 2016
Opened pypa/pip#3863 which fixes this problem, although I couldn't identify why the original code did not work in the first place.
RonnyPfannschmidt commentedon Jul 22, 2016
my current impression is that the initialization of the tmpdir handler on a remote pytest is incorrect and happens twice due to the option application happening after the pytest initialization instead of before
xavfernandez commentedon Jul 22, 2016
Well, it's a good news that pip can now use the latest pytest.
But I'm uncomfortable with the fact we don't now why :-/
I guess you've already checked similar logs (
PYTEST_DEBUG = 1) but I've recreated a branch to have more infos on the failure: https://travis-ci.org/pypa/pip/jobs/146602684nicoddemus commentedon Jul 23, 2016
@xavfernandez agreed, @RonnyPfannschmidt has hunch that the problem might be regarding how options (specially
basetemp) is forwarded and handled at the slaves, see #1743.RonnyPfannschmidt commentedon Jul 23, 2016
@xavfernandez did some tests showing that my hunch was wrong
nicoddemus commentedon Jul 23, 2016
@RonnyPfannschmidt I was thinking, while #1743 makes sense, that wouldn't explain why their old
tmpdirimplementation did not work, after all it was correctly usingconfig._tmpdir_factory(see my PR), which is also used by pytest's owntmpdir.RonnyPfannschmidt commentedon Jul 23, 2016
@nicoddemus yes, ever since @xavfernandez demonstrated that the issue is in fact not related to that, i do wonder what is the actual cause