Repository navigation
test(sentinel): complete bounded external evidence acceptance - #217
Merged
Merged
Conversation
sodejm
marked this pull request as ready for review
October 6, 2026 01:56
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sentinel's external-evidence pipeline enforced its input and integrity boundaries, but lacked acceptance coverage for exact limits, nested pointers, and specific identity/hash failures. This change proves those cases and documents the provenance and omissions an operator must retain when partitioning or summarizing evidence.
Closes #207.
Acceptance criteria
Evidence
make checkpassed in the dedicated checkout using the repository virtual environment.git diff --checkpassed; the committed worktree is clean.ee65998f5008f099ad01bd5c45eba00147be46f4. The separately merged head wasd99a1deaad1a1ab66910a79a4729cb1fb5691b74; later local review covered integration head6ef1845386f2615d2af90a25a418ed6f1083342f, which was not part of this PR merge.d99a1deaad1a1ab66910a79a4729cb1fb5691b74. PR merged at42cb017012934839702ce0b939a5cbc9193271ea. The preservation of the upstream exact-hostname regression is submitted separately in Restore Sentinel authoritative-hostname regression #219 (commit50a1468).Impact review
Risks and residual uncertainty
This is offline acceptance evidence. No Microsoft service or live tenant execution occurred. Accepted external fixtures remain manually supplied and unattested; production efficacy, cost, latency, false-positive performance, and external authenticity remain unverified.