Repository navigation
Restore Sentinel authoritative-hostname regression - #219
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 50a14682e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def test_authoritative_reference_requires_exact_hostname(self) -> None: | ||
| self.assertEqual(_reference_record("https://learn.microsoft.com/docs")['kind'], "authoritative") |
There was a problem hiding this comment.
At the repository's CI entry point, this test is never collected: .github/workflows/repository-contract.yml invokes make check, while scripts/agent/check.py runs the root tests/ suite and only the attack-path plugin's unit tests, and this plugin's package.json declares no unit-test command. A future regression in deceptive-host classification would therefore leave the normal checks green, so wire this module into the plugin validation or make check path.
AGENTS.md reference: AGENTS.md:L171-L172
Useful? React with 👍 / 👎.
1 participant
Summary
Restore the authoritative-reference hostname regression test that was absent from merged PR #217. The test accepts the exact Microsoft documentation hostname and rejects a deceptive suffix, Microsoft text embedded in an unrelated URL path, and Microsoft text in URL user information.
Follow-up to #207 and #217. Validator behavior is unchanged.
Validation
make checkpassed in this dedicated worktree on commit50a1468.git diff --checkpassed.50a14682e1961e628a893bf545e25fbb15556c19, found no actionable issues, and reproduced the focused test (1/1 passed).50a14682e1961e628a893bf545e25fbb15556c19(verified 2026-10-06 02:10 UTC).Impact
This restores one regression test. Documentation already describes the merged behavior, so no documentation change is required. No schema, migration, dependency, or operational behavior changes are included. The test uses synthetic URLs and requires no live Microsoft tenant.