Repository navigation
[#195] 🐛 - AI PR description not ignoring files - #198
Merged
efraespada merged 5 commits intoMar 25, 2025
Merged
Conversation
…g logic in update_pull_request_description_use_case.ts; added support for patterns ending with /* to ignore subdirectories and improved regex handling for special characters. Added console logs for better debugging during change processing.
|
To view this pull requests documentation preview, visit the following URL: docs.page/landamessenger/git-board-flow~198 Documentation is deployed and generated using docs.page. |
1 task done
Contributor
🐛 Bugfix Actions
🚀 Happy coding! |
…debugging capabilities across various use cases; replace console.error with centralized logError function for consistent error handling. Introduce debug flag in Execution class to control logging verbosity.
…ps://github.com/landamessenger/git-board-flow into bugfix/195-ai-pr-description-not-ignoring-files
Contributor
🐛 Bugfix Actions
🚀 Happy coding! |
1 similar comment
Contributor
🐛 Bugfix Actions
🚀 Happy coding! |
Contributor
🐛 Bugfix Actions
🚀 Happy coding! |
1 task done
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



#195
What does this PR do?
This pull request addresses the issue where the AI PR description was not properly ignoring some files. When setting the config to ignore files under the
distfolder, they were not being ignored as expected. This has been fixed in the master branch.What files were changed?
src/data/manager/description/base/content_interface.ts:calculateTotalto the interface.getDatamethod to return an array of objects.logErrorinstead of directly logging the error.src/data/model/execution.ts:-151,6 +154,7Changed the parameters order in the constructor of the Execution class, moving "singleAction" to the second position:
Modified the constructor parameters to include the new "debug" property:
src/data/model/single_action.ts:deployedActionconstant value remains the same.SingleActionclass is not modified.SingleActionclass, the console error messages for when an issue is not a number have been updated to use alogErrorfunction instead of directly logging to the console. The error message order has also been changed to first log the issue number error and then the general error.src/data/repository/branch_repository.ts:logDebugInfoandlogErrorfrom '../utils/logger'In this section of the file, a slight modification was made in the BranchRepository. The code was adjusted to retrieve all branches from the BranchModel in a sorted order by name. The change improved the functionality of fetching branches from the database.
src/data/repository/issue_repository.ts:console.errortologError.In the modified section of the file, a change was made from using
console.errortologErrorwhen handling an error message related to fetching the issue title. This update will now log the error using thelogErrorfunction instead of directly usingconsole.error.src/data/usecase/actions/deployed_action_use_case.ts:+import { logError } from "../../utils/logger";
src/data/usecase/commit_check_use_case.ts:This import statement was added below the existing import statements at the beginning of the file.
CommitTypeinterface:commitTypeof typeCommitTypeto thecommitCheckmethod:console.errortologErrorresultsarray using the spread operator:src/data/usecase/publish_resume_use_case.ts:logErrorinstead of console.error:src/data/usecase/pull_request_link_use_case.ts:src/data/usecase/remove_issue_branches_use_case.ts:src/data/usecase/single_action_use_case.ts:+import { logError } from "../../utils/logger";
src/data/usecase/steps/assign_reviewers_to_issue_use_case.ts:assign_reviewers_to_issue_use_case.tsfile. The change can be seen in the following excerpt from the file:and after modification, it became:
src/data/usecase/steps/check_changes_issue_size_use_case.ts:Changed the logic for updating the issue size:
src/data/usecase/steps/check_changes_pull_request_size_use_case.ts:-
public async execute(payload: CheckChangesPullRequestSizeUseCasePayload): Promise {src/data/usecase/steps/check_permissions_use_case.ts:+import { logError } from "../../utils/logger";
src/data/usecase/steps/execute_script_use_case.ts:executefunction:logErrorfunction from the logger utility module:src/data/usecase/steps/get_hotfix_version_use_case.ts:Added one line and modified one line in the patch section of the file. The added line is:
The modified line is:
logErrorfunction from the logger file:@@ -80,7 +81,7 + const releaseType = await this.releaseRepository.getReleaseType();The previous console.error statement was replaced with a call to the logError function.
src/data/usecase/steps/get_release_version_use_case.ts:import { logError } from "../../utils/logger";
src/data/usecase/steps/label_deploy_added_use_case.ts:+import { logError } from "../../utils/logger";
The error handling code was updated to call a
logErrorfunction instead of directly usingconsole.error. This is done for consistency in error handling and logging.src/data/usecase/steps/label_deployed_added_use_case.ts:+import { logError } from "../../utils/logger";
This change adds the label "deployed" to the use case steps in the specified file.
-1 line was modified in the DeployedAddedUseCase class, changing
console.error(error);tologError(error);.src/data/usecase/steps/link_issue_project_use_case.ts:+import { logError } from "../../utils/logger";In this section, a new import statement for the
logErrorfunction from theloggerutility was added to the existing imports in the file.src/data/usecase/steps/link_pull_request_issue_use_case.ts:Added code to import a new module:
Updated the function signature to include a new parameter:
src/data/usecase/steps/link_pull_request_project_use_case.ts:src/data/usecase/steps/notify_new_commit_on_issue_use_case.ts:src/data/usecase/steps/prepare_branches_use_case.ts:Changed another line of code by adding an extra condition:
prepare_branches_use_case.tsfile, the code in thePatchsection was modified. Specifically, two lines were added and one line was removed from lines 312 to 313.-312,7 +313,7PrepareBranchesUseCaseclass has been updated.src/data/usecase/steps/update_pull_request_description_use_case.ts:updatePullRequestDescriptionupdatePullRequestDescriptionUseCaseThis change allows the UpdatePullRequestDescriptionUseCase class to use the logError function for handling errors in the code.
Added a console log to show the file currently being processed:
Added a console log to indicate if a file should be ignored:
Replaced a console error with a logError function call:
src/data/usecase/store_configuration_use_case.ts:Made a change in the file with a +2 -1 difference.
configRepositorymodule.saveConfigurationto include a new parameteruserId.