Repository navigation
fix(security): keep credential health secrets out of curl arguments - #683
Merged
efraespada merged 1 commit intoOct 24, 2026
Conversation
…isclosure: keep credential health secrets out of process arguments (#682)
|
To preview the documentation for this pull request, visit the following URL:
|
Contributor
Bugbot: review complete
|
Contributor
Copilot approval · Human review neededStatus: This pull request is outside the configured approval scope. Technical evidenceRevision: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #683 +/- ##
===========================================
+ Coverage 90.94% 94.14% +3.19%
===========================================
Files 135 974 +839
Lines 6251 31653 +25402
Branches 1338 9296 +7958
===========================================
+ Hits 5685 29799 +24114
- Misses 172 707 +535
- Partials 394 1147 +753
🚀 New features to boost your workflow:
|
This was referenced Oct 24, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Credential health checks now send provider authentication through curl stdin, preventing secrets from appearing in process arguments or Google request URLs. The change preserves opt-in checks while rejecting invalid credentials and blocking redirects that could forward sensitive headers.
What changed
x-goog-api-keyheader; requests remain HTTPS-only, bounded, and redirect-blocked.Validation
Review notes