Skip to content

test: cover indirect unittest discovery and genuine exclusions - #816

Merged
efraespada merged 1 commit into
developfrom
bugfix/806-review-claims-a-unittest-module-never-runs-despite-wildcard-discovery-and-actual-ci-execution
Oct 30, 2026
Merged

efraespada merged 1 commit into
developfrom
bugfix/806-review-claims-a-unittest-module-never-runs-despite-wildcard-discovery-and-actual-ci-execution

Conversation

@efraespada

@efraespada efraespada commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

The reported v3 review incorrectly inferred that indirect unittest discovery never executes a module. The current upstream baseline already keeps the valid paths and detects the real exclusions; this PR adds explicit regression coverage and provenance while preserving production instructions and packaged runtime byte-for-byte.

Closes #806

What changed

  • Add six owned scenarios for delegated selection, nested cwd, literal wildcard argv, excluded patterns, wrong directories and missing runner evidence; preserve all 120 existing corpus cases and references.
  • Add 20 deterministic selection/scorer/delivery/privacy controls and a separate optional authored Python probe. Corpus text is never executed and no Python requirement is added to Node CI.
  • Record complete actual baseline/rejected-proposal measurements, source identities and documentation. Private consumer sources/logs stay outside the repository; no consumer code was executed or modified.

Validation

  • Six focused suites: 216 tests passed; unchanged shared prompt has 100% statements, branches, functions and lines.

  • Types, lint, specifications, documentation, workflows and agent-doc contracts pass. Graphify is updated; package validation and isolated CLI/API/web smoke pass.

  • Final CLI hash and production source match the selected measured baseline exactly. Coverage validation retains every existing global/module budget; there is no executable production delta to assign a patch percentage.

  • Mandatory normal commit hook passes: rebuilt bundles, 814 suites and 15,453 tests passed with 35 existing skips, then lint. Committed build validation passes and the tracked tree is clean.

Review notes

The six-case baseline has zero false positives/negatives but only one of two exact anchors, failing the unchanged location floor. An expanded discovery instruction gives worse anchors and is rejected; its score and complete predictions are retained in quality/bugbot/evidence/issue-806.json. This is regression coverage for existing grounding, without a claimed model-quality improvement, historical reproduction or consumer adoption. No threshold is lowered.

…d-discovery-and-actual-ci-execution: cover indirect unittest discovery grounding
@docs-page

docs-page Bot commented Oct 30, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~816

Documentation is deployed and generated using docs.page

@vypbot
vypbot self-requested a review October 30, 2026 19:49
@vypbot vypbot added this to vypdev Oct 30, 2026
@vypbot vypbot moved this to In Progress in vypdev Oct 30, 2026
@vypbot
vypbot changed the base branch from develop to master October 30, 2026 19:49
@vypbot vypbot added the size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. label Oct 30, 2026
@vypbot
vypbot changed the base branch from master to develop October 30, 2026 19:50
@vypbot vypbot added the 75% Progress: 75% label Oct 30, 2026
@vypbot

vypbot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on acde95e.

Pull request · Verified commit · Workflow run

@vypbot

vypbot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: acde95e2c403; base: bc4aec78a063; reason: protected-path.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.17%. Comparing base (5b3664f) to head (acde95e).
⚠️ Report is 109 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #816      +/-   ##
===========================================
+ Coverage    94.50%   95.17%   +0.67%     
===========================================
  Files         1035     1104      +69     
  Lines        33299    36348    +3049     
  Branches      9824    10852    +1028     
===========================================
+ Hits         31468    34594    +3126     
+ Misses         699      673      -26     
+ Partials      1132     1081      -51     

see 161 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@efraespada
efraespada merged commit 132f240 into develop Oct 30, 2026
13 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

75% Progress: 75% size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - Review claims a unittest module never runs despite wildcard discovery and actual CI execution

3 participants