Skip to content

πŸ›πŸ§‘β€πŸ’» - Review claims a unittest module never runs despite wildcard discovery and actual CI executionΒ #806

Closed

Description

@efraespada

Is there an existing issue for this?

Which actions are affected?

Pull Request

Which platforms are affected?

Linux self-hosted Action; independent discovery control on macOS.

Description

Bugbot reports that test_wire_export_task.py is never run by CI, despite the configured runner selecting test_wire_*.py and actual CI executing all five methods from that exact module. Its suggestion would add a redundant invocation to an already wired suite.

The precise internal cause (context selection, glob interpretation or analysis reasoning) is not established. This is a grounded review-quality counterexample, not a request to ignore genuine missing-test wiring or relax review gates.

Reproducing the issue

Observed GeckoCV source: 1b5e3a0ade73d21c749bceba004230fc97f2713e, PR vypdev/geckocv#42.

[sys.executable, "-m", "unittest", "discover", "-s", ".github/scripts/tests",
 "-p", "test_wire_*.py", "-v"]

Independent unittest.defaultTestLoader.discover('.github/scripts/tests', pattern='test_wire_*.py') lists 19 cases, including all five test_wire_export_task.WireExportTaskTests cases. This control performs discovery only; it is not counted as another test execution.

The actual completed native producer log separately records all five as ... ok:

test_a_passing_test_without_export_is_still_a_failed_producer
test_main_export_cannot_reuse_previous_serializer_fixture_evidence
test_missing_exporter_fails_and_removes_old_evidence_even_with_no_test_sources
test_output_symlink_does_not_change_its_target
test_parent_symlink_is_rejected_before_any_write
Ran 19 tests in 50.251s

The five names belong to the disputed module and are a subset of 19, not 24 distinct cases. Source and CI invocation remain unchanged; this report does not fabricate execution by adding an invocation after the finding.

copilot Version

Observed review uses published vypdev/copilot@v3 at f5e5a4c / 3.10.6. No claim is made about an unexecuted newer release or an internal root cause.

Relevant Log Output

The finding says: "the wire transport runner runs its own named test module" and that "no workflow invokes this file directly". The configured wildcard and actual five module-qualified OK records above contradict the claimed missing execution. This is separate from whether a file is invoked directly rather than included through discovery.

Additional context and comments

Please cover wildcard-based Python discovery and indirect runner delegation in source-grounding/evaluation, including genuinely excluded-module negative controls, and consult available same-source execution evidence before asserting a test is never run. Preserve conservative handling of missing or ambiguous evidence.

Please handle the correction through the Copilot team's normal workflow. This reporter has not started an upstream implementation branch, changed correct consumer discovery, reduced scope, lowered thresholds or published a release/deployment. Other real GeckoCV review defects remain open.

Activity

  1. added
    bugSomething isn't working
    bugfixSomething isn't working
    priority: highCritical issue, needs immediate attention.
    on Oct 30, 2026
  2. added theissue type on Oct 30, 2026
  3. moved this to Todo in vypdevon Oct 30, 2026
  4. changed the title [-]Review claims a unittest module never runs despite wildcard discovery and actual CI execution[/-] [+]πŸ› - Review claims a unittest module never runs despite wildcard discovery and actual CI execution[/+] on Oct 30, 2026
  5. vypbot commented on Oct 30, 2026

    @vypbot
    Contributor

    Hi! I’m @vypbot, the Copilot assistant for this repository.

    I can answer questions, explain the codebase, propose implementation and test plans, review issues and pull requests for potential bugs or security problems, and help authorized maintainers apply changes.

    Try /copilot help to see the available commands, or mention @vypbot with your question.

  6. moved this from Todo to In Progress in vypdevon Oct 30, 2026
  7. added
    branchedIndicates that a branch has been created for this issue.
    on Oct 30, 2026
  8. changed the title [-]πŸ› - Review claims a unittest module never runs despite wildcard discovery and actual CI execution[/-] [+]πŸ›πŸ§‘β€πŸ’» - Review claims a unittest module never runs despite wildcard discovery and actual CI execution[/+] on Oct 30, 2026
  9. added
    state:workingWork can proceed on the verified branch or without a branch.
    on Oct 30, 2026
  10. vypbot commented on Oct 30, 2026

    @vypbot
    Contributor

    Implementation plan

    Current status: Ready to start. No action is required from maintainers before implementation.

    1. Define the evidence contract
      • Require source-grounded claims about test execution to trace configured discovery patterns and delegated runner calls.
      • Consult available same-source execution logs before claiming a test is never run; preserve uncertainty when evidence is missing or ambiguous.
    2. Add discovery scenarios
      • Add cases for wildcard-based Python unittest discovery and indirect runner delegation, including the reported test_wire_export_task.py scenario.
      • Add negative controls for modules genuinely excluded by the configured pattern or runner path.
    3. Update reviewer guidance
      • Apply the evidence contract consistently to production review and benchmark prompts.
      • Keep genuine missing-test wiring reportable and retain existing conservative handling of incomplete evidence.
    4. Validate evaluation behavior
      • Add deterministic checks for the new cases and their expected verdicts without changing existing thresholds.
      • Run the configured Bugbot evaluation and, where available, inspect real-agent predictions against the same cases.
    5. Document scope and evidence limits
      • Update the Bugbot quality documentation to describe the new discovery controls and what synthetic evaluation does not establish.
      • Record whether the historical finding was reproduced and distinguish fixture results from actual model measurements.

    Acceptance: The new discovery cases pass the existing Bugbot evaluation thresholds, the included excluded-module controls retain their expected findings, and documentation makes clear that evaluation fixtures do not prove general model accuracy.

    Need something else? Mention the bot with a question or use /copilot help.

  11. added
    size: XXLIndicates an extremely large task or issue that requires significant time and effort to complete.
    on Oct 30, 2026
  12. vypbot commented on Oct 30, 2026

    @vypbot
    Contributor

    Issue closed β€” historical progress

    Current status: closed as completed.

    The last estimate is retained below as history. Closure does not certify a new percentage, tests, or branch alignment.

    Action required: none for this closed issue. If work continues, reopen the issue; a fresh assessment can update this same card.

    Last assessment before closure (historical)

    Progress: 75% β€” in progress

    > Current status: [R1] Please cover wildcard-based Python discovery and indirect runner delegation in source-grounding/evaluation, including genuinely excluded-module negative controls, and consult available same-source execution evidence before asserting a test is never run. Preserve conservative handling of missing or ambiguous evidence. β€” Source patches add wildcard discovery and delegated-runner cases, excluded-module controls, and guidance to trace effective working directory, discovery directory, patterns, and same-source execution evidence. Supplied reports describe execution, but are not independent execution attestation.
    [R2] "acceptance": "The new discovery cases pass the existing Bugbot evaluation thresholds, the included excluded-module controls retain their expected findings, and documentation makes clear that evaluation fixtures do not prove general model accuracy." β€” Documentation states that fixtures do not establish general model accuracy and records excluded-module controls and unchanged thresholds. The supplied evidence reports that the current baseline fails the location threshold and the proposed instruction was rejected; it does not establish that the new cases pass the existing evaluation thresholds.

    Next: [R2] "acceptance": "The new discovery cases pass the existing Bugbot evaluation thresholds, the included excluded-module controls retain their expected findings, and documentation makes clear that evaluation fixtures do not prove general model accuracy." β€” Independently verify that the new discovery cases and excluded-module controls meet the existing Bugbot evaluation thresholds.

  13. vypbot commented on Oct 30, 2026

    @vypbot
    Contributor

    Issue closed: synchronization recommendation retired

    No branch synchronization is required for this closed issue.

    The previous recommendation is historical. Issue closure does not certify that the branches are synchronized.

  14. moved this from In Progress to Done in vypdevon Oct 30, 2026
  15. added
    100%Progress: 100%
    and removed
    in-progressStart work on an admitted issue.
    state:workingWork can proceed on the verified branch or without a branch.
    on Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

100%Progress: 100%branchedIndicates that a branch has been created for this issue.bugSomething isn't workingbugfixSomething isn't workingpriority: highCritical issue, needs immediate attention.size: XXLIndicates an extremely large task or issue that requires significant time and effort to complete.

Type

Projects

  • Status
    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions