Skip to content

fix: recover bounded progress partition fact overflows - #852

Merged
efraespada merged 5 commits into
developfrom
bugfix/830-progress-partition-rejects-per-file-implemented-text-with-schema-string-long-and-no-file-identity
Nov 2, 2026
Merged

efraespada merged 5 commits into
developfrom
bugfix/830-progress-partition-rejects-per-file-implemented-text-with-schema-string-long-and-no-file-identity

Conversation

@efraespada

@efraespada efraespada commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

An overlong per-file progress fact currently aborts a complete comparison with only an array position. This verifies the returned part/path/unit, locale and selected limit, then requests one concise replacement for the same complete immutable part. Persistent overflow reports exact safe identities and Unicode counts, preserving previously published progress.

The part and final-response allowances remain independent. Each attributable part may be replaced once; the existing final controller may separately reassess one completion contradiction. Every part, receipt, final result and freshness fence must validate before one normal publication. Persistent part failure never enters the final stage; final exhaustion never repeats parts or source reads.

Validation

  • Six native-adapter regressions failed before the part fix. Three additional composition regressions failed against the exact merged base before integration and now pass, including the complete 887-path / 952-unit / 6,503,131-byte immutable fixture.
  • All 68 focused integration/controller cases pass. The focused SDD retains its original 36-case budget and adds three independent composition cases; the final controller's separate 40-case inventory remains intact.
  • Full local coverage passes: 857 Jest suites / 16,460 tests (35 preexisting skips); 267 extension tests at 100% all metrics. Local LCOV versus f085fb90: 85/85 modified runtime lines covered, zero misses/partials; all four new modules have 100% lines, statements, functions and branches. Coverage budgets, typecheck, lint, documentation/specification/workflow contracts, package validation and packaged CLI/API/web smoke checks pass. Graphify updated.
  • Remote current-head review, platform checks and official correct-base Codecov remain required; local coverage does not establish remote acceptance.

Review notes

No new configuration, response schema, permissions or stored-state migration. Both possible part envelopes are preflighted for every part, preserving every existing capacity, deadline and source receipt. Provider/cancellation and unrelated validation errors retain their categories. Rejected prose is never copied, clipped or accepted. Action/CLI/API bundles are generated normally.

The Action synchronized this branch with develop through run 41482379561. This addresses the recurring part-length Commit blocker in #837; that PR's independent extension findings and native acceptance remain separate work. Complete review without findings, all applicable technical checks, official correct-base Codecov 100% modified lines with zero misses/partials and the protected-path human decision are required before merge.

Closes #830.

…schema-string-long-and-no-file-identity: recover bounded progress partition fact overflows
@vypbot vypbot added the size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. label Nov 2, 2026
@docs-page

docs-page Bot commented Nov 2, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~852

Documentation is deployed and generated using docs.page

@vypbot
vypbot self-requested a review November 2, 2026 08:41
@vypbot vypbot added this to vypdev Nov 2, 2026
@vypbot vypbot moved this to In Progress in vypdev Nov 2, 2026
@vypbot
vypbot changed the base branch from develop to master November 2, 2026 08:41
@vypbot
vypbot changed the base branch from master to develop November 2, 2026 08:41
@vypbot

vypbot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on b5a5a30.

Pull request · Verified commit · Workflow run

@vypbot

vypbot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: b5a5a3007cbe; base: f085fb906afd; reason: protected-path.

@codecov-commenter

codecov-commenter commented Nov 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.31%. Comparing base (f085fb9) to head (b5a5a30).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #852   +/-   ##
========================================
  Coverage    95.30%   95.31%           
========================================
  Files         1129     1133    +4     
  Lines        37258    37330   +72     
  Branches     11107    11125   +18     
========================================
+ Hits         35510    35582   +72     
  Misses         672      672           
  Partials      1076     1076           
Files with missing lines Coverage Δ
...tion/policies/application_error_message_catalog.ts 100.00% <ø> (ø)
.../policies/application_error_presentation_policy.ts 100.00% <100.00%> (ø)
...ation/policies/progress_partition_length_policy.ts 100.00% <100.00%> (ø)
...cases/actions/query_progress_partition_workflow.ts 100.00% <100.00%> (ø)
...usecases/actions/query_progress_result_workflow.ts 100.00% <100.00%> (ø)
...ecases/actions/summarize_progress_diff_workflow.ts 100.00% <100.00%> (ø)
src/data/model/application_error.ts 100.00% <100.00%> (ø)
.../data/repository/progress_agent_response_policy.ts 100.00% <100.00%> (ø)
...ta/repository/progress_partition_length_failure.ts 100.00% <100.00%> (ø)
src/domain/progress_partition_length_failure.ts 100.00% <100.00%> (ø)
... and 1 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…schema-string-long-and-no-file-identity: clarify unchanged progress completion equivalence
@efraespada

Copy link
Copy Markdown
Member Author

/copilot sync-branch

@vypbot

vypbot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Request could not be completed

Impact: Branch synchronization stopped at verification command 3 (pnpm run test:coverage): stage command, reason command-failed.

Action: Inspect the failed stage in the linked workflow logs. For dependencies, provision the source Node/pnpm toolchain and repair the frozen candidate workspace graph; for setup/runtime, repair the same-job prerequisites; for command failures, correct the configured verifier. Then retry /copilot sync-branch. Blind retries do not repair a graph mismatch.

Retained state: No synchronization commit or push was attempted. Original head: dca6114. Local rollback: restored; restored means the original head was verified, unverified requires operator inspection before retrying.

Error code: workflow.failed

Retryable: No

Reference: 053f5350-4d6b-4dff-94e9-85c5cd418bea

…schema-string-long-and-no-file-identity: Separate direct parser compatibility from final assessment workflow policy
@efraespada

Copy link
Copy Markdown
Member Author

/copilot sync-branch

…lemented-text-with-schema-string-long-and-no-file-identity
@vypbot

vypbot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Branch synchronized

develop was merged into bugfix/830-progress-partition-rejects-per-file-implemented-text-with-schema-string-long-and-no-file-identity and pushed as af7c2a2ad5cebb3c427eba7df9b54d06eddc0625.

The fixer resolved 9 conflicted files.

6 verification checks passed.

…schema-string-long-and-no-file-identity: Verify composed part and final progress recovery
@efraespada
efraespada merged commit e7720ee into develop Nov 2, 2026
13 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

90% Progress: 90% size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - Progress partition rejects per file implemented text with schema string long and no file identity

3 participants