Skip to content

Social UI polish: duplicate settings labels, Sharing layout, Create Bot back/default model, native Remove confirm, Auto-send label, account menu truncation #230

Closed

Description

@Birfy

Environment

Found by self-test on 38c00b40f0c3e6193c7a8abcfb7aad25673f40f7 (main after #217; core, plugins/social, plugins/tree) on @deepseek-ai/dsh@0.2.0-rc.2, Node 24. Two fresh installs on one Linux box: A :3080 (owner SelfA0333, @selfa0333.home, Bots Chief + Helper), B :3081 (owner SelfB0333, @selfb0333.home, Chief). Bot Social https://47-80-69-220.sslip.io. Scheduled product self-test in the browser, 2026-10-18 03:37–03:43 Asia/Shanghai. No model key in this run, so Bot replies were not tested. Screenshots were not saved; screens are described in text.

Items not already tracked in #173 / #197 / #182. Each is small; the theme is simplicity and consistency.

Bot settings (own Bot, e.g. Helper → Settings)

  • Duplicate labels. The Model card has a row labelled Model; the Main Bot card has a row labelled Main Bot. The heading is repeated as the row label. Drop one (e.g. keep the card title, show only the value and hint in the row). Code: core/src/client/bot-settings.js L225–246.
  • Sharing layout. Create another invite link sits above the link field, and three buttons crowd together (Create another invite link, Copy link, Copy with instructions). The Sharing heading is indented differently from the other section headings. Expected: link first, then one row with Copy link (primary) and a quieter "New link"; heading aligned with the others. Code: plugins/social/client.js ~L1482–1509.

Create Bot

  • Two back controls. The form has a top-left back arrow and a Back button at the bottom. Keep one. Code: core/src/client/create-bot.js L91 and L96.
  • Default model. The model defaults to DeepSeek-V41-Flash · DeepSeek · High, although the only provider configured on this box is Volcengine Ark (llm-pi-ai providers.ark) and DeepSeek has no credential. Hunch: startModel() (core/src/client/bot-draft.js) takes roster.defaultModel (the DSH default) first. Consider defaulting to the main Bot's model, or to a provider that has a credential.

Friend's Bot (gear dialog / remove)

  • Remove uses native confirm() ("Remove Helper? SelfA0333 can share it again."), unlike the inline confirms elsewhere (face-room Leave now asks inline). After confirming, nothing changes on screen for 3–15 s before the Bot disappears. Expected: inline confirm in the dialog, and the row disappears (or shows "Removing…") at once. Code: plugins/social/client.js ~L1444–1471.
  • Auto-send checkbox in the friend-Bot gear dialog is tiny, grey and low contrast, and only says Auto-send (tooltip "Don't ask each time."), without saying which pair it covers (e.g. "Auto-send Chief → Helper"). In face-room details it reads Auto-send Chief → room but is squeezed into the row (Face-to-face: avatars and room title differ per home (regressions of #137/#172); Leave is abrupt and not seen by the peer #182 left the row layout open).

Account menu

Mention only (tracked elsewhere)

Related

#173, #181, #182, #139 (Remove confirm), #166.

Activity

  1. Birfy commented on Oct 17, 2026

    @Birfy
    CollaboratorAuthor

    PR #232 (merged) covers part of this issue:

    • Model and Main Bot: the duplicate row labels are gone.
    • Create Bot: has one back control.
    • Account menu: is wide enough for "Switch to classic Agent mode".
    • Remove this Bot: asks inline (Remove / Keep) instead of the browser's confirm box.
    • Auto-send: reads Auto-send to <friend> and wraps when the name is long.
    • Sharing:
      • shows the link first, with Copy link as the only primary button and a quiet New link;
      • the heading is aligned with the core settings headings.

    Still open here:

    • Default model in Create Bot: this changes behaviour, so it should be its own change.
    • Browser check: the CSS-only items (heading inset, account menu width, the face-room Auto-send row layout) are covered by tests but haven't been checked in a browser yet.
  2. Birfy commented on Oct 18, 2026

    @Birfy
    CollaboratorAuthor

    Status against main 7a3ccb3: no change since the comment on #232 above.

    Still open: the default model in Create Bot. startModel() (core/src/client/bot-draft.js L12–15) still picks roster.defaultModel, the DSH default, before anything else.

    Expected: Create Bot starts with the main Bot's current model. If that model is gone, it falls back to roster.defaultModel, then to the first available model. It should never preselect a provider that has no credential.

    The CSS-only items (heading inset, account-menu width, face-room Auto-send row) still need a browser check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions