Skip to content

Social UI polish round 3: truncation, duplicate Add friend/Accept invite, Manage access depth, wording (#166 follow-up) #173

Closed
Closed
Social UI polish round 3: truncation, duplicate Add friend/Accept invite, Manage access depth, wording (#166 follow-up)#173

Description

@Birfy
Birfy
opened on Oct 17, 2026

From the 2026-10-17 UI test on main 8020074 (aesthetics, usability, simplicity, consistency). Screens kept on the smoke machine under test-176/.

Sidebar

  • Rows truncate hard: Helper · UiA1415's …, Face-to-face · UiA1415 · O…, Face-to-face · Ui… (allow two lines or shorten; keep the Friend's Bot marker readable).
  • Friend rows always show a gear while own bots show none; make it consistent (e.g. hover-only for both).
  • PAST ROOMS is all caps while other headers are sentence case.

+ menu (New…)

  • Menu takes over the whole pane and is titled New…; use a compact popover.
  • Add friend and Accept invite open the identical inline ADD FRIEND panel; merge into one entry (or make the panel mode-specific).
  • Mixed terms: Add Agent vs Create new Bot; pick one.

Add friend panel / dialogs

  • Placeholder cut off (Paste invite link or co…), orphan line (not shared unless you invite them to it).
  • Escape does not close the Add friend panel or the Face-to-face dialog.
  • Face-to-face dialog copy is long and the 000000 placeholder looks pre-filled.

Bot settings / Manage access

  • Manage access sits at the bottom of Edit Bot with no section header (Profile, Model etc. have one); two different controls are both labelled Manage.
  • Friend shown as Uib1415 (@uib1415.home) (odd capitalisation of the first letter).
  • Right-click menu has 12 items incl. Copy invite link and Copy invite with instructions; trim.
  • Invite a friend to Helper. Accepting the invite grants them Helper only. You can revoke that grant later. is wordy; shorten.

Misc

  • Empty chat with a friend's Bot has no empty-state hint.
  • Chief's default greeting is Chinese in the English UI (你好！我是 Chief…) in sidebar preview and chat.
  • Tab order puts approval buttons before the sidebar, one extra Tab stop focuses nothing; composer focus ring is faint.
  • Browser tab title stays Chief — FlyBot after switching chats.

Activity

  1. Birfy
    added 3 commits that reference this issue on Oct 17, 2026

    docs: describe social UI polish round 3 (ThinkFlowLab#173)

    d251208

    docs: drop Accept invite row from social doc (ThinkFlowLab#173)

    b353478

    fix(social): UI polish round 3 — fewer duplicate entries, tighter cop…

    f3d8727

  2. Birfy commented on Oct 17, 2026

    @Birfy
    Birfy
    on Oct 17, 2026
    CollaboratorAuthor

    Still seen on c3bb44f (after #176), self-test 2026-10-17 19:38 Asia/Shanghai: + still opens a full-width New… panel in the main pane (popover item still open here). Other + / Add friend / Sharing findings from that run are in #181.

  3. Birfy
    added a commit that references this issue on Oct 17, 2026

    fix(social): shorter + menu, own handle and per-Bot invite in Add fri…

    be3f234

  4. Birfy commented on Oct 17, 2026

    @Birfy
    Birfy
    on Oct 17, 2026
    CollaboratorAuthor

    Nits from the live resmoke on c56384a (not fixed in #189/#190/#191 work; for the polish round):

    • Own bubble is light grey while received bubbles are black: inconsistent.
    • The Chief sidebar preview was in Chinese while the UI is English (probably the Bot's first model message, not an i18n string; check the default language of the kickoff).
    • The members panel lists only Bots, not people.
    • Sharing is deep in the long Bot settings page (3 clicks + scroll).
    • The right-click menu has 12 items.

  5. Birfy commented on Oct 17, 2026

    @Birfy
    Birfy
    on Oct 17, 2026
    CollaboratorAuthor

    From the resmoke on 5ad978a: a shared Bot's sidebar avatar colour differs between the owner (orange, their local Bot look) and the receiver (blue, handle-seeded look because the published look is not synced). Needs the published look to reach the receiver (see #137/#84); not fixed in #196.

  6. Birfy commented on Oct 17, 2026

    @Birfy
    Birfy
    on Oct 17, 2026
    CollaboratorAuthor

    Self-test on 38c00b4 (2026-10-18 03:37–03:43 Asia/Shanghai, fresh A/B):

  7. Birfy commented on Oct 18, 2026

    @Birfy
    Birfy
    on Oct 18, 2026
    CollaboratorAuthor

    Status against main 7a3ccb3 (2026-10-18 ~10:30 Asia/Shanghai). Checked in code, plus the self-test on 38c00b4.

    Done

    • The gear on sidebar rows shows only on hover or focus, for every row (see docs/subsystems/core-client.md).
    • Past rooms is in sentence case.
    • + has a single Add friend entry. There is no separate Accept invite.
    • The Add friend placeholder now reads Paste invite link, and the orphan "(not shared unless…)" line is gone.
    • Escape closes the Add friend panel and the dialogs.
    • The invite copy is shorter: Invite grants <Bot> only. Revoke anytime in People with access.
    • An empty chat with a friend's Bot shows a one-line hint.
    • Chief's first greeting is in English.
    • The members panel lists people as well as Bots (fix(ui): face rooms put people first: person lines with avatar, person-first members and tiles (#229) #238).
    • Tab title stuck on Chief — FlyBot in a face room on the joiner's side: fixed in PR fix(ui): tab title follows a room the roster names after it opened (#173) #244. The title now also updates when the roster changes, not only when the session changes.

    Still open

    1. + opens a full-pane New… tab. Expected: a compact popover anchored to +. This also covers Social UI nits after #196 #197 item 3, now closed.
    2. Sidebar rows truncate or wrap. For example, Helper · SelfA0333's Bot plus the marker takes two lines. Expected: one line with a readable marker, the full name in a tooltip.
    3. Face-to-face dialog: the 000000 placeholder still looks pre-filled (plugins/social/client.js, room-number input). Expected: an empty field with a lighter hint such as 6 digits.
    4. The right-click menu still has both Copy invite link and Copy invite with instructions (plugins/tree/client.js). Expected: one Copy invite entry (Sharing already offers both).
    5. Sharing is still deep inside Bot settings.
    6. Own bubbles are light grey, while received bubbles are dark.
    7. A shared Bot's colour differs between the owner and the receiver. This needs the owner's look to be published to the receiver. Same root cause as Face-to-face: avatars and room title differ per home (regressions of #137/#172); Leave is abrupt and not seen by the peer #182 and A friend's Bot ignores the owner's chosen avatar: the same Bot looks different in each home (follow-up to #84) #137 / A friend's Bot renders a random per-record look: unstable on re-add, inconsistent with the no-record path, different in each home #84.
    8. Not re-checked this run: the tab order, the faint composer focus ring, and whether the two controls labelled Manage are still both there.
  8. Birfy
    added a commit that references this issue on Oct 18, 2026

    fix(ui): + menu is a popover next to +; one Copy invite entry; 6 digi…

    aca60a7

  9. Birfy commented on Oct 18, 2026

    @Birfy
    Birfy
    on Oct 18, 2026
    CollaboratorAuthor

    Status against main ab723ac (2026-10-18 ~12:45 Asia/Shanghai).

    Fixed by #265:

    • Item 1. + opens a small popover next to + (the pane behind stays visible). A click outside or Escape closes it.
    • Item 3. The room number field is empty with a light 6 digits hint.
    • Item 4. The right-click menu has one Copy invite link. Copy with instructions stays in Sharing.

    Still open here:
    2. Sidebar rows truncate or wrap (Helper · SelfA0333's Bot plus the marker takes two lines). Expected: one line with a readable marker, and the full name in a tooltip.
    5. Sharing is still deep inside Bot settings.
    6. Own bubbles are light grey while received bubbles are dark.
    7. A shared Bot's colour differs between the owner and the receiver. Same root cause as #182.
    8. Not re-checked yet: tab order, the faint composer focus ring, and the two Manage controls.

    New, seen while checking the popover: the + menu lists Timeline (with the people icon used for the plugin rows), while Timeline is also its own sidebar entry. Expected: + only creates or adds things (New chat, Create Bot, group, Face-to-face, Add friend, Add coding agent), and Timeline stays in the sidebar only.

  10. Birfy commented on Oct 18, 2026

    @Birfy
    Birfy
    on Oct 18, 2026
    CollaboratorAuthor

    Self-test on ab723ac (2026-10-18 12:27–12:31 Asia/Shanghai, fresh A :3090 / B :3091, focus: friend DM):

  11. Birfy commented on Oct 18, 2026

    @Birfy
    Birfy
    on Oct 18, 2026
    CollaboratorAuthor

    Status (2026-10-18 maintenance): Sidebar hover gear is now consistent for own and friends' Bots (#298 / d6d10ff). Still open from the last checklist: sidebar truncation/wrap, Sharing depth, bubble colour contrast, shared Bot colour sync (#182), and the unrechecked tab-order / focus-ring / dual Manage items.

  12. Birfy commented on Oct 18, 2026

    @Birfy
    Birfy
    on Oct 18, 2026
    CollaboratorAuthor

    Self-test on a003044 (2026-10-18 16:27–16:33 Asia/Shanghai, focus: Face-to-face room). Item 2 (sidebar truncation/wrap) is still present:

  13. Birfy commented on Oct 18, 2026

    @Birfy
    Birfy
    on Oct 18, 2026
    CollaboratorAuthor

    Self-test on 2c9853d, 2026-10-18 20:24 Asia/Shanghai. The Add friend paste box is still cut off in the sidebar: the placeholder reads Paste invite … and a pasted link shows as https://47-8…. That item and the other invite and accept UX gaps from this run are now in #343, so this issue can drop them:

    • inviting is hard to find;
    • the link is shown only in Sharing;
    • with one Bot, Copy invite link does not name the Bot;
    • nothing on screen lasts after Accept invite.

    The duplicate Add friend/Accept invite item is still fixed: + has a single Add friend entry.

  14. Birfy commented on Oct 18, 2026

    @Birfy
    Birfy
    on Oct 18, 2026
    CollaboratorAuthor

    Self-test on main 6d04db6 (#375), 2026-10-19 00:23–00:35 Asia/Shanghai: item 2 is still present (Helper · SelfB0023's / Bot wraps to two lines on A). It is now tracked with the other friend's-Bot row problems from this run (two name formats, no preview line, inset highlight, faint marker, avatar clash) in #384, so this issue can drop item 2. The + menu and right-click menu wording from this run is in #385.

  15. Birfy commented on Oct 19, 2026

    @Birfy
    Birfy
    on Oct 19, 2026
    CollaboratorAuthor

    Closing this round. Most items are fixed (see the status comments above). The remainder lives here:

    Please continue in those issues.

  16. Birfy
    closed this as completedon Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions