Repository navigation
Social UI polish leftovers from #173: Sharing depth, own bubble colour, tab order / focus ring / duplicate Manage #406
Description
Leftovers from #173 (Social UI polish round 3) that were not tracked in any other issue. Last status on main ab723ac (2026-10-18); not re-checked since, so verify before fixing.
- Sharing is deep in Bot settings. Edit Bot > Sharing sits at the bottom of a long page (about 3 clicks plus a scroll), with no section header like Profile and Model have.
- Own bubbles are light grey, received bubbles are dark. Make the contrast and styling consistent.
- Not re-checked: tab order (approval buttons come before the sidebar; one extra Tab stop focuses nothing), the faint composer focus ring, and whether two different controls are still both labelled
Manage.
Activity
Birfy commentedon Oct 19, 2026
Triage on main
7b9e90b, 2026-10-19 ~12:10 Asia/Shanghai: needs-info. Not re-checked sinceab723ac. Blocking: (1) bubble colours: which way should own vs received bubbles go (own darker/accent, received light, or both neutral)? (2) Sharing: only add a section header, or also move Sharing up in Edit Bot? (3) tab order / focus ring / duplicate Manage need a re-check on current main. A self-test or a short owner note can settle these.Birfy commentedon Oct 19, 2026
Triage on main
0852b3f, 2026-10-19 16:59 Asia/Shanghai. Checked against the code; I decided the minor points:Owner-delegated decisions
--bt-user(near-black with light text in light theme, near-white in dark theme). Received bubbles use the neutral--bt-bubble(light grey / dark grey). This is one rule in both themes: own = ink colour, received = neutral. The "own light grey, received dark" note was the dark theme.FlyBotDetailsinbot-settings.js) is drawn as a titled Sharing card, using the sameCardas Profile and Model. It moves up to sit right after Instructions (before Capabilities / Connectors / Memory). Social'sBotSocialDetailsdrops its ownfs-label"Sharing", so the title does not show twice.Manage: the two Memory rows (Manage→ memory, in Bot settings and in details) are the same action and stay. Group settings' danger card is titledManage, but Bot settings calls the same cardMore. Rename the group card to More for consistency.[data-composer-card]:focus-withinclearly visible (e.g. the border at about 55% ink instead of 30%). Hover stays as it is.Expected / scope:
core/src/client/bot-settings.js,core/src/client/group-settings.js,core/src/client/styles.js,plugins/social/client.js(BotSocialDetails), plus zh strings ini18n.jsand generatedcore/client.js/ patches. Tests: a source test for the card order, card title and focus style.Waiting on the owner: confirm this scope so the issue can be marked agent-ready. Label changed from
needs-infotoneeds-human.Birfy commentedon Oct 19, 2026
Owner decision (2026-10-19 17:21 Asia/Shanghai): approved the proposed scope. Bubble colours unchanged; Sharing becomes a titled card right after Instructions; group-settings "Manage" card renamed "More" to match Bot settings; stronger composer focus ring; keyboard tab order checked in a browser and fixed where it differs. Ready to develop.
Birfy commentedon Oct 19, 2026
Claimed by Birfy at 2026-10-19 17:22 Asia/Shanghai. Branch:
Birfy:issue-406-ui-polishoff upstream maind65e09d. Scope per the Owner decision: Sharing card after Instructions, group "Manage" card → "More", stronger composer focus ring, tab order check/fix. Bubble colours unchanged.Birfy commentedon Oct 19, 2026
PR #436 (2026-10-19 17:33 Asia/Shanghai). Minor details I decided:
分享.shell.overlay) is after the main column in the DOM, so approval buttons no longer come before the sidebar; no stop focuses an invisible element. No change needed. The message box comes before + because DSH's DOM has the input first (FlyBot CSS only moves + to the left visually); kept, since typing is the main action and changing it means changing DSH's DOM.Put Sharing in a titled card after Instructions, name the group's las…