Repository navigation
Invites are hard to make and accept: unnamed 'Copy invite link' in Add friend, link shown only in Sharing, cut-off paste box, no lasting result after Accept invite #343
Description
Summary
Making and accepting an invite is hard to follow. You have to know where invites are made. The link is usually not shown. The Add friend Copy invite link does not say which Bot it shares. The paste box is cut off. After Accept invite, nothing on screen says what happened.
Environment
- FlyBot main
2c9853d09633f5aadeb4fe97a28357553c64630d, dsh0.2.0-rc.2. - Fresh A
:3095(SelfA2018) and B:3096(SelfB2018), one Chief each. - Bot Social prod.
- Self-test, 2026-10-18 20:24–20:26 Asia/Shanghai.
Steps and what happens
- Making an invite. The + menu has New chat, Create new Bot, Create group chat, Face-to-face group, Add friend ("Paste an invite link or code."), and Add coding agent. None of them says it makes an invite. An invite is made only through:
- right-click a Bot > Copy invite link. The link goes straight to the clipboard, with the toast
Invite link for Chief copied, and is never shown; - Edit Bot > Sharing > Invite to this Bot. Only this path shows the link, in a read-only field with Copy link / Copy with instructions / New link;
- Add friend > Copy invite link (below).
- right-click a Bot > Copy invite link. The link goes straight to the clipboard, with the toast
- Add friend panel (on B). It reads:
Add friend [Done] / You are @selfb2018.home / [Copy invite link] / [Paste invite link…] [Accept invite].- With one Bot there is no Bot picker, so Copy invite link does not say which Bot it grants. The result
Invite link copied. Send it to a friend.does not name the Bot either. The picker appears only with more than one Bot. - A friend who opens Add friend to accept sees Copy invite link first, above the paste box.
- The paste box is cut off in the sidebar: the placeholder reads
Paste invite …, and a pasted link shows ashttps://47-8…. Screenshot: the Add friend panel in the sidebar, with the narrow paste field showinghttps://47-8…next to Accept invite.
- With one Bot there is no Bot picker, so Copy invite link does not say which Bot it grants. The result
- Accept invite. The toast flashes too fast to read, the panel closes, and nothing else changes on screen. The code sets the toast for 6 s (
TOAST_MS), so why it looked so short is not confirmed. In this run the join also failed to add the Bot (Accepting an invite never shows the inviter's Bot to the joiner, and the joiner's Chief lists the inviter in People with access (regression of #178 from #334) #342), and the toast claimedSelfA2018 shared a Bot with you.anyway.
Expected (design: simple copy, English only, a clear result after accepting)
- One obvious place to invite. For example, Add friend offers
Invite a friend to <Bot>with the Bot named (a picker when there are several), or a Bot's right-click item names the Bot (Copy invite link for Chief). - Show the link that was copied, at least once, so it can be checked or copied by hand.
- In Add friend, accepting comes first: the paste box and Accept invite come first, and inviting is a separate, named line.
- The paste box fits the sidebar, so the placeholder and the start of the link are readable.
- A result that stays:
- After Accept invite, open or highlight the new friend's Bot row, which has the small friend's-Bot marker. Or keep the panel open with
SelfA2018 shared Chief with you.until Done. - Never say "shared a Bot with you" when no Bot arrived. Instead say what happened, for example
Joined SelfA2018's invite, but their Bot didn't load. Try again.
- After Accept invite, open or highlight the new friend's Bot row, which has the small friend's-Bot marker. Or keep the panel open with
- Copy stays short. No new buttons beyond what replaces the above.
Related
#173 (polish round; the placeholder was shortened there, but the box is still cut off), #181, #195 (the panel closes after accept and relies on the toast), #228, #310, #330 (the same "copied, link never shown" pattern for room invites), #342.
Activity
fix(social): keep the accepted-invite result when the friend-list ref…
Birfy commentedon Oct 18, 2026
Self-test on main
6d04db6(#375), 2026-10-19 00:23–00:35 Asia/Shanghai, fresh A:3090(SelfA0023, own Bots Chief + Scratch). Accept-first order and a namedInvite a friend to <Bot>line are now in, but the panel has new layout problems.Add friend panel on A (opens inline in the sidebar), top to bottom:
Donebutton, above all the contentYou are @selfa0023.homePaste invite link or codebox, thenAccept inviteTalk through [Chief ▾]C…, next toInvite a friend to ChiefScreenshot: the narrow sidebar panel with Done at the top, the paste box and Accept invite,
Talk through [Chief ▾], and below it a tinyC…dropdown next to theInvite a friend to Chiefbutton.What is wrong:
Talk through, for accepting), the other is unlabelled and cut off toC…(which Bot to invite to). It is not clear which picker does what. The second one also repeats what the button text already says.Expected (simplicity, short click paths): accept and invite as two clearly separate groups, each with its own label; the invite picker readable (full Bot name) or merged into the button (
Invite a friend to [Chief ▾]); Done at the bottom (or just ✕ / Escape in the header).Birfy commentedon Oct 19, 2026
Maintenance check on main
0e72bb8(2026-10-19): still valid. Accept-first / named invite line landed earlier; self-test notes on Add friend panel layout remain. Further invite UX needs clear expected behavior from the owner before a fix PR — not inventing product decisions this run.Birfy commentedon Oct 19, 2026
Owner decision (2026-10-19): Approved as proposed in the issue (Expected section, plus the recommendation already in the comments: accept and invite as two separate labelled groups, readable Bot picker or merged into the button, Done at the bottom or ✕ / Escape). Still needs triage /
agent-readybefore a fix PR.Birfy commentedon Oct 19, 2026
Triage on main
7b9e90b, 2026-10-19 ~12:10 Asia/Shanghai: design conflicts resolved, spec clear; ready to develop. Checked: owner decision of 2026-10-19 above (approved as proposed), the design rules (one top + menu, simple short copy, English UI), and #181/#195/#228/#310. On main already: accept-first order, named invite button, link shown once made, honest result that stays. Still to do: accept and invite as two separate labelled groups, a readable Bot picker for the invite (not an unlabelledC…), and Done at the bottom (Escape already closes).Birfy commentedon Oct 19, 2026
Claimed by the maintenance routine: working on branch
fix/343-add-friend-groupsin Birfy/FlyBot (two labelled groups, readable invite Bot picker, Done at the bottom).Add friend: the Share picker's tooltip holds the whole Bot name (Thin…
Restore both directions when a re-invite is accepted (ThinkFlowLab#1000…