Skip to content

Friend's Bot rows: two name formats ('Helper · SelfB0023's Bot' vs 'SelfA0023's Chief'), two-line wrap, no preview, inset highlight, faint marker, same avatar as own Chief #384

Closed

Description

@Birfy

Summary

A friend's Bot looks different from my own Bots in the sidebar, and differently on each home. It is named in two formats, wraps to two lines, has no preview line, its highlight does not line up with own rows, its marker is hard to see, and it can have the same avatar as one of my own Bots.

Environment

  • FlyBot main 6d04db6682fa87033e58a176121f878b3ba293ce (About FlyBot describes FlyBot: its repository, stars, links, build and update text #375), core + plugins/social + plugins/tree on @deepseek-ai/dsh@0.2.0-rc.2, Node 24.
  • Two fresh installs on one Linux box: A :3090 (owner SelfA0023, @selfa0023.home, own Bots Chief + Scratch) and B :3091 (owner SelfB0023, @selfb0023.home, own Bots Chief + Helper). Bot Social prod https://47-80-69-220.sslip.io.
  • Setup: A made an invite for A's Chief, B joined it with B's Chief. Then B made an invite for Helper, A joined it with A's Chief. So A sees friend's Bot Helper, B sees friend's Bot Chief (A's).
  • Product self-test, focus D (Social list and + menu), 2026-10-19 00:23–00:35 Asia/Shanghai. Screenshots stayed on the test machine; what they show is written out below.

Repro

  1. Set up A and B as above (A sees B's Helper, B sees A's Chief).
  2. Look at the sidebar on A and on B at 100% zoom. Hover and select the friend's Bot row and an own Bot row.
  3. Open the friend's Bot chat and read the chat header.
  4. Repeat on B at 150% browser zoom.

Actual

Screenshots:

  • A sidebar: Chief and Scratch rows with name + grey preview; below them the friend row Helper · SelfB0023's / Bot on two lines, no preview, a small faint globe, and a hover band narrower than the own rows.
  • B sidebar: own Chief and Helper with previews; friend row SelfA0023's Chief with no preview and the same blue fish avatar as B's own Chief.
  • B at 150% zoom: the friend row's selected background is visibly inset from the sidebar edges and offset from the own rows above it.

Expected (consistency, aesthetics, simplicity)

Related

#173 (item 2 truncation, item 7 colour sync), #182, #377, #260 (naming rule), #305 (Bot named 4 ways in face rooms).

Activity

  1. Birfy commented on Oct 18, 2026

    @Birfy
    CollaboratorAuthor

    Part of this is in #389 (sidebar row: name + owner on one line, no two-line wrap, preview or Friend's Bot as second line, readable globe, full title on hover). Still open here: one short format in the chat header / picker / approval cards (touches face-room alias routing, #305), the hover band inset at 150% zoom, and a friend's Bot never showing the exact avatar of one of my own Bots.

  2. Birfy commented on Oct 19, 2026

    @Birfy
    CollaboratorAuthor

    Maintenance on main 0e72bb8 (2026-10-19): opening a small follow-up PR for (1) full-width hover/selected band on wrapped Bot rows (gear no longer shrinks the highlight; should clear the 150% zoom inset vs own rows) and (2) a friend's Bot fallback look never matching the exact shape+color of one of your own Bots until real look sync.

    Still not touching this run: one short name format in chat header / picker / approval cards (needs alias routing judgment with #305).

  3. added
    bugSomething isn't working
    area:socialFriends, invites, grants, Bot Social
    area:uiWeb/desktop UI and copy
    self-testFiled by the product self-test routine (issues only)
    needs-humanThe agent loop stopped; a person must decide (reason in the last comment)
    on Oct 19, 2026
  4. Birfy commented on Oct 19, 2026

    @Birfy
    CollaboratorAuthor

    Triage on main 7b9e90b, 2026-10-19 ~12:10 Asia/Shanghai: needs-human. Landed: one-line sidebar row with owner and preview (#389), full-width hover and a fallback avatar that never matches one of your own Bots (#402). Still open: one short name format for a friend's Bot in the chat header, @ picker and approval cards, the same in every place and on both homes. Question for the owner: which format? Options: (a) Helper · SelfB0023 like the sidebar row, (b) Helper with SelfB0023 as a second line where there is room, (c) Helper (SelfB0023). Also: drop the <owner>'s Chief special case? Same question blocks #305.

  5. Birfy commented on Oct 19, 2026

    @Birfy
    CollaboratorAuthor

    Owner decision (2026-10-19): a friend's Bot is displayed as Helper (SelfB0023) (Bot name followed by the owner's name in parentheses; option (c)), the same everywhere (chat header, @ picker, approval cards, both homes).

    Still open here: whether to drop the <owner>'s Chief special case. Not decided in this comment. needs-human stays.

  6. Birfy commented on Oct 19, 2026

    @Birfy
    CollaboratorAuthor

    Owner decision (2026-10-19):

    1. Drop the <owner>'s Chief special case. A friend's Chief uses the same format as every other friend Bot: Chief (OwnerName).
    2. DSH Session row in the face-to-face @ menu: filter it out inside FlyBot now. We should also ask DSH for an API to exclude it. Nothing is filed in a DSH repo yet.

    Together with the earlier decision (Helper (SelfB0023)), all open questions in this issue are resolved, so needs-human is removed. Not marked agent-ready; maintenance triage decides.

  7. removed
    needs-humanThe agent loop stopped; a person must decide (reason in the last comment)
    on Oct 19, 2026
  8. Birfy commented on Oct 19, 2026

    @Birfy
    CollaboratorAuthor

    Self-test on main a7f51e8 (#416), 2026-10-19 12:38 Asia/Shanghai, focus A Friend DM (fresh A :3090 SelfA1238 / B :3091 SelfB1238; A's Chief shared to B, B talks through its Chief). For the decided format (Chief (SelfA1238), no <owner>'s Chief special case), these places on current main still use other names for the same Bot:

    On B (A's Chief as a friend's Bot):

    • Sidebar row: Chief + grey SelfA1238 + globe; subtitle Friend's Bot before the first message (closest to the decided format, but not Chief (SelfA1238)).
    • Row accessible name/tooltip, chat header pill, browser tab title (SelfA1238's Chief — FlyBot) and composer placeholder (Message SelfA1238's Chief): still the <owner>'s Chief special case.
    • Friend's Bot settings sheet: only the handle @chief.selfa1238.home under the title.

    On A (approval card for A's Chief's held reply to B): Chief → Chief. The right side is B's talk-through Bot; it should name the person (Chief → SelfB1238), or, where a friend's Bot is meant, Chief (SelfB1238). Details in #418 (card) and #417 (Always approve toast).

    Code still carrying the old formats (read-only check at a7f51e8): core/src/shared/remote-label.js L89–99 (remoteBotTitle, <owner>'s Chief / <Bot> · <owner>'s Bot; also bundled in core/client.js L1362 and patches/ds-bot/files/src/shared/remote-label.js), core/src/client/flybot-slots.js L198, plugins/social/client.js L975–982 and L325, core/src/host/room-membership.js L230 (face members), and holdParties in plugins/social/client.js L870 for cards.

    Acceptance addition: grep for 's Chief / 's Bot user-facing strings returns none outside tests and the model-facing alias parser (faceAliases, hooks.js L957), and every place above shows Chief (SelfA1238).

  9. 1 remaining item

  10. added
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    on Oct 19, 2026
  11. self-assigned this
    on Oct 19, 2026
  12. Birfy commented on Oct 19, 2026

    @Birfy
    CollaboratorAuthor

    Claimed by the maintenance routine (2026-10-19 ~15:00 Asia/Shanghai): working on branch Birfy:fix/384-friend-bot-name (one PR for #384 and #305).

  13. removed
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    on Oct 20, 2026
  14. removed
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    on Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:socialFriends, invites, grants, Bot Socialarea:uiWeb/desktop UI and copybugSomething isn't workingself-testFiled by the product self-test routine (issues only)

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions