Skip to content

Polish: Tool added/removed lines every turn, Chief self-intro wording differs, friend's Bot offered as a Main Bot, gear hover inconsistent #276

Closed

Description

@Birfy

Summary

Small polish items from the friend-DM self-test (aesthetics, simplicity, consistency).

Environment

Items

  1. Tool added / Tool removed lines repeat every turn. Both chats get system lines like Tool added: create_child_bot · Tool added: list_children and then Tool removed: …, again and again. Expected: no tool-mask noise in a person's chat. Chat shows raw 'Tool removed: ask_user_question' cell (remainder of #140; DSH core cell) #140 already hid Tool removed: ask_user_question for the same reason.
    Hunch (code, not verified): hidePluginTools() (core/src/host/hooks.js L651–667) computes known from ctx.tools.schemas(agent). Once restrict({ deny }) has hidden the tree tools (visibleTo: inTree, plugins/tree/src/tools.js L48/61), they may no longer be in schemas, so the next resolve computes deny = [], drops the mask (Tool added), and the one after that denies again (Tool removed). That would flip on every delivery. ContextCell (core/src/client/cells.js L533) shows every tool change except ask_user_question.
  2. The two Chiefs introduce themselves differently: A says "your Main Bot", B says "your Chief of Staff". The system prompt says ## You are the Main Bot (Chief of Staff) (core/src/host/prompt.js L26). Use one term (the UI says Main Bot).
  3. Settings → Bots → "Add a Main Bot" offers "Chief" when Chief is already the only Main Bot. Hunch: on B, roster.bots also has the friend's Bot (SelfA1220's Chief, also named Chief), and MainBotsSection (core/src/client/settings.js L75 candidates, and L84 for the Main Bot select) does not filter out bot.remote. So a friend's Bot would be offered as a Main Bot under a bare name that looks like my own. The first-Main-Bot select (L84) lists roster.bots without that filter too.
  4. Gear on hover is inconsistent. On A, hovering my own Chief row shows no gear. On B, a friend-Bot row shows a gear. Social UI polish round 3: truncation, duplicate Add friend/Accept invite, Manage access depth, wording (#166 follow-up) #173 says the gear should show on hover or focus for every row.

Expected

English-only, short, consistent wording. No repeated system noise. Only my own Bots can be picked as a Main Bot. The same hover affordance on every row.

Related: #140 (tool-removal cell), #173 (polish round 3).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions