Skip to content

Aggregator: wire Pad as a real source (notes on items) or remove the planning-notes feature #1202

Closed

Description

@dezren39

Part of epic #1184 (PM stack coherence review, 2026-10-26).

Pad is not integrated: planning notes exist only in fixtures. Evidence: source.ts has no Pad facet and live.ts never sets BoardItem.notes; the only notes are fixtures.ts:135 pointing at http://127.0.0.1:7777/. A deployed layer (Pad 7777) contributes nothing while item pages reserve an empty 'Planning notes' section in production.

Acceptance:

  • A live item with a Pad plan shows it with a reachable (non-loopback) URL, or the section is deleted and Pad is recorded as standalone in the docs.
  • Pad outage degrades per the degraded-facet rules.
  • /health includes Pad.

Acceptance criteria

  • A live item with a Pad plan shows it with a reachable (non-loopback) URL — or the 'Planning notes' section is deleted and Pad is recorded as standalone in the docs.
  • A Pad outage degrades per the degraded-facet rules.
  • /health includes the Pad facet.

Activity

  1. added
    kind/featureNew feature or capability request
    priority/normalOrdinary priority (the default)
    app/pm-stackpm-stack (Pad/Grist) in developing-today/code
    on Oct 27, 2026
  2. developing-today commented on Oct 27, 2026

    @developing-today
    Contributor
  3. added
    source/humanFiled directly by a human
    effort/mMedium: expected under 1 day of work
    meta/enrichedIntake review done: acceptance criteria, links, and normalized labels added
    on Oct 28, 2026
  4. dezren39 commented on Oct 28, 2026

    @dezren39
    MemberAuthor

    Intake review — fleet monitor

    Liveness: Verified still live at intake (2026-10-28): issue is open and unheld, and a merged-PR search for #1202 returned only unrelated text matches (no PR title or fix reference resolves this item). Part of epic #1184 (PM stack coherence review, 2026-10-26); sibling batch #1210–#1222 was enriched in the previous monitor run.

    Notes: Deliberately either/or: wiring Pad in or removing the dead section are both acceptable outcomes; leaving the fixture-only section in production is not. /health inclusion applies on the wire-in path.

    Risks: Scope creep across the pm-stack pages is the main risk for this batch; the acceptance criteria above (converted from the issue's original Acceptance list) bound the work. CI on the aggregator's render/derive tests is the verification surface.

    Suggested approach: Take the acceptance criteria in order; keep the JSON twins in lockstep with the HTML pages, per the batch convention.

    Labels normalised this pass: source/human (coherence-review filer), effort/m, meta/enriched; existing kind/priority/status/app labels kept.

  5. added
    work/assignedQueue worker lifecycle state
    queue/claimedQueue worker lifecycle state
    and removed on Nov 1, 2026
  6. 17 remaining items

  7. added
    queue/queuedHas a queued task in the Supabase agent queue
    task/triageQueue packet kind: verify, reproduce, and route this item
    on Nov 3, 2026
  8. dezren39 commented on Nov 3, 2026

    @dezren39
    MemberAuthor

    agent-note:v1
    state: triaged (coverage pass)
    Coverage pass 2026-11-03: reviewed in the fleet-wide per-issue pass (drift / overlap / already-handled / stale / blockers / ordering). Verdict: still live; queued in repo-health-code-pilot as triage at priority 40 (priority/normal). If this is already handled at current main, the triage closes it with evidence; if it needs splitting, the triage files the split.
    Found via: coverage pass 2026-11-03

  9. added
    work/assignedQueue worker lifecycle state
    queue/claimedQueue worker lifecycle state
    and removed
    queue/queuedHas a queued task in the Supabase agent queue
    on Nov 3, 2026
  10. dezren39 commented on Nov 3, 2026

    @dezren39
    MemberAuthor

    agent-note:v1
    task: 7654
    state: picked_up
    lane: code-e (direct)
    summary: Triage of #1202 (wire Pad as a real aggregator source or remove the planning-notes feature) started by queue task 7654. Verifying the packet's evidence claims against current main before posting the verdict.

  11. dezren39 commented on Nov 3, 2026

    @dezren39
    MemberAuthor

    agent-note:v1
    task: 7654
    state: triaged — already handled, closing
    lane: code-e (direct)
    verdict: The removal branch of this either/or issue was implemented and merged in PR #3946 (queue task 4906); this issue stayed open only because that PR carried no closing keyword. Closing with evidence.

    Evidence (current main d4d7834, 2026-11-03; PR #3946 MERGED 2026-11-02T15:46:40Z, commit 05d90f1 verified an ancestor of origin/main):

    • BoardItem has no notes field (pm-stack/aggregator/src/model.ts:144-166) — the fixture-only Pad notes plumbing was removed from model, fixtures, render, and server by commit 05d90f1.
    • No 'Planning notes' section exists anywhere in pm-stack/aggregator/src — the reserved empty section is deleted.
    • No loopback note URLs remain in fixtures (the only 127.0.0.1:7777 references left are Pad's own service config: src/config.ts:162 PM_AGG_PAD_URL default and topology registration, which the PR deliberately kept).
    • Pad is recorded as standalone in the docs, per the acceptance OR-branch: pm-stack/README.md — "the aggregator reads no Pad data — Pad is the planning layer only", with the per-facet Capability provenance matrix in pm-stack/aggregator/README.md naming Pad's status honestly.
    • The remaining acceptance criteria belonged to the wire-in branch that was not taken: with no Pad facet in the aggregator there is nothing to degrade per the degraded-facet rules, and Pad's health/registration lives in the topology/service-link surfaces that PR fix(aggregator): remove fixture-only Pad item notes (#1202) #3946 explicitly left untouched.

    If Drew later wants Pad wired in as a real source after all, that is a new feature issue — this one is resolved by the removal it offered as the alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

app/pm-stackpm-stack (Pad/Grist) in developing-today/codeeffort/mMedium: expected under 1 day of workkind/featureNew feature or capability requestmeta/enrichedIntake review done: acceptance criteria, links, and normalized labels addedpriority/normalOrdinary priority (the default)source/humanFiled directly by a humantask/triageQueue packet kind: verify, reproduce, and route this item

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions