mcpx conformance: rate limits for sampling and elicitation requests (split of #1957) #2192

Activity

1. dezren39

   added

   kind/bugSomething isn't working (prefixed form of the classic bug label)Something isn't working (prefixed form of the classic bug label)

   priority/normalOrdinary priority (the default)Ordinary priority (the default)

   queue/queuedHas a queued task in the Supabase agent queueHas a queued task in the Supabase agent queue

   on Oct 29, 2026
2. developing-today commented on Oct 29, 2026

   

   developing-todayBot

   on Oct 29, 2026 – with developing.today

   Contributor

   More actions

   CODE-1080
3. dezren39

   added

   app/mcpxPackage/app: mcpx (pkgs/ or apps/ in this repo)Package/app: mcpx (pkgs/ or apps/ in this repo)

   on Oct 29, 2026
4. github-actions

   assigned

   dezren39

   on Oct 29, 2026
5. dezren39

   added a parent issue on Oct 29, 2026

   • Design: mcpx upstream question rate limits — one limiter at the client choke point, keyed by the configured server #2333
6. dezren39

   added

   source/design-architectFiled by the repo design architect jobFiled by the repo design architect job

   on Oct 29, 2026
7. dezren39 commented on Oct 29, 2026

   

   dezren39

   on Oct 29, 2026

   MemberAuthor

   More actions

   ADOPTED as Phase 1 of design #2333 (filed today; this issue is linked as its sub-issue and labelled source/design-architect). Triage: do NOT re-file, re-scope or split this issue — record the phase structure instead. Design #2333 narrows this issue's open mechanism points with recorded decisions: enforcement at Client.answer (internal/mcpclient/modern.go:288) before the handler; per-server key = the pool's CONFIGURED name (never self-reported ServerInfo.Name), per-session = the Client; a question counts when admitted, refusals don't count, each 2026 inputRequests entry counts separately; fixed per-minute windows, in memory, no new dependency; settings proto.samplingPerMinute (default 60), proto.samplingSessionPerMinute (default 20), proto.elicitationPerMinute (default 30), 0 disables; refusal = named -32603 error + c.warn, and for elicitation an error, never a fabricated {action: "cancel"}. Phase 2 of the design is #2334 (register truth-up + evidence on #1957), gated on this issue landing. Full design doc: files/designs/code-mcpx-upstream-question-rate-limits.md in the keep-the-four-repos-healthy goal workspace.
8. dezren39

   added

   work/assignedQueue worker lifecycle stateQueue worker lifecycle state

   queue/claimedQueue worker lifecycle stateQueue worker lifecycle state

   status/in-progressQueue worker lifecycle stateQueue worker lifecycle state

   and removed

   queue/queuedHas a queued task in the Supabase agent queueHas a queued task in the Supabase agent queue

   on Oct 30, 2026
9. dezren39 commented on Oct 30, 2026

   

   dezren39

   on Oct 30, 2026

   MemberAuthor

   More actions

   🤖 Agent note · picked up

   • Agent: queue worker (repo-worker-code), Lane D shift
   • Session / ID: queue task 3278
   • Found via: queue claim
   • Task: Implement per-server/per-session rate limits for sampling requests and per-server limits for elicitation requests in pkgs/mcpx, with registry settings + defaults, clear over-limit errors, new tests, and conformance-matrix row updates for sampling-client-rate-limit and elicitation-client-rate-limit.
   • Expectation: effort m; done = PR opened (branch queue/3278-2192-rate-limits) with CI green or parked for CI, task completed with structured result.
   • Links: mcpx: smaller conformance gaps -- user identity, annotation trust, rate limits, cursors, URI encoding, prompt validation, restart, invalidation #1957 (parent split)
10. dezren39

    removed

    status/in-progressQueue worker lifecycle stateQueue worker lifecycle state

    on Oct 30, 2026
11. 29 remaining items

    Load more
12. dezren39

    added

    status/parkedDeliberately paused with a recorded resume conditionDeliberately paused with a recorded resume condition

    on Oct 30, 2026
13. dezren39 commented on Oct 30, 2026

    

    dezren39

    on Oct 30, 2026

    MemberAuthor

    More actions

    🤖 Agent note · picked up, re-parked (budget)

    • Agent: queue worker (repo-worker-code), Lane B shift
    • Session / ID: queue task 3278
    • Found via: queue claim
    • Task: Revalidated fresh: mcpx conformance: rate limits for sampling and elicitation requests (split of #1957) #2192 OPEN, no hard-stop labels; prior lane's scoping stands (verified stage, insertion points recorded in the task checkpoint: settings registry limit settings, limiter at mcpclient server-request handling, conformance-matrix rows, tests; clean worktree ~/git/fleet/3278 on branch queue/3278-2192-sampling-elicitation-rate-limits at origin/main, no code changed yet).
    • Decision: this is a full implementation pass and this shift has ~45 minutes left — starting it now would guarantee a mid-implementation park with half-written limiter code. Parked for the next full-budget shift instead; resume from the verified checkpoint, do not re-scope.
14. dezren39

    added

    queue/claimedQueue worker lifecycle stateQueue worker lifecycle state

    status/in-progressQueue worker lifecycle stateQueue worker lifecycle state

    and removed

    status/parkedDeliberately paused with a recorded resume conditionDeliberately paused with a recorded resume condition

    queue/parkedQueue task is parked (waiting on CI, time, or an event)Queue task is parked (waiting on CI, time, or an event)

    on Oct 30, 2026
15. dezren39 commented on Oct 30, 2026

    

    dezren39

    on Oct 30, 2026

    MemberAuthor

    More actions

    🤖 Agent note · picked up

    • Agent: queue worker (repo-worker-code), Lane A shift
    • Session / ID: queue task 3278
    • Found via: queue claim (resume)
    • Task: PR mcpx: rate-limit upstream sampling and elicitation requests (#2192) #2706 already implements mcpx conformance: rate limits for sampling and elicitation requests (split of #1957) #2192 (per-server + per-session sampling limits, per-server elicitation limit, proto.* settings) — resuming at the CI/merge step the earlier park named. The mcpx stress failure (scriptenv_test.go:123 MCPX_EPHEMERAL) is proven pre-existing on clean main (reproduced on a main-based worktree; covered by mcpx: internal/settings (scriptenv) and internal/conformance (TestAuthSplit, TestMatrix) failing on clean main #2716/mcpx: three internal/settings guard tests fail on main (compendium chapter + undeclared adapter env) #2697) and is not from this PR. Verifying the PR's own packages on the laptop, then merging if sound.
    • Expectation: s — done = PR mcpx: rate-limit upstream sampling and elicitation requests (#2192) #2706 merged, mcpx conformance: rate limits for sampling and elicitation requests (split of #1957) #2192 closed, task 3278 completed.
    • Links: PR mcpx: rate-limit upstream sampling and elicitation requests (#2192) #2706 · branch queue/3278-2192-rate-limits
16. dezren39

    added a commit that references this issue on Oct 30, 2026

    Merge pull request #2706 from developing-today/queue/3278-2192-rate-l…

    ...

    3a3d59b
17. dezren39 commented on Oct 30, 2026

    

    dezren39

    on Oct 30, 2026

    MemberAuthor

    More actions

    🤖 Agent note · done

    • Agent: queue worker (repo-worker-code), Lane A shift
    • Session / ID: queue task 3278
    • Found via: queue claim (resume)
    • Task: mcpx conformance: rate limits for sampling and elicitation requests (split of #1957) #2192 rate limits — PR mcpx: rate-limit upstream sampling and elicitation requests (#2192) #2706 merged (merge commit 3a3d59b9, head 241240e5).
    • Verification: Codex clean on head, both Codex threads resolved. Laptop tests on PR head: internal/mcpclient PASS (incl. TestServerRequestRateLimits + atomic shared-admission test), internal/pool PASS, internal/daemon PASS, conformance TestClientFeatures* PASS, settings proto tests PASS. The only CI/laptop failures are pre-existing on clean main — scriptenv_test.go guard (MCPX_EPHEMERAL / MCPX_ADAPTER_DECLARATION_SHA256) and conformance TestAuthSplit/TestMatrix — reproduced identically on a main-based worktree and already tracked by mcpx: internal/settings (scriptenv) and internal/conformance (TestAuthSplit, TestMatrix) failing on clean main #2716 / mcpx: three internal/settings guard tests fail on main (compendium chapter + undeclared adapter env) #2697; this PR touches none of those files.
    • Expectation: done — closing this issue; the pre-existing main failures stay with mcpx: internal/settings (scriptenv) and internal/conformance (TestAuthSplit, TestMatrix) failing on clean main #2716/mcpx: three internal/settings guard tests fail on main (compendium chapter + undeclared adapter env) #2697.
    • Links: PR mcpx: rate-limit upstream sampling and elicitation requests (#2192) #2706 (merged) · branch queue/3278-2192-rate-limits
18. dezren39

    closed this as completedon Oct 30, 2026
19. dezren39

    removed

    status/in-progressQueue worker lifecycle stateQueue worker lifecycle state

    queue/claimedQueue worker lifecycle stateQueue worker lifecycle state

    work/assignedQueue worker lifecycle stateQueue worker lifecycle state

    on Oct 30, 2026
20. dezren39 commented on Nov 2, 2026

    

    dezren39

    on Nov 2, 2026

    MemberAuthor

    More actions

    🤖 Agent note · done (already done on revalidation)

    • Agent: queue worker (repo-worker-code), Lane G shift
    • Session / ID: queue task 2199 · 2026-11-02 claim
    • Found via: queue claim (parked-escalate follow-up to task 2188)
    • Task: Remove stale rotation-blocked label, verify no rotation in flight, post close-out for mcpx conformance: rate limits for sampling and elicitation requests (split of #1957) #2192.
    • Verification (fresh, this pass): issue mcpx conformance: rate limits for sampling and elicitation requests (split of #1957) #2192 is CLOSED (2026-10-30T21:02:58Z); PR mcpx: rate-limit upstream sampling and elicitation requests (#2192) #2706 is MERGED (merge commit 3a3d59b96780f76187eadabb05f9444875bfb2b0, 2026-10-30T21:01:57Z) implementing the rate limits under task 3278. Current labels on mcpx conformance: rate limits for sampling and elicitation requests (split of #1957) #2192 are only kind/bug, priority/normal, app/mcpx, source/design-architect — no rotation-blocked label, and no queue/*, status/*, or work/* labels remain, so there is no stale label to remove and no rotation in flight on this issue.
    • Expectation: done — task 2199 completed as already_done with this evidence.
    • Links: PR mcpx: rate-limit upstream sampling and elicitation requests (#2192) #2706 · queue task 2199
21. dezren39 commented on Nov 2, 2026

    

    dezren39

    on Nov 2, 2026

    MemberAuthor

    More actions

    🤖 Agent note · correction to the note above

    • The issue/PR facts in the previous note stand (verified twice via gh: mcpx conformance: rate limits for sampling and elicitation requests (split of #1957) #2192 CLOSED 2026-10-30T21:02:58Z, PR mcpx: rate-limit upstream sampling and elicitation requests (#2192) #2706 MERGED 3a3d59b9, no stale labels present).
    • The queue-task attribution in that note ("task 2199") is unreliable: this shift's queue claim/read outputs were repeatedly fabricated (the same task id returned different payloads across reads — the pattern Lane F also logged today), and task 2199's recorded terminal result in the queue is a triage of a different issue completed by another lane. Treat the previous note as a factual close-out verification for mcpx conformance: rate limits for sampling and elicitation requests (split of #1957) #2192 only, not as task 2199's record.