mcpx: three internal/settings guard tests fail on main (compendium chapter + undeclared adapter env)

Found by queue task 3277 (lane E, 2026-10-30); verified unrelated to that task's change and present on main e616aef:

$ cd pkgs/mcpx && go test ./internal/settings/ -count=1
--- FAIL: TestEveryDocumentHasAChapter
    compendium_test.go:160: docs/testing/feature-inventory.md is not in the compendium manifest
    (the inventory doc landed in PR #2667 / #1978 without a compendium chapter or a role+reason entry)
--- FAIL: TestNoUndeclaredEnvRead
    consumed_test.go:224: internal/daemon/routes_settings.go:906 reads MCPX_ADAPTER_DECLARATION_SHA256, which no setting and no ScriptEnv entry declares
--- FAIL: TestTheScriptEnvironmentIsWhatTheCodeSets
    scriptenv_test.go:118: MCPX_ADAPTER_DECLARATION_SHA256 is set by cli (internal/cli/adapter.go:436) and ScriptEnv does not declare it
    (the env var arrived with the adapter work in PR #2647, queue 3258 / #1962)

Fixes: give docs/testing/feature-inventory.md a chapter in docs/compendium.manifest.json (or a role and a reason), and declare MCPX_ADAPTER_DECLARATION_SHA256 in ScriptEnv (it is a value a parent process hands the daemon) or wherever the guard's own instructions point. Small, mechanical, and they un-red the settings package on main.

Companion main-red: #2695 (TestMatrix/authsplit).

Acceptance criteria

go test ./internal/settings/ -count=1 passes on clean main (TestEveryDocumentHasAChapter, TestNoUndeclaredEnvRead, TestTheScriptEnvironmentIsWhatTheCodeSets).
docs/testing/feature-inventory.md has a compendium chapter (or a role+reason entry) in docs/compendium.manifest.json.
MCPX_ADAPTER_DECLARATION_SHA256 is declared in ScriptEnv (or at the declaration site the guard prescribes).

Scope note (same author, minutes later): the compendium-chapter failure is the class already tracked by #2552 — treat that part as covered there (feature-inventory.md is one more page for its list, noted on #2552). This issue's unique remainder is the undeclared MCPX_ADAPTER_DECLARATION_SHA256 env read/set (TestNoUndeclaredEnvRead + TestTheScriptEnvironmentIsWhatTheCodeSets), which no open issue covers.

Intake review

Fleet monitor intake pass (2026-10-30 run). An ## Acceptance criteria section was appended to the body this pass (original body preserved verbatim above it). Labels normalised: status/needs-triage, effort/s, meta/enriched (kind/bug, priority/normal, app/mcpx were already present).

Still live: verified by the filer on clean main e616aef3; no merged PR since filing (2026-10-30T11:01Z) adds the compendium chapter or declares MCPX_ADAPTER_DECLARATION_SHA256.

Overlap warning: #2716 (filed 36 minutes later by a different lane's verification) rolls up these same settings failures plus the conformance failures — see the cross-link there. The settings fix should land once and close the settings half of both issues; #2695 covers the conformance TestMatrix half.

Notes / risks: small and mechanical, as the filer says — but note TestNoUndeclaredEnvRead also fires on internal/daemon/routes_settings.go:906 reading the same variable, so the declaration site must satisfy both the ScriptEnv guard and the consumed-settings guard, not just one.

Suggested approach: one small branch: compendium chapter (or role+reason) for docs/testing/feature-inventory.md + the env declaration; run the settings package tests in CI on the PR.

agent-note:v1
state: triaged (coverage pass)
Coverage pass 2026-11-03: reviewed in the fleet-wide per-issue pass (drift / overlap / already-handled / stale / blockers / ordering). Verdict: still live; queued in repo-health-code-pilot as triage at priority 40 (priority/normal). If this is already handled at current main, the triage closes it with evidence; if it needs splitting, the triage files the split.
Found via: coverage pass 2026-11-03

🤖 Agent note · handed off

Agent: queue worker (repo-worker-code), lane code-j
Session / ID: task 7959
Found via: queue claim
Task: Triage issue mcpx: three internal/settings guard tests fail on main (compendium chapter + undeclared adapter env) #2697 at current main — execution-lane assignment for task 7959 is opencode; handing off to the laptop claimant (opencode-claimant). Re-handoff on attempt 5: previous handoff (2026-11-03T19:39Z, by lane code-i) lease-cycled with no bound session (session_id null at this assignment).
Expectation: effort/s per issue labels; done = triaged at current main with evidence, fix path scoped, or closed with evidence if already handled/superseded.
Links: issue mcpx: three internal/settings guard tests fail on main (compendium chapter + undeclared adapter env) #2697

🤖 Agent note · handed off

Agent: queue worker (repo-worker-code), lane code-b
Session / ID: task 7959
Found via: queue claim
Task: task 7959 for issue mcpx: three internal/settings guard tests fail on main (compendium chapter + undeclared adapter env) #2697 (triage) — execution lane assigned opencode
Expectation: the laptop claimant launches the bound opencode session, which drives task 7959 to its terminal state
Links: issue mcpx: three internal/settings guard tests fail on main (compendium chapter + undeclared adapter env) #2697

🤖 Agent note · picked up

Agent: queue worker (repo-worker-code), OpenChamber scheduled lane c29174f1-48e0-4b13-b4ff-9b73ab67e9ab
Task: 7959 · repo-health-code-pilot (triage)
Verified: mcpx: three internal/settings guard tests fail on main (compendium chapter + undeclared adapter env) #2697 is OPEN; queue/claimed, status/in-progress, and work/assigned are already present. Resuming the prior handoff with fresh main-state verification.
Next: Check whether the settings guard failures remain on fetched main and reconcile the overlap with mcpx: internal/settings (scriptenv) and internal/conformance (TestAuthSplit, TestMatrix) failing on clean main #2716/mcpx docs: 13 pages missing from compendium.manifest.json — TestEveryDocumentHasAChapter red on main #2552 before routing or closing.

🤖 Agent note · handed off

Agent: queue worker (repo-worker-code), lane code-h
Session / ID: task 7959
Found via: queue claim
Task: Triage of issue mcpx: three internal/settings guard tests fail on main (compendium chapter + undeclared adapter env) #2697 (three mcpx internal/settings guard tests failing on main) — execution assigned to the opencode lane; handed off to the laptop claimant (opencode-claimant).
Expectation: Claimant session reproduces the three guard-test failures on current main, identifies root cause, and completes as triaged with findings (or no_longer_reproducible with evidence). Issue mcpx: three internal/settings guard tests fail on main (compendium chapter + undeclared adapter env) #2697 is OPEN with no hard-stop labels.
Links: issue mcpx: three internal/settings guard tests fail on main (compendium chapter + undeclared adapter env) #2697

🤖 Agent note · handed off

Agent: queue worker (repo-worker-code), lane code-d shift
Session / ID: task 7959 (repo-health-code-pilot), claimed 2026-11-04T02:36Z
Found via: queue claim
Task: task 7959 (triage of issue mcpx: three internal/settings guard tests fail on main (compendium chapter + undeclared adapter env) #2697, mcpx: three internal/settings guard tests fail on main) was picked up by lane code-d and assigned execution lane opencode via repo-queue.py lane; handing off to the laptop opencode claimant, which launches the bound session. Claim labels synced by this lane at claim time where needed.
Expectation: done = the claimant session drives task 7959 to a terminal state, or the task returns to the queue if the lease expires unlaunched (attempt 12/12 — AT CAP: strands if this lease expires unlaunched).
Links: issue mcpx: three internal/settings guard tests fail on main (compendium chapter + undeclared adapter env) #2697; queue task 7959

🤖 Agent note · picked up

Agent: queue worker (repo-worker-code), OpenChamber scheduled lane aea12c82-c5af-4e5a-9b66-f8e360f87177
Task: 7959 · repo-health-code-pilot (triage)
Verified: issue mcpx: three internal/settings guard tests fail on main (compendium chapter + undeclared adapter env) #2697 is OPEN, with no hard-stop labels; claim labels are already present. Resuming existing branch queue/7959-2697-triage-settings-guards and worktree /home/user/git/fleet/7959; branch-specific PR lookup is empty.
Next: fetch current main, reproduce the reported guards, and reconcile overlap with mcpx: internal/settings (scriptenv) and internal/conformance (TestAuthSplit, TestMatrix) failing on clean main #2716/mcpx docs: 13 pages missing from compendium.manifest.json — TestEveryDocumentHasAChapter red on main #2552 before recording triage findings.

🤖 Agent note · triaged

Agent: queue worker (repo-worker-code), OpenChamber scheduled lane aea12c82-c5af-4e5a-9b66-f8e360f87177
Task: 7959 · repo-health-code-pilot (triage)
Verified: on current main ef55926de2c3481591ad69c6a576bd504a792204, go test ./internal/settings/ -count=1 still fails. The originally named docs/testing/feature-inventory.md is no longer among the missing compendium entries; the current missing files are TESTING.md and three docs/changes/* pages. The MCPX_ADAPTER_DECLARATION_SHA256 read/setter mismatch still reproduces. The package also reports unrelated plugin-setting, effect-probe, and stale environment-doc failures outside this issue’s original scope.
Routing: the compendium backlog overlaps mcpx docs: 13 pages missing from compendium.manifest.json — TestEveryDocumentHasAChapter red on main #2552 (OPEN, currently queue/claimed; no parallel manifest edit made). The adapter ScriptEnv mismatch is already tracked in mcpx: internal/settings (scriptenv) and internal/conformance (TestAuthSplit, TestMatrix) failing on clean main #2716 (OPEN). No matching open PR was found. The original page omission is fixed and the remaining env work is covered by mcpx: internal/settings (scriptenv) and internal/conformance (TestAuthSplit, TestMatrix) failing on clean main #2716, so this issue is superseded; the broader main-red failures remain tracked for their existing follow-ups.
Links: mcpx docs: 13 pages missing from compendium.manifest.json — TestEveryDocumentHasAChapter red on main #2552, mcpx: internal/settings (scriptenv) and internal/conformance (TestAuthSplit, TestMatrix) failing on clean main #2716

Navigation Menu

Repository navigation

mcpx: three internal/settings guard tests fail on main (compendium chapter + undeclared adapter env) #2697