Repository navigation
mcpx: internal/settings tests red on clean main — TESTING.md missing from compendium manifest, model.* settings lack effect probes, env doc drift #2846
Description
Verified on clean main (2026-10-30, main 382a1a7 / base 497c820) while shepherding PR #2844 — the internal/settings package tests fail deterministically on main itself, unrelated to any PR touching that package:
TestEveryDocumentHasAChapter:pkgs/mcpx/TESTING.mdexists on main but has no chapter/role inpkgs/mcpx/docs/compendium.manifest.json(verified via API: manifest contains no TESTING entry).TestEverySettingHasAnEffectProbeOrAnExemption:model.apiKeyEnv,model.baseURL,model.budget(registered ininternal/settings/model.go) have neither an effect probe nor an exemption.TestTheEnvironmentDocIsCurrent,TestTheScriptEnvironmentIsWhatTheCodeSets,TestNoUndeclaredEnvReadalso fail in the same package run (env doc / undeclared-read drift).
Evidence: PR #2844 stress run 41135632189 job 124337253744 — the PR changes only pluginreadme_test.go, the plugin README, and treefmt.toml, none of the failing surfaces; the failures repeat identically under -count=10.
Acceptance: settings package tests green on clean main — add the TESTING.md chapter (or a role+reason exemption), add effect probes or exemptions for the model.* settings, and bring the environment doc current.
Filed as the pre-existing-failure record for PR #2844 merging under the standing criteria (its own TestThePlugin* tests pass; Codex clean on head 357bf01).
Acceptance criteria
-
go test ./internal/settings/...(pkgs/mcpx) passes on clean main - pkgs/mcpx/TESTING.md has a chapter/role in pkgs/mcpx/docs/compendium.manifest.json, or a role+reason exemption
- model.apiKeyEnv, model.baseURL and model.budget each have an effect probe or an exemption in the settings registry
- TestTheEnvironmentDocIsCurrent, TestTheScriptEnvironmentIsWhatTheCodeSets and TestNoUndeclaredEnvRead pass — the environment doc matches the code
Activity
dezren39 commentedon Oct 30, 2026
Intake review
Fleet monitor intake pass (protocol §5). Verified live this run: no merged PR explicitly resolves this issue (search hits were number coincidences in unrelated PR bodies), and the problem statement is grounded in the filer's own run evidence.
Related: Related: PR #2844 (shepherded when this was found; its own tests pass, these failures are pre-existing on main), issue #1996 (mcpx lint leg — neighbouring main-red surface).
Notes / risks / suggested approach: The failures are deterministic (-count=10) and package-scoped, so this is a contained fix: manifest chapter, three settings probes/exemptions, env-doc drift. Risk: low — docs/registry/test metadata, no runtime behaviour change expected. Suggested approach: fix in the order the tests name the gaps; re-run the full internal/settings package, not just the failing tests.
developing-today commentedon Nov 3, 2026
agent-note:v1
state: triaged (coverage pass)
Coverage pass 2026-11-03: reviewed in the fleet-wide per-issue pass (drift / overlap / already-handled / stale / blockers / ordering). Verdict: still live; queued in repo-health-code-pilot as triage at priority 40 (priority/normal). If this is already handled at current main, the triage closes it with evidence; if it needs splitting, the triage files the split.
Found via: coverage pass 2026-11-03
dezren39 commentedon Nov 3, 2026
agent-note:v1
state: re-verified
Found via: new-issue-creator-code-a run, 2026-11-03 —
go test ./internal/settings/in pkgs/mcpx fails identically in the laptop primary clone (f550877) and at origin/main (no pkgs/mcpx commits between the two). Five tests red today:Cross-refs: #2716 (scriptenv red on main), #2697 (undeclared adapter env), #2552 (compendium manifest). The MCPX_EPHEMERAL / MCPX_TRANSPORT_BEARER_TOKEN setter gaps and the three docs/changes/* manifest gaps may postdate those filings. Full suite otherwise: the rest of pkgs/mcpx passed in the same run; only internal/settings failed.
dezren39 commentedon Nov 3, 2026
agent-note:v1
state: picked up
Queue task: 7987 (repo-health-code-pilot); worker: repo-worker-code; lane: ec118cad-0fd3-4652-91c4-27432f2f2efd. Revalidating current main and related fixes before routing.
dezren39 commentedon Nov 3, 2026
agent-note:v1
state: superseded
Triage task 7987 / OpenChamber scheduled lane: closed as superseded by #2716, which is the broader live tracker for the same clean-main internal/settings failure cluster plus related conformance failures.
Verified 2026-11-03 on pristine task worktree at origin/main 7d3dbd0:
cd pkgs/mcpx && go test ./internal/settings/...fails in TestEveryDocumentHasAChapter (TESTING.md and three docs/changes pages missing from compendium.manifest.json), TestNoUndeclaredEnvRead (MCPX_ADAPTER_DECLARATION_SHA256), TestEverySettingHasAnEffectProbeOrAnExemption (proto.elicitationPerMinute, proto.samplingPerMinute, proto.samplingSessionPerMinute, script.imports, script.importsOnDynamic), TestTheScriptEnvironmentIsWhatTheCodeSets (adapter declaration SHA, MCPX_EPHEMERAL and MCPX_TRANSPORT_BEARER_TOKEN setters), and TestTheEnvironmentDocIsCurrent. This current failure set does not include the model.apiKeyEnv/baseURL/budget gaps named in this issue's original body; that part is stale.Overlap: #2697 covers the adapter-env subset (its triage task 7959 is currently claimed); #2552 covers the manifest subset (triage task 7337 is queued). #2716's latest current-main triage note already records this full 5-test settings cluster and its combined fix route. No open PR resolving #2846 was found. Keep remediation consolidated under #2716; no competing fix task or PR created here.