id(lib): references.rs does not compile — LocalIndex derives Default over a StoreId with no Default impl, and from_markdown breaks with a borrow of a loop-local String (PR #2756)

Summary

pkgs/id/src/references.rs, landed today by PR #2756 (merge 4b6d1f9, 2026-11-02T16:04Z, for #2259), does not compile. The module is declared unconditionally (pub mod references;, pkgs/id/src/lib.rs:213), so the id lib build on current main (verified at 466cf98) fails with two errors, both in references.rs:

E0277 — LocalIndex derives Default over a field whose type has none. references.rs:301-303: #[derive(Clone, Debug, Default)] pub struct LocalIndex { store: StoreId, ... }, but StoreId (references.rs:61-63) derives only Clone, Debug, PartialEq, Eq, PartialOrd, Ord, and there is no impl Default for StoreId anywhere in pkgs/id/src, pkgs/id/crates, or pkgs/id/tests (grep-verified this run).
E0597 — Reference::from_markdown breaks out of its parse loop with a borrow of a loop-local String. references.rs:122-124: the arm binds let rest: String = chars.collect(); and then break rest.strip_prefix("id://")?.strip_suffix(')')?; — the break value is a &str borrowed from rest, which is dropped at the end of the match arm while the borrowed value is stored in hex outside the loop.

Evidence (verified this run, laptop probe)

Probe: ~/git/fleet/probe-2026-11-02-laneA-references/ on the laptop — references.rs copied verbatim from main (md5 b939a8c3b71faa4fef2958834888ce1c, matched against the sandbox clone, the laptop copy, and the GitHub API copy of the file at main), with only a minimal p2panda_core::Hash shim and a waiting::AuthorKey = [u8; 32] stub around it. cargo test --offline on the verbatim file (log: verbatim-output.txt in the probe dir):

error[E0277]: the trait bound `StoreId: Default` is not satisfied   (src/references.rs:303)
error[E0597]: `rest` does not live long enough                      (src/references.rs:124)
error: could not compile `probe` (lib) due to 2 previous errors     (cargo-exit:101)

Both error patterns were additionally reproduced as minimal standalone files on both rustc 1.98 and the repo-pinned rustc 1.99 (edition 2024), so neither is a shim or toolchain artifact. With exactly two minimal fixes applied to the probe copy only — a Default impl for StoreId in the probe's lib.rs, and .to_owned() on the from_markdown break value — the module compiles and all 12 of its own unit tests pass (patched-output.txt), confirming these are the only two errors and that the tests were written against a compiling version that never landed.

Caveat: a full cargo check -p id --lib on the real crate was started in a laptop fleet worktree but stayed blocked behind another lane's build-directory lock for the duration of this run; the verbatim-file probe plus the isolated reproductions are the verification. PR #2756's checks at merge were CodeRabbit only (skipping) — no CI compile ran on it.

Why it matters

Every id build, test run, and Nix build on main is broken until this is fixed, and the failure is invisible to the feature-gated build-rot issues already tracked (#4340 web-feature tests, #4159 --no-default-features, #3962 ssh feature — all different feature sets; this one is the default lib build). Any lane now building pkgs/id on current main will hit these two errors first and may misattribute them to its own change.

Acceptance criteria

cargo check -p id --lib (default features) compiles on main: StoreId gains a Default impl (or LocalIndex drops the derive and constructs its store explicitly), and from_markdown no longer borrows across the loop break (e.g. the hex slice is owned, or rest is bound outside the loop).
cargo test -p id --lib references passes — the module's 12 existing unit tests, including the markdown round-trip tests that exercise from_markdown.
No other module's behavior changes; the fix is confined to references.rs (plus, if the Default impl is placed there, that same file).

Distinct from: #4340 (web-feature test rot in web/routes.rs), #4159 (--no-default-features gating in chat.rs/invite.rs), #3962 (ssh-feature compile), #3923 (id-core test compile — different crate).

🤖 Agent note · state: filed

Agent: new-issue-creator job (new-issue-creator-code-a)
Session / ID: cron job new-issue-creator-code-a, run 2026-11-02T16:05Z
Found via: filed this run
Task: Filed issue id(lib): references.rs does not compile — LocalIndex derives Default over a StoreId with no Default impl, and from_markdown breaks with a borrow of a loop-local String (PR #2756) #4454 — references.rs (PR id: local-store PoC for friendly-name reference resolution (#2259) #2756, merged today) does not compile: E0277 (LocalIndex Default over StoreId) + E0597 (from_markdown loop-local borrow); the default id lib build on main is broken.
Expectation: effort/xs — two minimal fixes in references.rs; done when cargo check -p id --lib compiles and the module's 12 unit tests pass.
Links: probe ~/git/fleet/probe-2026-11-02-laneA-references/ (laptop; verbatim-output.txt = the 2 errors, patched-output.txt = 12/12 tests pass with the two minimal fixes)

Pickup by repo queue worker lane H for task 6354 (triage of #4454). Revalidating the two references.rs compile errors against current main and routing the fix; no hard-stop labels on #4454, PR #2756 confirmed MERGED 2026-11-02T16:04:19Z, and no open PR owns a references.rs compile fix.

🤖 Agent note · handed off

Agent: queue worker (repo-worker-code), lane I (code-i)
Session / ID: task 6359
Found via: queue claim
Task: Fix for issue id(lib): references.rs does not compile — LocalIndex derives Default over a StoreId with no Default impl, and from_markdown breaks with a borrow of a loop-local String (PR #2756) #4454 (references.rs compile restore) is assigned to the opencode execution lane; the laptop claimant launches the bound opencode session for task 6359, and that session drives it to its terminal state. Resume state from the prior checkpoint: PR fix(id): restore references.rs build — Default for StoreId, own the from_markdown hex slice #4477 is OPEN (head 9637726 at park time; re-verify fresh), cargo check -p id --lib passed on the laptop, and the references test result was still compiling at the previous shift's end (~/test6359.log on the laptop, or re-run cargo test -p id --lib references). Remaining: confirm the test result, disposition PR fix(id): restore references.rs build — Default for StoreId, own the from_markdown hex slice #4477 checks/Codex findings, merge, complete task 6359.
Expectation: effort xs; done = PR fix(id): restore references.rs build — Default for StoreId, own the from_markdown hex slice #4477 merged with the references tests green and issue id(lib): references.rs does not compile — LocalIndex derives Default over a StoreId with no Default impl, and from_markdown breaks with a borrow of a loop-local String (PR #2756) #4454 closed.
Links: issue id(lib): references.rs does not compile — LocalIndex derives Default over a StoreId with no Default impl, and from_markdown breaks with a borrow of a loop-local String (PR #2756) #4454; PR fix(id): restore references.rs build — Default for StoreId, own the from_markdown hex slice #4477; task 6359

🤖 Agent note · handed off

Agent: opencode-claimant
Task: repo-health-code-pilot task 6359, issue id(lib): references.rs does not compile — LocalIndex derives Default over a StoreId with no Default impl, and from_markdown breaks with a borrow of a loop-local String (PR #2756) #4454
Session / ID: ses_e5e629855a3ffeIRpeaZydLvC2
Worker: repo-worker-code (the bound worker will use this id for all queue helper verbs)
Route: opencode-route/workhorse, agent build
State: claimed task bound at launch; OpenCode worker prompt admitted.

🤖 Agent note · done

Agent: queue worker (repo-worker-code), opencode execution lane
Session / ID: task 6359 (ses_e5e629855a3ffeIRpeaZydLvC2)
Found via: bound opencode session resume; revalidated fresh GitHub state
Task: Fix for issue id(lib): references.rs does not compile — LocalIndex derives Default over a StoreId with no Default impl, and from_markdown breaks with a borrow of a loop-local String (PR #2756) #4454 is merged: PR fix(id): restore references.rs build — Default for StoreId, own the from_markdown hex slice #4477 (branch queue/6359-4454-references-compile, head 9637726) merged 2026-11-02T17:52:12Z as 0292915 (merged by dezren39); issue id(lib): references.rs does not compile — LocalIndex derives Default over a StoreId with no Default impl, and from_markdown breaks with a borrow of a loop-local String (PR #2756) #4454 CLOSED COMPLETED 2026-11-02T17:52:14Z. Diff confined to pkgs/id/src/references.rs (+11/-1): impl Default for StoreId + .to_owned() in from_markdown. Verified on origin/main: Default impl at references.rs:72, owned hex slice at :134; merge commit is ancestor of origin/main. Checks: basic guard SUCCESS, CodeRabbit neutral, Codex review completed with zero findings. Prior laptop evidence: cargo check -p id --lib PASS (exit 0); triage probe ran all 12 references tests green with these fixes.
Expectation: done = PR merged, issue closed, labels cleared
Links: PR fix(id): restore references.rs build — Default for StoreId, own the from_markdown hex slice #4477 fix(id): restore references.rs build — Default for StoreId, own the from_markdown hex slice #4477 · merge 0292915

Navigation Menu

Repository navigation

id(lib): references.rs does not compile — LocalIndex derives Default over a StoreId with no Default impl, and from_markdown breaks with a borrow of a loop-local String (PR #2756) #4454

Summary

Evidence (verified this run, laptop probe)

Why it matters

Acceptance criteria

17 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

id(lib): references.rs does not compile — LocalIndex derives Default over a StoreId with no Default impl, and from_markdown breaks with a borrow of a loop-local String (PR #2756) #4454

Description

Summary

Evidence (verified this run, laptop probe)

Why it matters

Acceptance criteria

Activity

dezren39 commented on Nov 2, 2026

dezren39 commented on Nov 2, 2026

17 remaining items

dezren39 commented on Nov 2, 2026

dezren39 commented on Nov 2, 2026

dezren39 commented on Nov 2, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions