Skip to content

id: split pkgs/id/src/cli.rs (2,598 production lines) — remove the F11.10 line-guard grandfather entry #4715

Open

Description

@dezren39

Why

pkgs/id/src/cli.rs — the very file F11.10 (#808) split — has regrown to 2,598 production lines, over the 2,500 limit. Counted with the corrected production-line method in the #1411 guard (PR #4709): all lines except #[cfg(test)] items (the original audit method, lines-before-first-cfg(test), undercounts this file at 2,499 because test items are interleaved with production code).

The guard grandfathers this file explicitly so the check passes on current main while failing on any NEW violator. This issue is the linked removal condition: when cli.rs is split below the limit, delete its grandfather entry from .github/scripts/check-production-line-limit.sh.

Acceptance criteria

  • No production file resulting from the split exceeds 2,500 production lines; existing tests pass unchanged.
  • Grandfather entry for pkgs/id/src/cli.rs removed from the line guard in the same PR.

Filed by repo queue worker (task 6592) from #1411.

Activity

  1. added
    app/idPackage/app: id (pkgs/ or apps/ in this repo)
    on Nov 3, 2026
  2. dezren39 commented on Nov 3, 2026

    @dezren39
    MemberAuthor

    Intake review

    Related: issue #808 (original F11.10 split of this file), issue #1411 (guard, PR #4709), issue #4716, issue #4717 (siblings). Notes: cli.rs regrew past the limit after being the file the rule was created for — worth noting in the PR whether a subcommand group has grown disproportionately. Risks: CLI argument parsing is behaviour-sensitive (help text, error messages); keep clap definitions byte-identical where possible. Suggested approach: split by subcommand family into sibling modules, remove the grandfather entry in the same PR.

    — Fleet monitor intake (protocol §5), 2026-11-03T02:29:50Z. Labels normalized and meta/enriched applied; the issue already carried acceptance criteria.

  3. added
    kind/refactorCode restructuring with no behavior change
    source/queue-workerFiled or worked by the queue/worker pilot
    priority/normalOrdinary priority (the default)
    effort/mMedium: expected under 1 day of work
    meta/enrichedIntake review done: acceptance criteria, links, and normalized labels added
    on Nov 3, 2026
  4. added
    queue/queuedHas a queued task in the Supabase agent queue
    task/triageQueue packet kind: verify, reproduce, and route this item
    on Nov 3, 2026
  5. developing-today commented on Nov 3, 2026

    @developing-today
    Contributor

    agent-note:v1
    state: triaged (coverage pass)
    Coverage pass 2026-11-03: reviewed in the fleet-wide per-issue pass (drift / overlap / already-handled / stale / blockers / ordering). Verdict: still live; queued in repo-health-code-pilot as triage at priority 40 (priority/normal). If this is already handled at current main, the triage closes it with evidence; if it needs splitting, the triage files the split.
    Found via: coverage pass 2026-11-03

  6. dezren39 commented on Nov 3, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · triaged — still live, fix scoped, follow-up enqueued

    • Agent: queue worker (repo-worker-code), lane 1a180ae5 (openchamber scheduled lane)
    • Session / ID: task 8423 (triage, attempt 1)
    • Found via: queue claim, verified at main dda1def
    • Verdict: still live. pkgs/id/src/cli.rs = 2,529 production lines (guard limit 2,500; 2,504 when the guard landed), grandfather entry present at .github/scripts/check-production-line-limit.sh:36 linking here. No open PR owns the split; no held/Drew-owned restriction. Siblings id: split pkgs/id/src/web/routes.rs (2,573 production lines) — remove the F11.10 line-guard grandfather entry #4716/id: split pkgs/id/src/world_session/mod.rs (2,821 production lines) — remove the F11.10 line-guard grandfather entry #4717 are separate open issues with their own entries — independent.
    • Fix path: split by subcommand family into sibling modules (World ~900 + Doc/Claim/Tag ~400 + WorldRuntime ~160 + top-level ~1.1k stay under limit in every layout); keep clap definitions byte-identical; remove the grandfather entry in the same PR; verify with the guard script + cargo test -p id.
    • Observation (not a blocker): running the guard from a checkout containing pkgs/id/target/ false-positives on generated bindgen.rs (3,432 lines); clean checkouts/CI unaffected.
    • Follow-up: implementation enqueued as queue task 8768 (small_fix, 45-min timebox).
  7. 12 remaining items

  8. added and removed
    queue/queuedHas a queued task in the Supabase agent queue
    on Nov 4, 2026
  9. dezren39 commented on Nov 4, 2026

    @dezren39
    MemberAuthor

    agent-note:v1

  10. dezren39 commented on Nov 4, 2026

    @dezren39
    MemberAuthor

    agent-note:v1
    task: 8768
    kind: small_fix
    state: picked_up -> handed_off (execution lane: opencode) — attempt 11/12, re-handoff
    lane: code-h (claiming), execution via opencode claimant
    evidence: issue #4715 OPEN, labels queue/claimed + status/in-progress + work/assigned; no hard-stop labels. Prior handoff (05:14Z) expired without a launched session; this is attempt 11 of 12 — the claimant should treat launch as urgent, since one more evaporation caps the task.
    next: opencode-claimant launches the bound session and drives the cli.rs split (below the 2,500-line guard, grandfather entry removed in the same PR, cargo test -p id unchanged) to a terminal state.

  11. dezren39 commented on Nov 4, 2026

    @dezren39
    MemberAuthor

    Agent note — task 8768 handed off to opencode execution lane

    • Lane: code-v (repo-worker-code), claimed 2026-11-04
    • Execution-lane assignment (repo-queue lane task 8768): opencode
    • Per worker instruction §1b, this lane does not work the task directly and creates no worktree. The laptop opencode-claimant launches a session bound to task 8768 to drive it to a terminal state.
    • Checkpointed as handed_off. If the claimant has not launched by lease expiry, task 8768 returns to the queue.
  12. dezren39 commented on Nov 4, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · picked up

  13. dezren39 commented on Nov 4, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · handed off

    • Agent: queue worker (repo-worker-code), lane code-a
    • Session / ID: task 8768
    • Found via: queue claim
    • Task: execution lane is opencode — handed to the opencode claimant, which launches a session bound to task 8768
    • Expectation: claimant session drives task 8768 to its terminal state
    • Links: queue task 8768
  14. dezren39 commented on Nov 4, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · handed off

  15. added
    queue/queuedHas a queued task in the Supabase agent queue
    and removed
    queue/claimedQueue worker lifecycle state
    work/assignedQueue worker lifecycle state
    on Nov 5, 2026
  16. dezren39 commented on Nov 5, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · handed off

    • Agent: fleet monitor
    • Session / ID: task 8768 (repo-fleet-monitor run 2026-11-05T15:45:48Z)
    • Found via: monitor reconciliation (Duty 1 claim/label divergence repair)
    • Task: Claim evaporated: task 8768 is queued and unclaimed in repo-health-code-pilot, but this issue still carried claimed labels. Labels reset to the truth (queue/queued + status/needs-triage). Checkpoint stage at evaporation: handed_off.
    • Expectation: The next lane claim picks task 8768 up from the queued state and posts a fresh pickup note.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

app/idPackage/app: id (pkgs/ or apps/ in this repo)effort/mMedium: expected under 1 day of workkind/refactorCode restructuring with no behavior changemeta/enrichedIntake review done: acceptance criteria, links, and normalized labels addedpriority/normalOrdinary priority (the default)queue/queuedHas a queued task in the Supabase agent queuesource/queue-workerFiled or worked by the queue/worker pilotstatus/needs-triageNot yet triaged; needs a first looktask/triageQueue packet kind: verify, reproduce, and route this item

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions