Skip to content

id: split pkgs/id/src/world_session/mod.rs (2,821 production lines) — remove the F11.10 line-guard grandfather entry #4717

Open

Description

@dezren39

Why

pkgs/id/src/world_session/mod.rs is 2,821 production lines, over the F11.10 2,500 limit. It declares its test modules out-of-line at the top of the file (lines 49-52), so the original #1078 audit method (lines before the first #[cfg(test)]) counted only 48 production lines for it — the gap a Codex review finding on PR #4709 exposed. The corrected guard method (all lines except #[cfg(test)] items) counts 2,821, verified by two independent implementations.

The guard grandfathers this file explicitly so the check passes on current main while failing on any NEW violator. This issue is the linked removal condition: when mod.rs is split below the limit, delete its grandfather entry from .github/scripts/check-production-line-limit.sh.

Acceptance criteria

  • No production file resulting from the split exceeds 2,500 production lines; existing tests pass unchanged.
  • Grandfather entry for pkgs/id/src/world_session/mod.rs removed from the line guard in the same PR.

Filed by repo queue worker (task 6592) from #1411.

Activity

  1. added
    app/idPackage/app: id (pkgs/ or apps/ in this repo)
    on Nov 3, 2026
  2. dezren39 commented on Nov 3, 2026

    @dezren39
    MemberAuthor

    Intake review

    Related: issue #1411 (F11.10 line guard, PR #4709), issue #4715, issue #4716 (sibling grandfather-removal issues from the same filing). Notes: the split must be verified with the corrected production-line counting method (all lines except #[cfg(test)] items), not the original audit method that undercounted this file at 48 lines. Risks: world_session is a session hot path — a mechanical split that changes module visibility or re-export shape can break downstream imports; keep the public surface identical. Suggested approach: split by submodule along the existing out-of-line test-module seams, re-export unchanged, remove the grandfather entry in the same PR.

    — Fleet monitor intake (protocol §5), 2026-11-03T02:29:50Z. Labels normalized and meta/enriched applied; the issue already carried acceptance criteria.

  3. added
    kind/refactorCode restructuring with no behavior change
    source/queue-workerFiled or worked by the queue/worker pilot
    priority/normalOrdinary priority (the default)
    effort/mMedium: expected under 1 day of work
    meta/enrichedIntake review done: acceptance criteria, links, and normalized labels added
    on Nov 3, 2026
  4. added
    queue/queuedHas a queued task in the Supabase agent queue
    task/triageQueue packet kind: verify, reproduce, and route this item
    on Nov 3, 2026
  5. dezren39 commented on Nov 3, 2026

    @dezren39
    MemberAuthor

    agent-note:v1
    state: triaged (coverage pass)
    Coverage pass 2026-11-03: reviewed in the fleet-wide per-issue pass (drift / overlap / already-handled / stale / blockers / ordering). Verdict: still live; queued in repo-health-code-pilot as triage at priority 40 (priority/normal). If this is already handled at current main, the triage closes it with evidence; if it needs splitting, the triage files the split.
    Found via: coverage pass 2026-11-03

  6. 93 remaining items

  7. dezren39 commented on Nov 4, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · parked

  8. added
    queue/claimedQueue worker lifecycle state
    and removed
    status/parkedDeliberately paused with a recorded resume condition
    queue/parkedQueue task is parked (waiting on CI, time, or an event)
    on Nov 4, 2026
  9. dezren39 commented on Nov 4, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · picked up

  10. added
    queue/parkedQueue task is parked (waiting on CI, time, or an event)
    status/parkedDeliberately paused with a recorded resume condition
    and removed
    queue/claimedQueue worker lifecycle state
    on Nov 4, 2026
  11. dezren39 commented on Nov 4, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · parked

  12. added
    queue/queuedHas a queued task in the Supabase agent queue
    and removed
    work/assignedQueue worker lifecycle state
    on Nov 5, 2026
  13. dezren39 commented on Nov 5, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · handed off

    • Agent: fleet monitor
    • Session / ID: task 8835 (repo-fleet-monitor run 2026-11-05T15:45:48Z)
    • Found via: monitor reconciliation (Duty 1 claim/label divergence repair)
    • Task: Claim evaporated: task 8835 is queued and unclaimed in repo-health-code-pilot, but this issue still carried claimed labels. Labels reset to the truth (queue/queued + status/needs-triage). Checkpoint stage at evaporation: handed_off.
    • Expectation: The next lane claim picks task 8835 up from the queued state and posts a fresh pickup note.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

app/idPackage/app: id (pkgs/ or apps/ in this repo)effort/mMedium: expected under 1 day of workkind/refactorCode restructuring with no behavior changemeta/enrichedIntake review done: acceptance criteria, links, and normalized labels addedpriority/normalOrdinary priority (the default)queue/parkedQueue task is parked (waiting on CI, time, or an event)queue/queuedHas a queued task in the Supabase agent queuesource/queue-workerFiled or worked by the queue/worker pilotstatus/needs-triageNot yet triaged; needs a first lookstatus/parkedDeliberately paused with a recorded resume conditiontask/small-fixQueue packet kind: bounded fix with reproduction and targeted tests

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions