Repository navigation
Description
Why
pkgs/id/src/world_session/mod.rs is 2,821 production lines, over the F11.10 2,500 limit. It declares its test modules out-of-line at the top of the file (lines 49-52), so the original #1078 audit method (lines before the first #[cfg(test)]) counted only 48 production lines for it — the gap a Codex review finding on PR #4709 exposed. The corrected guard method (all lines except #[cfg(test)] items) counts 2,821, verified by two independent implementations.
The guard grandfathers this file explicitly so the check passes on current main while failing on any NEW violator. This issue is the linked removal condition: when mod.rs is split below the limit, delete its grandfather entry from .github/scripts/check-production-line-limit.sh.
Acceptance criteria
- No production file resulting from the split exceeds 2,500 production lines; existing tests pass unchanged.
- Grandfather entry for pkgs/id/src/world_session/mod.rs removed from the line guard in the same PR.
Filed by repo queue worker (task 6592) from #1411.
Activity
fix: correct split-issue links in grandfather list (#4715/#4716/#4717,…
dezren39 commentedon Nov 3, 2026
Intake review
Related: issue #1411 (F11.10 line guard, PR #4709), issue #4715, issue #4716 (sibling grandfather-removal issues from the same filing). Notes: the split must be verified with the corrected production-line counting method (all lines except #[cfg(test)] items), not the original audit method that undercounted this file at 48 lines. Risks: world_session is a session hot path — a mechanical split that changes module visibility or re-export shape can break downstream imports; keep the public surface identical. Suggested approach: split by submodule along the existing out-of-line test-module seams, re-export unchanged, remove the grandfather entry in the same PR.
— Fleet monitor intake (protocol §5), 2026-11-03T02:29:50Z. Labels normalized and
meta/enrichedapplied; the issue already carried acceptance criteria.dezren39 commentedon Nov 3, 2026
agent-note:v1
state: triaged (coverage pass)
Coverage pass 2026-11-03: reviewed in the fleet-wide per-issue pass (drift / overlap / already-handled / stale / blockers / ordering). Verdict: still live; queued in repo-health-code-pilot as triage at priority 40 (priority/normal). If this is already handled at current main, the triage closes it with evidence; if it needs splitting, the triage files the split.
Found via: coverage pass 2026-11-03
93 remaining items
dezren39 commentedon Nov 4, 2026
🤖 Agent note · parked
dezren39 commentedon Nov 4, 2026
🤖 Agent note · picked up
dezren39 commentedon Nov 4, 2026
🤖 Agent note · parked
dezren39 commentedon Nov 5, 2026
🤖 Agent note · handed off