Repository navigation
id: split pkgs/id/src/web/routes.rs (2,573 production lines) — remove the F11.10 line-guard grandfather entry #4716
Description
Why
pkgs/id/src/web/routes.rs is 2,573 production lines, over the F11.10 2,500 limit, counted with the corrected production-line method in the #1411 guard (PR #4709): all lines except #[cfg(test)] items (the original audit method undercounts this file at 2,415 because test items are interleaved with production code).
The guard grandfathers this file explicitly so the check passes on current main while failing on any NEW violator. This issue is the linked removal condition: when routes.rs is split below the limit, delete its grandfather entry from .github/scripts/check-production-line-limit.sh.
Acceptance criteria
- No production file resulting from the split exceeds 2,500 production lines; existing tests pass unchanged.
- Grandfather entry for pkgs/id/src/web/routes.rs removed from the line guard in the same PR.
Filed by repo queue worker (task 6592) from #1411.
Metadata
Metadata
Assignees
Labels
Package/app: id (pkgs/ or apps/ in this repo)Medium: expected under 1 day of workCode restructuring with no behavior changeIntake review done: acceptance criteria, links, and normalized labels addedOrdinary priority (the default)Filed or worked by the queue/worker pilotQueue packet kind: verify, reproduce, and route this item
Activity
fix: correct split-issue links in grandfather list (#4715/#4716/#4717,…
dezren39 commentedon Nov 3, 2026
Intake review
Related: issue #1411 (F11.10 line guard, PR #4709), issue #4715, issue #4717 (siblings). Notes: routes.rs is only 73 lines over the limit — the smallest split of the three; the corrected counting method (interleaved test items) must be used to verify the result. Risks: route registration order/shadowing if handlers move modules carelessly. Suggested approach: extract one cohesive route group into a sibling module, keep registration order identical, remove the grandfather entry in the same PR.
— Fleet monitor intake (protocol §5), 2026-11-03T02:29:50Z. Labels normalized and
meta/enrichedapplied; the issue already carried acceptance criteria.dezren39 commentedon Nov 3, 2026
agent-note:v1
state: triaged (coverage pass)
Coverage pass 2026-11-03: reviewed in the fleet-wide per-issue pass (drift / overlap / already-handled / stale / blockers / ordering). Verdict: still live; queued in repo-health-code-pilot as triage at priority 40 (priority/normal). If this is already handled at current main, the triage closes it with evidence; if it needs splitting, the triage files the split.
Found via: coverage pass 2026-11-03
dezren39 commentedon Nov 3, 2026
agent-note:v1
event: triaged
task: 8427 (repo-health-code-pilot; openchamber-scheduled-lane 9aca43b4-5439-4939-9f71-323f5d32521b)
verdict: still live on main; split not started (triage only). Fix path scoped below.
main (origin/main 2f62ce6):
pkgs/id/src/web/routes.rsis 4,049 raw lines. The guard (.github/scripts/check-production-line-limit.sh) counts 2,573 production lines, so it is still over 2,500 by 73 lines. The grandfather entry for this file is still in the guard.scope of the split: move at least 74 production lines out to a sibling module, then delete the grandfather entry in the same PR. Candidate cohesive group: the identity handlers (
identity_register_handler,identity_me_handler,identity_update_name_handler, around lines 3157-3275, about 120 production lines). Moving them topkgs/id/src/web/routes/identity.rs(a sibling of routes.rs, no mod.rs needed) would leave about 2,450 lines, just under the limit. Keep the router registration order increate_router_inneridentical. Check the guard after the move, on the corrected count (test items excluded).blocker/ordering: open PR #4107 (
queue/5188-2143-groups-page, /groups page, feat(id) #2143) also touchesroutes.rsand adds about 302 lines (last updated 2026-11-02, no review, not draft). Land #4107 first, or rebase the split on top of it, otherwise the two conflict and the split count changes. Decide the order before implementing. Related siblings: #4715 (cli.rs), #4717 (world_session/mod.rs).next: implementation task only after #4107 lands or is closed. Issue stays open.